What's wrong with this code (or the SQL query)?

WMUWSE

Hi guys,

Here is a small part of my code...

	$category = $_POST['category'];
	$name = $_POST['name'];
	$latin_name = $_POST['latin_name'];
	$location = $_POST['location'];
	$camera_model = $_POST['camera_model'];
	$lens_model = $_POST['lens_model'];
	$focal_length = $_POST['focal_length'];
	$fnumber = $_POST['fnumber'];
	$exposure_time = $_POST['exposure_time'];
	$iso_speed = $_POST['iso_speed'];
	$date_taken = $_POST['date_taken'];
	$comment = $_POST['comment'];
	$query = "INSERT INTO photos (category,name,name_latin,location,camera_model,lens_model,focal_length,f-number,exposure_time,iso_speed,date_taken,comment) VALUES($category,$name,$latin_name,$location,$camera_model,$lens_model,$focal_length,$fnumber,$exposure_time,$iso_speed,$date_taken,$comment)";
	mysql_query($query);

It gives me no errors but no data is put into the 'photos' table. Any ideas?

Thanks

Houdini

You have the name_latin in the database and the $latin_name as a variable for it the latter does not matter but the name_latin does. plus you are not checking for errors when doing a query so you don't know if they fail.

thorpe

Your values also need to be surrounded in quotes.

$sql = "INSERT INTO tbl (fld1,fld2) VALUES ('$val1','$val2');";

scrypte

i have a question

why dont you just put

session_start();

// SET VARIABLES
foreach($_POST as $k => $v) {
    if ($k != 'submit') {
    	$_SESSION[$k] = $v;
    }
}

then you dont have to put

$category = $_POST['category'];
$name = $_POST['name'];
$latin_name = $_POST['latin_name'];
$location = $_POST['location'];
$camera_model = $_POST['camera_model'];
$lens_model = $_POST['lens_model'];
$focal_length = $_POST['focal_length'];
$fnumber = $_POST['fnumber'];
$exposure_time = $_POST['exposure_time'];
$iso_speed = $_POST['iso_speed'];
$date_taken = $_POST['date_taken'];
$comment = $_POST['comment'];

it will be set for you as a session

for the error handling try this

if ($proc=="1") {

// Check to make sure fields are not empty! //
if ($zemail=="") {
        echo "<Span class=blackbold>ERROR: You did not enter your email address.</span>";
        Exit;
}

Houdini

Well to handle a MySQL error (not PHP errors)

mysql_query($query);

should be written something like

mysql_query($query)
  or die("The query failed MySQL said ".mysql_error());

then you can see if it were the sql or the PHP.