Help with small script

arachn1d

<?php
mysql_connect(localhost, root, hey);
mysql_select_db(rssfeed);
$title = $_POST['title'];
$url = $_POST['url'];


echo "<form action='rss.php' method='post'>";
echo "Title";
echo "<input type='text' name='title' size='35' maxlength='150' value='' /><br />";
echo "URL";
echo "<input type='text' name='url' size='35' maxlength='150' value='' /><br />";
echo "<input type='submit' value='submit'>";
echo "</form>";
$sql = "INSERT INTO rssfeed VALUES ('', '$title', '$url')";
mysql_query($sql);
?>

<?php
echo "current feeds: <br />";
$query = "SELECT * FROM rssfeed";
$result = mysql_query($query);
$num = mysql_numrows($result);


$i = 0;
while ($i < $num){

$id = mysql_result($result, $i, "rowID");
$title = mysql_result($result, $i, "title");
$url = mysql_result($result, $i, "url");

echo "$id<b>Title</b> $title : <b>Url</b> $url : <a href='rss.php?d=$id'>[x]</a><br />";
$i++;
}
$d = $_GET['d'];
if ($d = $id){
	$delete = "DELETE FROM rssfeed WHERE rowID='$id'";
}
?>

I have two problems with this script.

1) Everytime I refesh a new record is added.
2) The link to delete the record isn't working. Any help with getting this function to work would be great 😉.

devinemke

arachn1d wrote:
1) Everytime I refesh a new record is added.
2) The link to delete the record isn't working.

1) of course. every time you refresh you are resubmitting the form. if you wish to prevent duplicate records then run a SELECT query before the INSERT to check if the submitted data is already in the db.

2) no rows are ever deleted because you are never running the DELETE query, you are just creating a string with the sql. even if you do run the query only the last row will be deleted as that is the last row that will equal $id. you should run the DELETE before the SELECT and delete which ever row is passed in the $_GET['d'] variable.

arachn1d

<?php

mysql_connect('localhost', 'root', 'hey');
mysql_select_db('rssfeed');

echo "<form action='rss.php' method='post'>";
echo "Title";
echo "<input type='text' name='title' size='35' maxlength='150' value='' /><br />";
echo "URL";
echo "<input type='text' name='url' size='35' maxlength='150' value='' /><br />";
echo "<input type='submit' value='submit'>";
echo "</form>";
$title = $_POST['title'];
$url = $_POST['url'];


if(isset($_POST['title'],  $_POST['url'])){
	$sql = "INSERT INTO rssfeed VALUES ('', '$title', '$url')";
	mysql_query($sql);
}
?>

<?php
echo "current feeds: <br />";

$query = "SELECT * FROM rssfeed";
$result = mysql_query($query);
$num = mysql_numrows($result);


$i = 0;
while ($i < $num){

$id = mysql_result($result, $i, "rowID");
$title = mysql_result($result, $i, "title");
$url = mysql_result($result, $i, "url");

echo "$id<b>Title</b> $title : <b>Url</b> $url : <a href='rss.php?d=$id'>[x]</a><br />";
$i++;

$d = $_GET['d'];
$delete = "DELETE FROM rssfeed WHERE rowID='$id"; 
		if ($d == $id){

		mysql_query($delete);
	}
}


?>

still have #2 as a prob.

donkru

you should put the query in a variable and the execute i only en you want to. make 2 files 1 pure html form and the link it to the php page then at the end of your code put a redirect to go where you want it to go try to split it up and that should help you out. good luck