looping help

richard181

can some one tell me how i can ge tthis to work fine.?
the problem is that there are more <tr> than i specify..

$rows=9; 
$col=1; 

$users=mysql_query("SELECT username FROM users"); 
while($user=mysql_fetch_array($users)){ 
for($r=1;$r <=$rows; $r++){ 
echo "<tr>"; 
} 
for($c=1;$c <=$col; $c++){ 
echo "<td>".$user['username']."</td>"; 
} 
} 
echo "</tr>";

laserlight

What exactly do you want to do?

richard181

laserlight wrote:
What exactly do you want to do?

i want to control the numbers of rows and cloums that my tables is going to display..

in addition i want to be able to display th variables inside the table cells from my database query..

richard181

so take a look at this exmapl here to see if it helps in any way..

check this example

richard181

this is what i was looking for with this i can control my table by just changing the num or the % number.. my problem still that i can't work a query into it.. becuase the <td> sends the same name over and over..

how i do that?


echo '<tr>';

$num=10;
      for($x=1; $x<=$num; $x++)
      {
        echo '<td>name</td>';
        if($x % 5 == 0)
        {
          echo '</tr>
          <tr>';
        }
      }

echo '</tr>';

laserlight

// columns to retrieve and print
$columns = array('ID', 'username');

// start the table and print column headings
echo "<table>\n<tr>\n";
foreach ($columns as $column) {
	echo '<th>' . $column . '</th>';
}
echo "\n</tr>\n";

// construct the query
$query = "SELECT " . implode(', ', $columns) . " FROM users";
// run the query
$result = mysql_query($query)
	OR die(mysql_error()); // for debugging

// print the rows
while ($row = mysql_fetch_assoc($result)) {
	echo "<tr>\n";
	// print the table cells
	foreach ($columns as $column) {
		echo '<td>' . $row[$column] . "</td>\n";
	}
	echo "\n</tr>\n";
}

// end the table
echo "</table>\n";

richard181

that code works great but is good for getting all the info of one user..so if i just want the username they going to show all in straight line.. so if i wanted more <td> i wont be able unless is another row of the user in the query..

so i tihnk by now you know what i'm looking for..

Blulagoon

This is the key to laserlight's code example:

// columns to retrieve and print 
$columns = array('ID', 'username');

You can change the $columns array to have as many columns as you need, and the info will be written one line per db entry. I haven't tried, but it should work OK with array('username') to give you a table with each username on a new row.

Blu

richard181

yes is aid it does work like that it gives me a username in ever new row, but i said what if i wanted username to be on another td too
this is what that codes prints out

+--------------+
| USERNAME1|
+--------------+
+--------------+
| USERNAME2|
+--------------+
+--------------+
| USERNAME3|
+--------------+

now my question is what is i wanted to do this

+--------------+ +--------------+
| USERNAME1| | USERNAME3|
+--------------++--------------+
+--------------+ +--------------+
| USERNAME2| | USERNAME4|
+--------------++--------------+

richard181

<?
if ($users = mysql_query("SELECT username FROM users LIMIT 9"))
{
 $user_count = 0;
 $len = mysql_num_rows($users);
 while($user_count < $len)
 {
  echo "<tr>\n"; 
  for ($i = 1; $i <= 5; $i++, $user_count++)
  {
   if ($user = mysql_fetch_array($users))
    echo "<td>". $user[0] ."</td>\n";
   else
    echo "<td />\n";
  }
  echo "</tr>\n\n";
 }
} 

?>

just in case any one ever cmes around with this problem this is the solution..

thankx to createvibe.com from from webmastter talk.. 😃

Blulagoon

Alternatively, if you want an output like:

Username 1 Username 2
Username 3 Username 4

You can use modulo to determine if it is an even or odd row and output:

<tr><td>$row['username']</td> // for the odd rows
<td>$row['username']</td></tr> // for the even rows

Blu

laserlight

that code works great but is good for getting all the info of one user..so if i just want the username they going to show all in straight line.. so if i wanted more <td> i wont be able unless is another row of the user in the query..

My example is optimised to solve the problem that you presented in your link.

just in case any one ever cmes around with this problem this is the solution..

I would suggest a modification:

if ($users = mysql_query("SELECT username FROM users LIMIT 9"))
{
	$len = mysql_num_rows($users);
	for ($user_count = 0; $user_count < $len; $user_count += 5)
	{
		echo "<tr>\n";
		for ($i = 0; $i < 5; ++$i)
		{
			if ($user = mysql_fetch_array($users))
				echo "<td>". $user[0] . "</td>\n";
			else
				echo "<td />\n";
		}
		echo "</tr>\n\n";
	}
}