Help Save My Job! (PHP/MySQL)

Abandc

Hello All,

I am new to this site but am really struggling with some reletively simple PHP code to read and write forms from a MySQL database.

The page consists of two frames - Sidebar.php and Scoot.php which are called from index.html. I simply want to be able to read fields from the MySQL database, display them in forms and write the edited forms to the database. The code does not work 🙁

I was hoping that one of you gurus might have a couple of minuites to cast a glance over my code and explain why it is not working.

As this is my first post to the forum please let me know if there is anything I have left out in my post.

Best wishes,

Adam

Code has now been correctly formatted and posted later in this thread.

I am offering an iPod to the one who provides me the solution to this, as the pressure is on.

laserlight

How does it not work? Provide the smallest and simplest script that demonstrates the problem, remembering to place it with [php] and [/php] forum bbcode tags, properly indented and commented.

pppppp

<body>
<table width="100%" border="0" align="center">
<tr>
<td align="center">Select your Test Case </td>
</tr>
<?
include("connection/config.php");

$sql="SELECT * FROM testcasemodules";

$query=mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($query) < 1){
$msg=urlencode("No Test Case found.");
}else{
while($results = mysql_fetch_array($query))
{
?>

<tr>
<td align="center"><a href="SCOOT2.php?id=<? echo $results["ID"];?>" target="main"><? echo $results["Name"];?></a></td>
</tr>

}

?></table>
</body>

<?

$id = $_GET[id];

include("connection/config.php");
if($edit=="true")
{
$sql="update testcaserecords set title ='".$title."',Owner='".$owner."',Engineer = '".$engineer."',Group_SubGroup='".$group."',MTR_IOT_Requirements='".$mtr_iot."',Prerequisites='".$prerequisites."',Description='".$description."',Expected_Result='".$results."',Current_AccessPoint_Configuration='".$accesspoint."' where TestCaseSubID = ".$testcaseNo;
mysql_query($sql) or die(mysql_error());
}
?>
<form name="form1" method="post" action="">
<table width="739" height="430" border="0" align="center">
<tr>
<td colspan="4"><div align="center"><strong>Test Case Management </strong></div></td>
</tr>
<tr>
<td width="233">Test Case </td>

<td colspan="3"><select name="testcaseNo" id="testcaseNo" onChange="document.form1.changeListner.value=true;document.form1.submit();">
<?
//include("connection/config.php");

$sql="SELECT * FROM testcasesubmodules where TestCaseID = ".$id;

$query=mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($query) < 1){
$msg=urlencode("No Test Case found.");
}else{
$check = 0;
while($results = mysql_fetch_array($query))
{
if($check==0 )
{
$testcaseid = $results["ID"];
$check = 1;
}
?>

}

}
if($changeListner == "" || $changeListner == "false" )//testcaseNo
{
if($edit == "true")
{ $sql="SELECT FROM testcaserecords where TestCaseSubID = ".$testcaseNo;}
else{
$sql="SELECT FROM testcaserecords where TestCaseSubID = ".$testcaseid;}
}
else
$sql="SELECT * FROM testcaserecords where TestCaseSubID = ".$testcaseNo;

$query=mysql_query($sql) or die(mysql_error());
$results = mysql_fetch_array($query);

</select>
<input name="changeListner" type="hidden" id="changeListner" value="false"></td>
</tr>
<tr>
<td>Title</td>
<td colspan="3"><input name="title" type="text" id="title" value="<? echo $results["Title"] ?>" maxlength="255"></td>
</tr>
<tr>
<td>Group/SubGroup</td>
<td colspan="3"><input name="group" type="text" id="group" value="<? echo $results["Group_SubGroup"] ?>" maxlength="255"></td>
</tr>
<tr>
<td>Owner</td>
<td colspan="3"><input name="owner" type="text" id="owner" value="<? echo $results["Owner"] ?>" maxlength="255"></td>
</tr>
<tr>
<td> Test Engineer</td>
<td colspan="3"><input name="engineer" type="text" id="engineer" value="<? echo $results["Engineer"] ?>" maxlength="255"></td>
</tr>
<tr>
<td height="72" align="left" valign="top"> MTR/IOT Requirements</td>
<td colspan="3" valign="top"><textarea name="mtr_iot" id="mtr_iot"><? echo $results["MTR_IOT_Requirements"] ?></textarea></td>
</tr>
<tr>
<td height="72" valign="top"> Test Description</td>
<td width="192" valign="top"><textarea name="description" id="description"><? echo $results["Description"] ?>
</textarea></td>
<td width="138" valign="top">Expected Results</td>
<td width="158" valign="top"><textarea name="results" id="textarea"><? echo $results["Expected_Result"] ?>
</textarea></td>
</tr>
<tr>
<td height="72" valign="top"> Prerequisites <br></td>
<td valign="top"><textarea name="prerequisites" id="prerequisites"><? echo $results["Prerequisites"] ?>
</textarea></td>
<td valign="top">Current AccessPoint Configuration </td>
<td valign="top"><textarea name="accesspoint" id="textarea2"><? echo $results["Current_AccessPoint_Configuration"] ?></textarea></td>
</tr>
<tr>
<td height="26" colspan="4"><div align="center">
<input name="Button" type="button" onClick="edit1()" value="Edit">
<input name="edit" type="hidden" id="edit" value="false">
</div></td>
</tr>
</table>
</form>
 </td>

pppppp

chek this it should work

Abandc

Thanks laser light. I will format as requested and update the post.

Abandc

pppp will do. And will let you now as soon as.

Abandc

PPPPP, Out of interest what have you changed and why? Just pushing it to server now.

pppppp

wat was ur problem in the code?

Abandc

It would only read the first record, and would not write to the DB.

pppppp

means ur update query is not working

Abandc

Did you make a change to this in the code that you posted?

pppppp

have u pasted the code...did it solve ur problem?

Abandc

I have pasted the code. Unfortunately it is the same problem.

Only the first record is displayed, and it is not possible to update the records.

Thanks for the help BTW, we solve this and an iPod is being DHLed your way 🙂

ahundiak

An ipod? Wow.

First of all verify that register_globals is on.

Then Add
print_r($GET); print_r($POST); die();

To the top of scoot.php and verify you are getting values when you hit submit.

You seem to be using both GET and POST variables on your submit i.e.
$id = $_GET[id];

That's unusual though it could work but I suspect that id is not being set when you post. Looks like you have some javascript stuff that going on.

Once you feel the correct information is being posted then echo out each $sql statement as you build it. The code is so messy that it's difficult to check for spelling errors just by looking at it.

Abandc

Many thanks. This is something I inherited - and is due tomorrow, The iPOD offer is genuine 🙂

I will follow you instructions and respond with the results.

I do have the code correctly formatted but am having trouble getting it to display correctly
indented on this site.

I will endeavour to get it up properly.... <blush>

Abandc

SCOOT2.PHP


<!--PHP code-->	  

<?
include("connection/config.php");
if($edit=="true")
{
	$sql="update testcaserecords set title ='".$title."',Owner='".$owner."',Engineer = '".$engineer."',Group_SubGroup='".$group."',MTR_IOT_Requirements='".$mtr_iot."',Prerequisites='".$prerequisites."',Description='".$description."',Expected_Result='".$results."',Current_AccessPoint_Configuration='".$accesspoint."' where TestCaseSubID = ".$testcaseNo;
	mysql_query($sql) or die(mysql_error());	
}
?>
<form name="form1" method="post" action="">
<table width="739" height="430" border="0" align="center">
    <tr>
      <td colspan="4"><div align="center"><strong>Test Case Management </strong></div></td>
      </tr>
    <tr>
      <td width="233">Test Case </td>

  <td colspan="3"><select name="testcaseNo" id="testcaseNo" onChange="document.form1.changeListner.value=true;document.form1.submit();">
<?
//include("connection/config.php");

$sql="SELECT * FROM testcasesubmodules where TestCaseID = ".$id;
$testcaseid = "";
$query=mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($query) < 1){
  $msg=urlencode("No Test Case found.");
}else{
	$check = 0;
      while($results = mysql_fetch_array($query))
	  {
	  	if($check==0 )
			{
				$testcaseid = $results["ID"];
				$check = 1;
			}
?>

  <option value="<? echo $results["ID"];?>" <? if($testcaseNo==$results["ID"]) echo "selected"; ?>><? echo $results["Name"];?></option>

<?		  

	  }

   }
if($changeListner == "" || $changeListner == "false" )//testcaseNo
{
	if($edit == "true")
	{	
		$sql="SELECT * FROM testcaserecords where TestCaseSubID = ".$testcaseNo;

}
else{
	$sql="SELECT * FROM testcaserecords where TestCaseSubID = ".$testcaseid;
}
}
else
	$sql="SELECT * FROM testcaserecords where TestCaseSubID = ".$testcaseNo;
if($testcaseid!="")
{
$query=mysql_query($sql) or die(mysql_error());
$results = mysql_fetch_array($query);
}

?>

  </select>
  <input name="changeListner" type="hidden" id="changeListner" value="false"></td>
</tr>
<tr>
  <td>Title</td>
  <td colspan="3"><input name="title" type="text" id="title" value="<? echo $results["Title"] ?>" maxlength="255"></td>
</tr>
<tr>
  <td>Group/SubGroup</td>
  <td colspan="3"><input name="group" type="text" id="group" value="<? echo $results["Group_SubGroup"] ?>" maxlength="255"></td>
</tr>
<tr>
  <td>Owner</td>
  <td colspan="3"><input name="owner" type="text" id="owner" value="<? echo $results["Owner"] ?>" maxlength="255"></td>
</tr>
<tr>
  <td> Test Engineer</td>
  <td colspan="3"><input name="engineer" type="text" id="engineer" value="<? echo $results["Engineer"] ?>" maxlength="255"></td>
</tr>
<tr>
  <td height="72" align="left" valign="top"> MTR/IOT Requirements</td>
  <td colspan="3" valign="top"><textarea name="mtr_iot" id="mtr_iot"><? echo $results["MTR_IOT_Requirements"] ?></textarea></td>
</tr>
<tr>
  <td height="72" valign="top"> Test Description</td>
  <td width="192" valign="top"><textarea name="description" id="description"><? echo $results["Description"] ?>
</textarea></td>
      <td width="138" valign="top">Expected Results</td>
      <td width="158" valign="top"><textarea name="results" id="textarea"><? echo $results["Expected_Result"] ?>
</textarea></td>
    </tr>
    <tr>
      <td height="72" valign="top"> Prerequisites <br></td>
      <td valign="top"><textarea name="prerequisites" id="prerequisites"><? echo $results["Prerequisites"] ?>
</textarea></td>
      <td valign="top">Current AccessPoint Configuration </td>
      <td valign="top"><textarea name="accesspoint" id="textarea2"><? echo $results["Current_AccessPoint_Configuration"] ?></textarea></td>
    </tr>
    <tr>
      <td height="26" colspan="4"><div align="center">
        <input name="Button" type="button" onClick="edit1()" value="Edit">
        <input name="edit" type="hidden" id="edit" value="false">
      </div></td>
    </tr>
  </table>	 
  </form> 
<!-- PHP code end-->

Abandc

SideBar.php


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Main Page</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<table width="100%" border="0" align="center">
<tr>
	<td align="center">Select your Test Case </td>
</tr>
<?
include("connection/config.php");

$sql="SELECT * FROM testcasemodules";

$query=mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($query) < 1){
$msg=urlencode("No Test Case found.");
}else{
while($results = mysql_fetch_array($query))
{
?>

<tr>
<td align="center"><a href="SCOOT2.php?id=<? echo $results["ID"];?>" target="main"><? echo $results["Name"];?></a></td>
</tr>

<?

}

}


?></table>
</body>
</table>
</body>
</html>

Abandc

Well I guess that is the code formatted.

All this code is supposed to do is to enable forms to be written and read from a MySQL database.

As previously offered anyone who can help me solve this get's an iPod DHLd to them as a thankyou.

Best wishes,

Adam

Abandc

ahundiak,

thanks for the help. I can confirm that register_globals is on and that when I hit submit I am getting the correct values.

best wishes,

Adam

ahundiak

Abandc wrote:
ahundiak,

thanks for the help. I can confirm that register_globals is on and that when I hit submit I am getting the correct values.

best wishes,

Adam

Ok. Let's work on one problem at a time. You said the update was not working.

You have an if ($edit == 'true') block which then attempts to update the database.

Put a die($sql); in there to confirm the code is running (i.e. your javascript is setting $edit to true) and that the rest of the statement looks reasonable especially the
"where testcasesubid = " portion.

If it looks right then fire up mysql (or phpmyadmin or whatever) and try running the update manually by pasting in the sql. And again, check from mysql to see if the database is being updated.