can't pass an argument to a JS window.open function from php

[SpockBert]

Hi, trying to do something really simple, launch a popup window.

This hardcoded version works fine:

<SCRIPT language="JavaScript">

function newWindow(){
	window.open('index.php','myWindow','width=300,height=200,resizable=yes');
}

</SCRIPT>


<?php

echo "<a href='javascript:newWindow()' >Launch PopUp</a>";

?>

But thats not much good to me, what i really need is something like:

<SCRIPT language="JavaScript">

function newWindow(url){
	window.open(url,'myWindow','width=300,height=200,resizable=yes');
}

</SCRIPT>

<?php

$myUrl = 'index.php';

echo "<a href='javascript:newWindow($myUrl)' >Launch PopUp</a>";

?>

But cannot get it working, i've tried "onClick" variations too, probably something really simple I've got wrong, any ideas?

[ClarkF1]

This should work:

echo "<a href=\"javascript:newWindow('".$myUrl."')\" >Launch PopUp</a>";

[SpockBert]

ClarkF1 wrote:

This should work:

echo "<a href=\"javascript:newWindow('".$myUrl."')\" >Launch PopUp</a>";

yeah works great, cheers mate!

surprised though, i was expecting it to generate an error message, I thought once you had a

echo " whatever ";

with double speechmarks you couldn't put another pair of " " inside?

I'm not sure I understand the significance of the \" . etc but it works thats the main thing!

thanks again.

[ClarkF1]

The \ escapes the double quote so it actually prints in the source code rather than think it's an end of string double quote, allowing you to put in double quotes within double quotes. You can do the same for single quotes too.

For some reason you have to parse variables in javascript functions within single quotes.