[RESOLVED] Frustrating parse errors

[genista]

Hi all!

I have created a join form and an include file, I am getting the following error:

Parse error: parse error, unexpected T_STRING in /home/fhlinux218/h/mysite.co.uk/user/Includes/testinclude.php on line 40

I have pasted below the include file with the line mentioned above in bold:

function insert_data($formdata)
{
//insert data into the users table
//$formdata = form array

set up database connection
$error = "";
$myhost = "mysite";
$myuser = "username";
$mypass = "password";
$mydb = "databasename";

}

//connect to the database
//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!Mysql)
{
$error = "Cannot connect to the database";
return($error);

//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)
$error = "Cannot open Database";
return($error);
}

?>

You will now find below a paste of the join form that calls this function above:

function insert_data($formdata)
{
//insert data into the users table
//$formdata = form array

//set up database connection
$error = "";
$myhost = "mysite";
$myuser = "username";
$mypass = "password";
$mydb = "databasename";

//data to insert

$first_name = $formdata ['first_name'];
$last_name = $formdata ['last_name'];
$maiden_name = $formdata['maiden_name'];
$address_line1 = $formdata ['address_line1'];
$address_line2 = $formdata['address_line2'];
$town = $formdata['town'];
$county = $formdata['county'];
$postcode = $formdata['postcode'];
$daytime_phone = $formdata['daytime_phone'];
$username = $formdata['username'];
$password = $formdata['password'];
$info = $formdata['info'];
}
//encrypt the password
//$password =crypt ($password, "DWMXPHP");
//117
//connect to the database
//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!Mysql)
{
$error = "Cannot connect to the database";
return($error);
}
{
//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)
{
$error = "Cannot open Database";
return($error);
}

//Insert Data
$myquery = "INSERT INTO users ( first_name, last_name, maiden_name, address_line1, address_line2, town, county, postcode, daytime_phone, evening_phone, email_address, date_ofbirth, username, password, info, ";
$myquery .= "status) VALUES ('$firstname', $lastname', $username', ";
$myquery .= "'$password', '$status')";
$result = mysql_query($myquery, $mysql);
if (!$result)
{
$error = "Cannot run query";
return $error;
}

//Return true if record written successfully
return("true");
}
?>

Any help would be greatly appreciated.

Thanks,

G

[whisher06]

Hi.
I mean the error 😃

if(!Mysql)
It should be
if(!$Mysql)

Bye

[vertmonkee]

Is that everyhthing from the included file, as the if the line in bold is actually line 40 i guess there is other code above, and the error may be from a line earlier in the code

[genista]

Thanks Whisher for that, although it hasn't solved my problem..
Here is the entire include file for you Vert:

<?php

function trimdata ($formdata)
{
//Trim any leading or trailing spaces
//$formdata=form data array
foreach ($formdata as $key=> $value)
{
$new_array[$key] = trim($value);
}
return $new_array;
}

function check_password_length($formdata, $password, $minlen)
{
//check the password is the correct length
//$formdata = form data array
//$password = name of password field
//$minlen = minimum length of password field
if (strlen($formdata[$password]) <$minlen)
return false;
else
return true;
}

function check_unique ($formvalue, $mydb, $myhost, $myuser, $mypass, $table, $field)
{
//Check to see if the value still exists in the database
//$formvalue = unique value to be checked

$error = "";
}

function insert_data($formdata)
{
//insert data into the users table
//$formdata = form array

set up database connection
$error = "";
$myhost = "mysite";
$myuser = "username";
$mypass = "password";
$mydb = "database";

}
//encrypt the password
//$password =crypt ($password, "DWMXPHP");

//connect to the database
//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!$Mysql)
{
$error = "Cannot connect to the database";
return($error);

//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)
$error = "Cannot open Database";
return($error);

}

?>

[pppppp]

comment the line "set up database connection" and should work

[vertmonkee]

You haven't got comment marks in front of the line that says set up database connections

does that work?

[pppppp]

comment the line "set up database connection" and should work

[madwormer2]

Comment the line... oh wait, three people already said it.

[Houdini]

Change

set up database connection
$error = "";

to

//set up database connection (this must be commented)
$error = "";

and change

$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!Mysql)

to

$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!$mysql)//must be same case and was missing the $ sign (it is not Javascript)

[genista]

Great thanks guys, my mistake!

Now I have a new problem in that the join form loads with no errors and no form to fill in just ablank page...

Any ideas?

[Houdini]

I do not see your form code, do you have it handy if so post it and please enclose it with either [ html ] and [ /html ] or [ php ] and [ /php ] (without the spaces) as it makes it easier to read and will add scrollbars on extremely long code, plus with highlighting might reveal errors in syntax merely by posting this way.

[genista]

Ok heres the join form in all its glory. I have tested my database connection so I know that works ok:

<?php include("/home/fhlinux218/h/mysite.co.uk/user/Includes/testinclude.php"); ?>

<?php

function insert_data($formdata)
{
//insert data into the users table
//$formdata = form array

//set up database connection
$error = "";
$myhost = "hostname";
$myuser = "username";
$mypass = "password";
$mydb = "dbname";

//data to insert

$first_name = $formdata ['first_name']; 
$last_name = $formdata ['last_name']; 
$maiden_name = $formdata['maiden_name']; 
$address_line1 = $formdata ['address_line1']; 
$address_line2 = $formdata['address_line2'];
$town = $formdata['town']; 
$county = $formdata['county']; 
$postcode = $formdata['postcode'];
$daytime_phone = $formdata['daytime_phone'];
$evening_phone = $formdata['evening_phone']; 
$email_address = $formdata['email_address'];
$date_ofbirth = $formdata['date_ofbirth']; 
$username = $formdata['username']; 
$password = $formdata['password'];
$info = $formdata['info'];
}
//encrypt the password
//$password =crypt ($password, "DWMXPHP"); 
//117
//connect to the database
//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!Mysql)
{
$error = "Cannot connect to the database";
return($error);
}
{
//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)
{
$error = "Cannot open Database";
return($error);
}

//Insert Data
$myquery = "INSERT INTO users ( first_name, last_name, maiden_name, address_line1, address_line2, town, county, postcode, daytime_phone, evening_phone, email_address, date_ofbirth, username, password, info, ";
$myquery .= "status) VALUES ('$firstname', $lastname', $username', ";
$myquery .= "'$password', '$status')";
$result = mysql_query($myquery, $mysql);
if (!$result)
{
$error = "Cannot run query";
return $error;
}

//Return true if record written successfully
return("true");
}
?>

<html

<form id="form1" name="userform" method="post" action="<?php echo ($php_self) ?>">
  <label>First Name</label>
   <input name="first_name" type="text" id="first_name" maxlength="25" />
</form>

[code=html]

[vertmonkee]

I dont think you have changed this line

//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)

Houdini suggested the changes

[genista]

The above line I pasted does include it, or am I missing something?:

//Open the database
$mysqldb = mysql_select_db($mydb);
if (!$mysqldb)
{

[vertmonkee]

Yeah sorry my fault i copied and pasted the wrong bit.

I meant to paste this

//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!Mysql)

[pppppp]

there is brackets problem in ur code.. just chek it again

[genista]

Ok, I have changed it like so:

//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!$Mysql)
[code=html]

But no change I'm afraid

[pppppp]

just chek the brakets

[vertmonkee]

Check the case senseitvity
in the first instance you set it to $mysql, then you were checking for $Mysql.

You need to change the capital M for a lower case m.
Like so

//connect to the server
$mysql = mysql_connect($myhost, $myuser, $mypass);
if(!$mysql)

[genista]

Should I change:

{
$error = "Cannot run query";
return $error;
}

//Return true if record written successfully
return("true");
}
[code=html]

to

[code=html]

{
$error = "Cannot run query";
return $error;
[B]else[/B]
//Return true if record written successfully
return("true");
}

[code=html]