question about switch statement in 4.4.2

bbmak

My switch statement used to work fine in the old php version, but after using 4.4.2, the switch statement and the if ($action == '') all become

Notice: Undefined variable: action in /www/b/btzonecom/htdocs/lyric/a-z.php on line 14

and what happen to the syntax of this query?

it used to work in old version

$query = "SELECT * FROM artist WHERE LEFT(english_name, 1) = '".$_GET['letter']."' AND ".$query_region." ORDER BY english_name ASC";
$result=mysql_query($query) or die(mysql_error());

thorpe

register_globals have long been off by default. If $action is being sent via a form (post), you will need to use the $_POST array... same applies to get.

and what happen to the syntax of this query?

How would we know? what is the problem?

bbmak

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY english_name ASC' at line 1

thorpe

What does...

echo $query;

produce?

Houdini

".$query_region."

hmmm

"'.$query_region.'"

bbmak

thank you so much, after i turn the register_global to on, everything back to normal. I know it will be a security issue for me; however, are there anything to prevent people from attacking my script from registe_global on?

thorpe

Its recommended to fix your code. Most hosts will not have register_globals on so your code will break if moved.

bbmak

yes i know. Do u have any references that i can look at to shift my code from register_global on to off by using source code? Like when i use if ($action == '') and switch()

I want to make my code safer