rss... everything

ashley98860615

Im really new to RSS and i found this code (I've modified it a bit) from searching these forums:

<?php header("content-type:text/xml");
//Edited from phpbuilder.com
$xmlOutput.="<?xml version='1.0' encoding='windows-1255'?>";
$xmlOutput.="<rss version='0.91'>";
$xmlOutput.="<channel>";
include ("./library/config.php");
$xmlOutput.="<title>$sitename</title>";
$xmlOutput.="<description>$sitename ($siteaddress) latest news articles</description>";
$xmlOutput.="<language>en-us</language>";
$xmlOutput.="<copyright>Copyright: (C) $sitename</copyright>";
    //create sql statement            

$sql = "SELECT * FROM news ORDER BY id DESC LIMIT 5";
                //execute sql query and get results     

        $sql_result = mysql_query($sql) or die("Unsuccessful Query.");
  //format results by row
        $count = 0;
        while ($row = mysql_fetch_array($sql_result)) {
          $STRimageID = $row["id"];         

          $STRtitle = $row["title"];
          $STRdescription = $row["content"];
          $STRdescription = str_replace( chr(13), "<br>", $STRdescription);
          $STRdate = $row["date"];

$xmlOutput.="<item>";
$xmlOutput.="<title>".$STRtitle."</title>";
$xmlOutput.="<description>".$STRdescription."</description>";
$xmlOutput.="<link><![CDATA[[url]".$siteaddress."pages.php?page=news&id=".$STRimageID."[/url]]]></link>";
$xmlOutput.="</item>";
  }
$xmlOutput.="</channel>";
$xmlOutput.="</rss>";
echo $xmlOutput;
?>

i can't figure out why it doesn't validate (im using http://feedvalidator.org/). and also how do i go about implementing this code into my website... stuck once i have the code working basically!

anakadote

Can you supply a URL to the feed, that way I can see what the errors are?

Also, you may want to try encoding it with UTF-8 instead of Windows.

ashley98860615

if you go to feedvalidator.org and then type in the box http://www.treble.lfhost.com/1024/rss.php it will show the errors. the news articles come from http://www.treble.lfhost.com/1024/pages.php?page=news

thanks

Weedpacket

At a brief glance, the error message "link must be a full and valid URL" would appear to imply that

<![CDATA[&#91;url]http://treble.lfhost.com/1024/pages.php?page=news&id=29[/url]]]>

is not a full and valid URL; perhaps it ought to be

<![CDATA[http://treble.lfhost.com/1024/pages.php?page=news&id=29]]>

or even just

http://treble.lfhost.com/1024/pages.php?page=news&id=29

(seeing as how it's not going to contain any embedded tags.)

In fact

The page linked to by the bit that says help next to the error:
If this is a link to a web page, make sure to include the "http://" at the beginning......The data in link elements must begin win an IANA-registered URI scheme

And yours doesn't. It begins with [url].

The second error message would appear to be saying that the <channel> element needs a <link> element of its own (this error message also has a help page associated with it that explains what it should link to).