[RESOLVED] Rename an image file during upload

[DirtDemon]

I have a working image upload script and want to somehow rename the file the user uploads to prevent duplicates file uploads. I am not sure the best practice to do this, completely rename the file versus ass some random text to the end of it.

Also my script adds the filename to a database so I can reference it later, so whatever the new filename is I need to update my DB with it. Here is my current code.

Can someone help me out please?

<?php 
		$uploaddir = '/homepages/12/d114244980/htdocs/MaximumDirt/images/drivers/';
		$uploadfile = $uploaddir . basename($_FILES['userfile']['name']);
		$picname = $_FILES['userfile']['name'];
		$pic2 = $_FILES['userfile']['tmp_name'];

	$size = filesize($pic2);

	if ($size > 100000) //100K
		die ('<script> alert("File too big!"); </script>');

	move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile);

	$sql_update = mysql_query ("UPDATE driver_profiles SET pic1='".($picname)."'");
	?>

[DirtDemon]

I found how I can add a random number to the beginning or end...

$random=rand(0000,9999);
$newname=$random.$filename;

If I did something like that to my file how would I modify the upload portion fo the script to proceed with the upload only using the new filename?

This part of the code I do not know how to work with...

move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile); 

[bpat1434]

[man]move_uploaded_file[/man]( filename, destination );

If the file is valid, it will be moved to the filename given by destination.

So just use $newname instead of $uploadfile....

[Weedpacket]

One method I've seen some blogging software use is to rename the file with the MD5 or SHA1 hash of the file. That's pretty much guaranteed to be unique for every file (unless two files are bit-for-bit identical, or someone is deliberatly setting out to cause a collision).

 move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile); 

So instead of $uploadfile you'd use $newname. Assuming that $newname is the name you constructed the new file name in.

[DirtDemon]

Well, here are the changes to my code...

<?php 
		$uploaddir = '/homepages/12/d114244980/htdocs/MaximumDirt/images/drivers/';
		$uploadfile = $uploaddir . basename($_FILES['userfile']['name']);

	$picname = $_FILES['userfile']['name'];
	$random=rand(1000,9999); 
	$newpicname=$random.$picname;

	move_uploaded_file($_FILES['userfile']['tmp_name'], $newpicname);

	$sql_update = mysql_query ("UPDATE driver_profiles SET pic1='".($newpicname)."'");
	?>

It does add the random number in front and $newpicname gets updated in the database, but now the file does not get uploaded. Any thoughts?

EDIT: I just found the uploaded file in the root directory where the php file is, not the upload dir I set. This changed as it was placing it in the directory, so it looks like something with the path is not working.

GOT IT!

<?php 
		$uploaddir = '/homepages/12/d114244980/htdocs/MaximumDirt/images/drivers/';

	$picname = $_FILES['userfile']['name'];
	$random=rand(1000,9999); 
	$newpicname=$random.$picname;
	$uploadfile = $uploaddir.$newpicname;

	move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile);

	$sql_update = mysql_query ("UPDATE driver_profiles SET pic1='".($newpicname)."'");
	?>

[bpat1434]

$random=rand(1000,9999);
        $newpicname=$random.$picname;
        $uploadfile = $uploaddir.$newpicname; 

That can really be reduced to:

$uploadfile = $uploaddir . rand(1000,9999) . $picname;

Just for shorter code.... and less chance of accidentaly overwriting an old variable 😉