Pop up window not displaying.

ramu_rp2005

Hi all,
I'm using a function to verify a value which is hexadecimal or not.When i click a button, this function gets executed which i've added in the <head> tag.
The function is ,

<script language="JavaScript">
function popup()
{

window.open('http://10.132.16.82/verify.php','popup','width=400,height=400,scrollbars=yes,resizable=no,toolbar=no,directories=no,
location=no,menubar=no,status=no,left=500,top=400'); 
return false;

}
</script>
<?php
function verify()
{
  if(isset($pvideopid))
  { 	
  if(preg_match('/[^0-9a-f]/i',$videopid))
	{
	   	popup();
		return false;
	}  

  }
}

?>
</HEAD>

This verify() should popup a javascript window which inturn leads to a form which is to display OK button and few lines(not code) thats all.When i click Ok it should return this form itself. Is my code correct?

Kudose

ramu_rp2005 wrote:
Is my code correct?

Have you tried it?

Kudose

Scratch that last post.

Here's my answer: No.

Give me a second to look it over for a fix.

ramu_rp2005

YES, i've tried it. When i click the run button no popups display the same form is displayed with the entered videopid value gone.

Kudose

I am not a JS master, so the JS looks correct.

The PHP however, is not.

<?php
function verify()
{
  //this will not work -> variable is not set in the functions scope.
  if(isset($pvideopid))
  { 	
  //this will not work -> bad REGEX and $videopid does not exist
  //in the functions scope - plus I think you meant $pvideopid or vice versa
  if(preg_match('/[^0-9a-f]/i',$videopid))
	{
                //this will not work -> will look for PHP function called popup
	   	popup();
		return false;
	}  

  }
}

?>

This should work -- although it is not the proper way

<?php
function verify()
{
  // get the variable(s) from the global scope
  global $pvideopid;
  global $videopid;
  if(isset($pvideopid))
  { 	
  //regex needs verify beginning and end using ^ and $ respectively
  if(preg_match('/^[0-9a-f]$/i',$videopid))
	{
                //output the JS to the browser
	   	echo '<script language="text/JavaScript">popup();</script>';
		return false;
	}  

  }
}

?>

One last thing -- usually isnt good practice to pull variables from other scopes. It is best to pass them by value or by reference into the function/method needed.

i.e.

function verify($videopid){
return $videopid;
}

Instead of:

function verify(){
global $videopid;
return $videopid;
}