[RESOLVED] Delete Files problem

[cbrknight]

I have files that are being created in my code on our server. I was using a link to give the option to delete which would set the case variable to delete through $_post.....

I recently changed the code to use session variables. for the switch... so now the code I used to delete the files...

echo"<br><a href=$dir".$file2.">$file</a> | Date: $d | <a href=export.php?company=delete&f=$dir".$file2.">Delete</a>";

when it was clicked then it would run this script

case "delete":
	unlink($_REQUEST['f']);
	$_SESSION['company'] = "success";
	header("Location: export.php");	
break;

doesnt change the session variable to delete so I cant get the delete to work...

how do I change the session variable in the link so my existing code will work.

I also saw some code that would unlink the file using a function call.. Same problem though.. how do I call the function from a link?

ONE other thing...

While looking for answers I saw that if people disabled cookies it also disabled sessions... Should I just go back to passing variables through $_Post?

Thanks

[bradgrafelman]

It's probably not updating the session data properly before the header.

Just before the header() (and after you're done with all session variables), add [man]session_write_close/man.

[cbrknight]

I dont believe that is the problem...

The session variable was set on a different page. I just dont know how to reset the variable value from a link...

Here is the actual function I am using....

function output(){
$dir = "converted/";
//Open a known directory, and proceed to read its contents
if(is_dir($dir)){
if($dh=opendir($dir)){
while(($file=readdir($dh))!==false{
if($file!= '..' && !is_dir($dir.$file)){
$file2=str_replace(" ", "%20",$file);
$arr=explode("_",$file);
$tm=$arr[0];
$arr=explode(".",$tm);
$tm=$arr[0];
$tm=date("h.i.s.A");
$d=date("m-j-Y");
$counter=count($file2);
echo"<br><a href=$dir".$file2.">$file</a> | Date: $d <a href=export.php?company=delete&f=$dir".$file2.">Delete</a>";
}
}
closedir($dh)
}
}
} 

When they click on the DELETE link I need to set $_SESSION['company]="delete"

[bogu]

Can u explain this?

cbrknight wrote:

I just dont know how to reset the variable value from a link...

U need to check for $file!= '.' too
$file2=str_replace(" ", "%20",$file); <-- u can use urlencode() ...
$counter=count($file2); <--$file2 is an array?

What are this lines good for?

1: $arr=explode("_",$file); 
2: $tm=$arr[0]; 
3: $arr=explode(".",$tm); 
4: $tm=$arr[0]; 
5: $tm=date("h.i.s.A"); 

Did u use session_start();?

[cbrknight]

not real sure how to use urlencode....
hadn't looked into it because that part of the function is working properly. it Is just the part of the link that people click on... what that code does is this

Example:...

Click on a file to download

modpay_05-26-2006_03.27.21.PM.txt | Date: 05-29-2006 | Delete

all I need is to be able to change the session variable COMPANY and set it to the value 'delete' so that the

case "delete":
unlink $file;
break;

will be called....

I didnt use session start because this was in an include that is called after session_start() in the actual file....

[bogu]

So,
Can u explain this?

cbrknight wrote:

I just dont know how to reset the variable value from a link...

u are trying to change space to %20 that's urlencode if u try to acces your file through your browser the file name is encode with urlencode() I dont know why do u use that, but anyway ...

[cbrknight]

So,
Can u explain this?
Quote:
Originally Posted by cbrknight
I just dont know how to reset the variable value from a link...

u are trying to change space to %20 that's urlencode if u try to acces your file through your browser the file name is encode with urlencode() I dont know why do u use that, but anyway ...

I guess I am totally confused now...

that code for %20 is just looking for any spaces in the url and converting it to %20.... what does that have to do with changing session variables?

There may be a better way to error check spaces in urls but I am still learning everyday how to do things in php....

[bogu]

Did u try

print_r($_SESSION);

to see what is the value of the session array?

to set a session u need to:

session_start();

and after that u can set sessions

$_SESSION['name'] = 'value';

In your script:

before this switch

case "delete": 
    unlink($_REQUEST['f']); 
    $_SESSION['company'] = "success"; 
    header("Location: export.php");     

break; 

u need to have

session_start();

[cbrknight]

Here is the code I have for export.php

session_start();
require("includes/database.php");
require("includes/includes.php");
mysql_select_db($database_converter, $dbConn);
//$_SESSION['company']=$_REQUEST['company'];
$company = $_SESSION['company'];
switch($company){

case "delete":
	unlink($_REQUEST['f']);
	$_SESSION['company'] = "success";
	header("Location: export.php");	
break;

case"newImport":
	$sql = "TRUNCATE TABLE nacs_file"; 
	$r = mysql_query($sql, $dbConn)or die("Error: " .mysql_error()); 
	$sql2 = "TRUNCATE TABLE modpay"; 
	$r2 = mysql_query($sql2, $dbConn)or die("Error: " .mysql_error()); 
	session_destroy();
	header("Location: index.php");
break;

case "success":

echo('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>ModPay Files</title>
<link href="converter.css" rel="stylesheet" type="text/css" />
</head>

<body>
<div id="container">
<div id="mainContent">
<h1>MODPAY Files Successfully Converted</h1>
<h2>Click on a file to download</h2><p>');
output();
echo('</p>
</div>
</div>
</body>
</html>
');

break;

default:
echo"Something failed try again";
echo $company;

}

Here is includes.php

function output(){
$dir = "converted/";
//Open a Known Directory, and proceed to read its contents
if(is_dir($dir)){
	if($dh = opendir($dir)){
		while(($file=readdir($dh)) !==false){
			if($file != '..' && !is_dir($dir.$file)){
				$file2=str_replace(" ", "%20",$file);
				$arr=explode("_",$file);
				$tm=$arr[0];
				$arr=explode(".",$tm);
				$tm=$arr[0];
				$tm=date("h.i.s.A");
				$d=date("m-j-Y");
				$counter = count($file2);
				session_write_close();
				echo"<br><a href=$dir".$file2.">$file</a> | Date: $d | <a href=export.php?company=delete&f=$dir".$file2.">Delete</a>";

		}
	}
	closedir($dh);
}
}

Do I need session_start() on the includes file as well as the page that is calling the include?

[Weedpacket]

cbrknight wrote:

Do I need session_start() on the includes file as well as the page that is calling the include?

No, because the session would have already been started before the included code is run (and in fact you'd trigger a Notice-level message if you tried).

[man]session_start[/man]
Note: As of PHP 4.3.3, calling session_start() while the session has already been started will result in an error of level E_NOTICE. Also, the second session start will simply be ignored.

What I want to know is: why is the only line that actually sets the value of $SESSION['company']:

//$_SESSION['company']=$_REQUEST['company']; 

commented out? (The other one doesn't count, because it is only run when the value of $_SESSION['company']=='delete' - which it never is.)

Your code looks confused: are you trying to base the decision about which branch to take in the switch statment on a value stored in $SESSION or a value in $REQUEST?

[cbrknight]

Weedpacket wrote:

No, because the session would have already been started before the included code is run (and in fact you'd trigger a Notice-level message if you tried).

What I want to know is: why is the only line that actually sets the value of $SESSION['company']:

//$_SESSION['company']=$_REQUEST['company']; 

commented out? (The other one doesn't count, because it is only run when the value of $_SESSION['company']=='delete' - which it never is.)

Your code looks confused: are you trying to base the decision about which branch to take in the switch statment on a value stored in $SESSION or a value in $REQUEST?

The session variable is actually set on another page. That is why I originally decided to use sessions. Most of the actions in my script are made dependent on that choice. however... when you get to this last page... I wanted to be able to list all the files that had been created and give the user a choice to delete it. The only way I knew to do that was in a hyper link but for some reason I cant change the session value from the hyper link.

I was trying to see if $_Request would grab the variable sent from a hyperlink... which it does... So what I am trying to do now is us an if statement....

if ($_REQUEST['company']=="delete"){
$_SESSION['company']=$_REQUEST['company'];
}

That way if I am sending a delete request than the session variable will be changed to delete and run the code to delete the file. If it is anything else it will leave the session variable alone and let the other logic run depeding on what choices were made on other pages.

It is kind of ugly code but I just cant think of another way to do what I need to do...

[bogu]

Did u try?

if ($_GET['company']=="delete"){ 
    $_SESSION['company']="delete"; 
} 

[cbrknight]

bogu wrote:

Did u try?

if ($_GET['company']=="delete"){ 
    $_SESSION['company']="delete"; 
} 

I just tried it and it works too...

what is the difference between using

$GET vs. $REQUEST ???