[RESOLVED] display online users

scrypte

I'm trying to do something like this:

ONLINE USERS

xbase, bitty, jex, jeff

I want the last name to not have a , after it, but i'm having issues with my coding:

<b>ONLINE USERS - </b><br>
---------------------------------<br>
<?
	$sql = "SELECT * FROM online_users";
    $result = mysql_query($sql);

$numofonlinerows = mysql_num_rows($result);
for($online_total = 0; $online_total < $numofonlinerows; $online_total++) {
$row = mysql_fetch_array($result); //get a row from our result set
       $online_userid = $row['userid'];

           $sql2 = "SELECT * FROM users WHERE userid = $online_userid";
           $query2= mysql_query($sql2);
           $arr2 = mysql_Fetch_Array($query2);
                  $online_username = $arr2['username'];


			if(($online_total % '*')=='*') { //this means if there is a remainder
				echo "$online_username";
			} else { //if there isn't a remainder we will do the else    	
				echo "$online_username, ";
        }

    }
?>

If anyone can help me out, I would greatly appreciate it.

autocolismo

<b>ONLINE USERS - </b><br> 
---------------------------------<br> 
<? 
    $sql = "SELECT * FROM online_users"; 
    $result = mysql_query($sql); 

$numofonlinerows = mysql_num_rows($result); 
for($online_total = 0; $online_total < $numofonlinerows; $online_total++) { 
$row = mysql_fetch_array($result); //get a row from our result set 
       $online_userid = $row['userid']; 

           $sql2 = "SELECT * FROM users WHERE userid = $online_userid"; 
           $query2= mysql_query($sql2); 
           $arr2 = mysql_Fetch_Array($query2); 
                  $online_username = $arr2['username']; 


            if(($online_total % '*')=='*') { //this means if there is a remainder 
                echo "$online_username"; 
            } else { //if there isn't a remainder we will do the else         
                echo "$online_username "; 
        } 

    } 
?>

Installer

Try something like this:

$sql = "SELECT * FROM online_users"; 
$result = mysql_query($sql); 
$str = '';
while ($row = mysql_fetch_array($result)) { 
    $sql2 = "SELECT * FROM users WHERE userid = " . $row['userid']; 
    $query2 = mysql_query($sql2); 
    $arr2 = mysql_fetch_array($query2); 
    $str .= $arr2['username'] . ', ';
} 
echo trim($str, ', ');

scrypte

thank you, worked like a charm

final results: www.syc0tests.com

bradgrafelman

Couple of MySQL nitpicks:

You're doing a SELECT * and then only using 1 column in BOTH queries.
You're using two queries when only one is needed.

$sql = 'SELECT `users`.`username` FROM `users_online`, `users` WHERE `users_online`.`userid` = `users`.`userid`';
$result = mysql_query($sql);
$str = '';
while($row = mysql_fetch_assoc($result))
     $str .= $row['username'] . ', ';

echo rtrim($str, ', ');

bradgrafelman

http://www.syc0tests.com/index.php?op=members
http://www.syc0tests.com/index.php?op=viewprofile&id=35

EDIT: I've only done some harmless stuff, inserting images and whatnot, but you might want to protect yourself against people who won't be so kind 😉