[RESOLVED] Wrong output (redirection problem)

2005

I have strange problem with the code below. It works correct, but the output in ~50% is "This thread doesn't exist or it's already locked". I mean - the script successfully sets "locked" to "1", but outputs error instead of success message. When I remove "refresh" everything works fine. Any idea? Thanks.


switch($op) {


default:
........................

break;

case "lockthread":

.......
$result = mysql_query("SELECT uid FROM forum WHERE id = '$tid' and locked ='0'");

$count=mysql_num_rows($result);
if($count == '1') {

mysql_query("UPDATE forums SET locked='1' WHERE id='$tid'");

?>
This thread has been locked
<meta http-equiv="refresh" content="1; url=forum.php">
<?php

} else {

echo "This thread doesn't exist or it's already locked";
die;

}


break;

}

2005

P.S. It looks that after query script redirects to the same case "lockthread" that's why it outrouts error message. But I don't understand why it doesn't redirect to "default" and why in some 50% of all cases gives correct output and in other 50% - incorrect.

laserlight

Could you provide the smallest and simplest script that demonstrates the error?

2005

Laserlight, thank you for your answer. My provided script demonstrates the error. For example, I click on "Lock thread" and access URL:

http://www.mydomain.com/forum.php?op=lockthread&tid=27

The script locks this thread, but instead of refreshing to:

http://www.mydomain.com/forum.php

refreshes again to:

http://www.mydomain.com/forum.php?op=lockthread&tid=27

Of course, the thread is already locked and the script outputs error. When I remove the line meta http-equiv="refresh" everything works fine.

2005

Something mystic... This script works correct and selected article always is deleted. What I can not understand why in 50% of cases after deleting article it displays "Article not found" instead of "Article deleted". It looks that the script after deleting article somehow refreshes not to
articles.php?do=edit
but refreshes the same function:
article.php?do=deletearticle&id=$id
The article already is deleted and it displays "Article not found". I can not understand how it's possible...

case "deletearticle":
$result = mysql_query("SELECT id FROM articles WHERE id = '$aid'");
$count=mysql_num_rows($result);
if($count == '1') {
mysql_query("DELETE FROM articles WHERE id='$aid'") or die(mysql_error());
?>
Article deleted
<meta http-equiv="refresh" content="0; url=articles.php?do=edit">
<?
} else {
?>
Article not found
<?
die;
}
break;

halojoy

you can try using
header ( "location: forum.php" )
this is the PHP redirect

mysql_query("UPDATE forums SET locked='1' WHERE id='$tid'");

?>
This thread has been locked
<?php

header( "location: forum.php" );
exit;


// and articles
mysql_query("DELETE FROM articles WHERE id='$aid'") or die(mysql_error());
?>
Article deleted
<?php
header( "location: articles.php?do=edit" );
exit;

} else {
?>
Article not found
<?php
exit; // 'exit' is the same as 'die'
}
break;

an out-of-topic notice:
it is recommended to use:
<?php
instead of short tag:
<?

2005

halojoy, thank you for your answer. I know about "header". I like this way of redirection but it will work only in case if there is no output before it. So, "echo" is not possible before "header". And at the beginning of php file i have things like

include_once 'header.php';
opentable();

If I want to use "header" I have to redesign all scripts.

2005

I was wrong... This problem exists even I remove page refreshing after query. I just looked at log files and I see that sometimes something causes page refreshing and the same query is being executed twice.

halojoy

2005 wrote:
halojoy, thank you for your answer. I know about "header". I like this way of redirection but it will work only in case if there is no output before it. So, "echo" is not possible before "header". And at the beginning of php file i have things like
include_once 'header.php';
opentable();
If I want to use "header" I have to redesign all scripts.

I dont know why, but everyone seems must have auto-redirections.
Because it is fancy?
At the same time, we dont like websites that redirects you
so you are toally lost and have no control where they sent you.

I often use a simple
<a href="goto.php">goto next</a>

People know how to CLICK!!!
and many like to know what is happening. = be in control of their own browser

I suggest you overcome your issues/problems
by using
simple but good normal links

/halojoy, July 2006
.

2005

Thanks halojoy. I know what you mean and I am making my pages very simple so that users can understand what they do and where they are.
Sure, I can use "go next" or something like that but as I wrote in my previous post something is cousing page reload even if I remove <meta http-equiv="refresh" content="1...
I posted to my test forum some 100 messages and then tried to delete them one by one. I deleted 8 messages. on 9th message I got "Message not found". Then I deleted 18 messages and again "Message not found". When I look in log files I see double page calls with the same values. I am sure I do not click twice on "delete". I searched Google and some people have problems like this and it's html not mysql/php related.

Unfortunately, it's not possible change the the subject of this thread, so I am going to open a new thread with this problem.