help with if else statement

adammc

Hi folks,

I am a bit stuck with how to correctly format this if/else statement, I am still learning PHP.

I am trying to calculate the postage for a shopping cart. The state variable is stores in a session when the user logs in.

If the user is from QLD then I want to charge him a set range of postage prices based on how much the order total is, if he lives anywhere else (=! QLD) I want to charge different amount.

I came up with this, but I am sure it wont work:


// Calculate postage amount based on state

	if ($_SESSION['state'] == QLD) {
		if ($subtotal > 100) {
		$PostalAmount = number_format( 5.00, 2);
		}
		if ($subtotal > 200) {
		$PostalAmount = number_format( 10.00, 2);
		}
		if ($subtotal > 300) {
		$PostalAmount = number_format( 15.00, 2);
		}

	elseif ($_SESSION['state'] != QLD) {
		if ($subtotal > 100) {
		$PostalAmount = number_format( 8.00, 2);
		}
		if ($subtotal > 200) {
		$PostalAmount = number_format( 13.00, 2);
		}
		if ($subtotal > 300) {
		$PostalAmount = number_format( 19.00, 2);
		}

Any help would be GREATLY appreciated.

bradgrafelman

Well, first off it won't work because you never close the two if/else statements for the SESSION checking. Also, is QLD a constant you defined someone, or an actual value? If it's an actual value, it should be a string; strings are surrounded in quotes.

Now, it's no big deal, but I'll mention it just for the sake of good coding and logic. No where in these if statements do you address the issue of having a subtotal of less than or equal to $100. Therefore, $PostalAmount is never set.

Also, if an order is greater than $300, the script will run all 3 if statements. Due to your structure, this doesn't really do much other than force PHP to process some code it doesn't need to. To fix this, you'll want to rework your logic. Instead of saying "if $subtotal is greater than 100", name a specific range so that the if's don't overlap: "if $subtotal is gerthan than 100 and less than or equal to 200" like so:

if ($subtotal > 100 && $subtotal <= 200) {