Messy code, possibly another way?

[webmaster66]

it there an easy way then all those if else functions. Because i want to add italics and underniled. Doing it that way would take about 18 if else statements. Is there a way to do those if elses with out the if else part. does anybody even get what i mean. How can i simplify this?
<?php
header("Location: http://****************webmaster66/amtesting/send2.html");
$handle = fopen("am2.txt", "a");
{
if ($REQUEST["color"] != NULL && $REQUEST["bold"] != NULL)
{
fwrite($handle, $COOKIE['username'] );
fwrite($handle, ": ");
fwrite($handle, "<b>");
fwrite($handle, "<font color='" . $REQUEST["color"] . "'>");
fwrite($handle, $REQUEST["user"]);
fwrite($handle, "</font></b>");
}
else
{
if ($REQUEST["color"] != NULL)
{
fwrite($handle, $COOKIE['username'] );
fwrite($handle, ": ");
fwrite($handle, "<font color='" . $REQUEST["color"] . "'>");
fwrite($handle, $REQUEST["user"]);
fwrite($handle, "</font>");
}
else
{
if ($REQUEST["bold"] != NULL)
{
fwrite($handle, $COOKIE['username'] );
fwrite($handle, ": ");
fwrite($handle, "<b>");
fwrite($handle, $REQUEST["user"]);
fwrite($handle, "</b>");
}
else
{
fwrite($handle, $COOKIE['username'] );
fwrite($handle, ": ");
fwrite($handle, $REQUEST["user"]);
}
}
}

}
fwrite($handle, "\r\n");
fclose($handle);
exit;
?>

[laserlight]

You dont have much of a choice since that is the logic, but you can simplify:

if (isset($_REQUEST["user"]))
{
	$str = $_COOKIE["username"] . ": ";
	if (isset($_REQUEST["color"], $_REQUEST["bold"]))
	{
		$str .= "<b><font color='" . $_REQUEST["color"] . "'>" . $_REQUEST["user"] . "</font></b>";
	}
	elseif (isset($_REQUEST["color"]))
	{
		$str .= "<font color='" . $_REQUEST["color"] . "'>" . $_REQUEST["user"] . "</font>";
	}
	elseif (isset($_REQUEST["bold"]))
	{
		$str .= "<b>" . $_REQUEST["user"] . "</b>";
	}
	else
	{
		$str .= $_REQUEST["user"];
	}

if ($handle = fopen("am2.txt", "a"))
{
	fwrite($handle, $str . "\r\n");
	fclose($handle);
}
}

[Weedpacket]

Well, you could simplify the logic a bit: noting that what happens when both 'color' and 'bold' are set is just what happens if 'color' is set and 'bold' is set...

if(isset($_REQUEST['user']) && $handle=fopen('am2.txt', 'a'))
{
    fwrite($handle, $_COOKIE['username'].": ");
    $str = $_REQUEST['user'];
    if(isset($_REQUEST['color']))
    {
        $str = '<font color="'.$_REQUEST['color']'">'.$str.'</font>'; // <font> - Welcome to 1995!
    }
    if(isset($_REQUEST['bold']))
    {
        $str = '<b>'.$str.'</b>';
    }
    fwrite($handle, $str."\r\n");
    fclose($handle);  

}

[webmaster66]

Cleaned up the code. thanks guys

[webmaster66]

this is what it ended up being. It woulda been 55 if else statements

<?php
header("Location: http://****************webmaster66/send.html");
$handle = fopen("am.txt", "a");
$uname = $COOKIE['username'] . ": ";
$text = $REQUEST["user"];
$font = "<font color='" . $REQUEST["color"] . "' size='" . $REQUEST["text_size"] . "'>";
$bold = NULL;
$italic = NULL;
$underline = NULL;

if (isset($REQUEST["bold"]))
$bold = "<b>";
if (isset($REQUEST["italic"]))
$italic = "<i>";
if (isset($_REQUEST["underline"]))
$underline = "<u>";

fwrite($handle, $uname);
fwrite($handle, $font);
fwrite($handle, $bold);
fwrite($handle, $italic);
fwrite($handle, $underline);
fwrite($handle, $text);
fwrite($handle, "</u></i></b></font>");

fwrite($handle, "\r\n");
fclose($handle);
exit;
?>

[Weedpacket]

Er, that would produce invalid HTML, since you'd end up with things like </u> without a matching <u>....

But then, that wouldn't be an issue if you used stylesheets instead as I had alluded; there'd only be a single closing tag anyway.

$uname = $_COOKIE['username'] . ": ";
$text = $_REQUEST["user"];

$styles = array();

// Incidentally, you forget to check that these are set ....?
if(isset($_REQUEST['color']))
	$styles[] = "color:".$_REQUEST['color'];
if(isset($_REQUEST['text_size']))
	$styles[] = "font-size:".$_REQUEST['text_size'];

if(isset($_REQUEST['bold']))
	$styles[] = "font-weight:bold";
if(isset($_REQUEST['italic']))
	$styles[] = "font-style:italic";
if(isset($_REQUEST['underline']))
	$styles[] = "text-decoration:underline";

$handle = fopen("am.txt", "a");
fwrite($handle, $uname);
fwrite($handle, "<span style='".join(';',$styles)."'>");
fwrite($handle, $text);
fwrite($handle, "</span>");
fclose($handle);
exit;

Oh, and you might want to check things like $REQUEST['user'], $REQUEST['color'], and $_REQUEST['text_size'] to make sure that someone's not trying to slip anything malicious past you.