Custom Function Problem

[Oni]

Hey--

I thought I'd make a function because it would be much easier to work with, because many of the code repeats itself...

So I made one but I get these errors:

Warning: ftp_rawlist() expects parameter 1 to be resource, string given in C:\xampp\htdocs\ftp.php on line 54

Warning: Invalid argument supplied for foreach() in C:\xampp\htdocs\ftp.php on line 33

Warning: Invalid argument supplied for foreach() in C:\xampp\htdocs\ftp.php on line 56

I have included the better half of the code, I don't think that the rest is needed, but please let me know if it is!

function spider($conn, $dir) {
$buff = ftp_rawlist($conn, $dir);
$items = itemize_dir($buff);
foreach($items as $line=>$item)
  {

$file = $ftp . $dir . $item['name'];  

$fh = fopen('ftp.txt', 'a') or die("can't open file");
fwrite($fh, $file . "\n");
fclose($fh);

  echo $file;
  echo "<BR>";

If($item['type'] == 0) {
$work = spider($ftp_host, $dir . $item['name']);

  } } }

$work = spider($ftp_host, '/' );

Thanks! 😉

[laserlight]

You need to format your code properly and examine your variables.

function spider($conn, $dir) {
	$buff = ftp_rawlist($conn, $dir);
	$items = itemize_dir($buff);
	foreach ($items as $line => $item) {
		// what's $fp?
		$file = $ftp . $dir . $item['name'];
		$fh = fopen('ftp.txt', 'a') or die("can't open file");
		fwrite($fh, $file . "\n");
		fclose($fh);

	echo $file . "<br />";

	if ($item['type'] == 0) {
		// what's $ftp_host here?
		$work = spider($ftp_host, $dir . $item['name']);
	}
}
}

// is this $ftp_host a valid FTP resource?
$work = spider($ftp_host, '/' );

[Oni]

All of the vars should be correct (not null)

Full code below...
As you can see, my attempts at making a ftp spider 😛

<?php

$ftp = $_GET["ftp"];
$dir = $_GET["dir"];

$ftp_host = $ftp;
$ftp_user = "anonymous";
$ftp_password = "anonymous";


echo "Connecting to $ftp_host via FTP...<BR>";
flush();
ob_flush();
$conn = ftp_connect($ftp_host);
$login = ftp_login($conn, $ftp_user, $ftp_password);


$mode = ftp_pasv($conn, TRUE);


if ((!$conn) || (!$login) || (!$mode)) {
   die("FTP connection has failed !");
}
echo "Login Ok.<BR>";
flush();
ob_flush();
$mode = ftp_pasv($conn, TRUE);


function itemize_dir($contents) {
   foreach ($contents as $file) {
       if(ereg("([-dl][rwxstST-]+).* ([0-9]*) ([a-zA-Z0-9]+).* ([a-zA-Z0-9]+).* ([0-9]*) ([a-zA-Z]+[0-9: ]*[0-9])[ ]+(([0-9]{2}:[0-9]{2})|[0-9]{4}) (.+)", $file, $regs)) {
           $type = (int) strpos("-dl", $regs[1]{0});
           $tmp_array['line'] = $regs[0];
           $tmp_array['type'] = $type;
           $tmp_array['rights'] = $regs[1];
           $tmp_array['number'] = $regs[2];
           $tmp_array['user'] = $regs[3];
           $tmp_array['group'] = $regs[4];
           $tmp_array['size'] = $regs[5];
           $tmp_array['date'] = date("m-d",strtotime($regs[6]));
           $tmp_array['time'] = $regs[7];
           $tmp_array['name'] = $regs[9];
       }
       $dir_list[] = $tmp_array;
   }
   //return $tmp_array;
   return $dir_list;
}

function spider($conn, $dir) {
$buff = ftp_rawlist($conn, $dir);
$items = itemize_dir($buff);
foreach($items as $line=>$item)
  {

$file = $ftp . $dir . $item['name'];  

$fh = fopen('ftp.txt', 'a') or die("can't open file");
fwrite($fh, $file . "\n");
fclose($fh);

  echo $file;
  echo "<BR>";

If($item['type'] == 0) {
$work = spider($ftp_host, $dir . $item['name']);

  } } }

$work = spider($ftp_host, '/' );





  ?>

[Installer]

When you recurse the function you pass it "$ftp_host" which is apparently a URL, not a connection resource. It wouldn't work anyway, since that variable is not in the function's scope.

[Kudose]

edit
Installer beat me 🙁
/edit

[Oni]

Thanks! 🙂

Any suggestions in which you think I could make it work?

Cause even though I know the problem, I can't seem to think of another way... 🙁

[Installer]

Try passing the connection resource ($conn), and follow laserlight's suggestion (format your code more logically).