Sort in alphabetical order

jd57

Hi Everyone,

I'm trying the following code to put Bloom_Name in alpabetical order but I'm getting the following error.
"Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result"

Can someone tell me what is wrong with this code?
Thanks

[code=php]$SQL="SELECT Bloom_Name, Pod_Name, Pollen_Name, Hybridiser, Origin
FROM ihsreg ORDER BY Bloom_Name ASC $column LIKE \"%".$name."%\" AND $column != ''";

$result = mysql_query($SQL);
$results = array();
while($row = mysql_fetch_row($result)){
	$results[] = $row;
}
return $results;[/code]

thepeccavi

Get rid of
$results = array();

That SHOULD solve it...

enjoy!

blackhorse

echo mysql_error(); to see what is the error message

Installer

You may have already solved it if you followed blackhorse's advice. If not, try this:

$SQL="SELECT Bloom_Name, Pod_Name, Pollen_Name, Hybridiser, Origin 
    FROM ihsreg WHERE $column LIKE \"%".$name."%\" AND $column != '' ORDER BY Bloom_Name ASC";

Or, for more consistency and readability:

$SQL = "SELECT Bloom_Name, Pod_Name, Pollen_Name, Hybridiser, Origin " . 
       "FROM ihsreg " .
       "WHERE " . $column . " LIKE '%" . $name . "%' AND $column != '' " .
       "ORDER BY Bloom_Name ASC";

BTW, don't get rid of $results = array();

pedrotuga

I would take $results=array(); away and use push...

laserlight

I would take $results=array(); away and use push...

You cant (or rather shouldnt) use array_push() without initialising the array. Furthermore, since one can only push one item at a time here, $results[] = $row; is better as there is no overhead of a function call.

pedrotuga

laserlight wrote:
You cant (or rather shouldnt) use array_push() without initialising the array. Furthermore, since one can only push one item at a time here, $results[] = $row; is better as there is no overhead of a function call.

i am not shure about this, but aren't the function implemented ( is that an english word? well, anyway... ) at the same level as the operators?
By this i mean, despite the diferent looking in the code, what apears to be so much simpler might be the exact same or sometimes even worse in terms of eficiency.

about the first pushed value... we could use a if(isset $foo) test well... now that would slow down the thing s it has to be tested all the time... lol 😕 😕 😕

laserlight

i am not shure about this, but aren't the function implemented ( is that an english word? well, anyway... ) at the same level as the operators?

No, they are not. In PHP, operators are language constructs, not functions.

By this i mean, despite the diferent looking in the code, what apears to be so much simpler might be the exact same or sometimes even worse in terms of eficiency.

That is possible, but we are dealing with small efficiencies here so it doesnt really matter either way. In this case, the PHP Manual recommends not using array_push() when only one element is to be pushed to the end of the array. Read the PHP Manual on [man]array_push/man.

about the first pushed value... we could use a if(isset $foo) test well... now that would slow down the thing s it has to be tested all the time...

If $array does not exist, this code creates an array $array with $array[0] set to the value of $value.

$array[] = $value;

This code pushes the value of $value to the end of the $array, which should exist prior to the function call:

array_push($array, $value);

This means that you must declare $array before you use array_push(), whereas this isnt required for the $array[] = $value; syntax.

However, in the code that we are concerned with, if $results is not declared prior to the loop, then it will not even be created if the loop does not even run one iteration. If so, return $results; would be incorrect since $results would not exist, hence declaring $results before the loop is correct.

jd57

Thanks installer, that worked just fine.

Weedpacket

laserlight wrote:
if $results is not declared prior to the loop, then .... hence declaring $results before the loop is correct.

And furthermore, if $results does exist prior to the loop, then its contents would have to be cleared out before using it again for its current purpose. Otherwise there'd be either spurious entries in the resulting array, or it'd be an attempt to use a non-array value as though it was an array.