which is a better method - one file or two?

FatStratCat

Is it better to have your html page layout in one file and your php code in another, or is it better to combine them into one? Also, what may be the plus or minuses of doing it one or the other?

etully

Always better to have two files because then, when someone wants an alternate layout, you can pass in a variable telling the script which external layout file should be used.

The downside is that it takes a little extra time to write a PHP script that uses an external file as the layout - and I'm usually too lazy to turn a 5 minute job into a 15 minute job - and it's not always necessary.

ysu

The good code starts with order IMHO.

If the project is so small there's virtually no need for multiple files, then there's probably no need for php either.

If there's a need for php, always use multiple files.
Store the program, the settings, function libraries, classes, the templates (layouts) all in separate files. If there's more, then keep them separated by theme as well.

Edit: you might want to allow the non-templated versions sometimes, where the layout and the base programming is virtually one. Other stuff still goes outside.

Don't be the programmer everyone uses only once and the just wants to forget.

Lazyness is an ugly excuse for this kind of slackness 🙂

FatStratCat

I wasn't sure, since I 've read that both can be used, and in Larry Ullmans 2nd edition book towards the end he only uses a single file to do both.

Makes more sense to me to have separate files. Easier to update, easier to read. I was also wondering if there were any security issues with it.

ysu

no, no security issues at all. just keep all important the files with php extension. What is a bad habit, having settings files in with .ini or other extension. That can be a security issue.