[RESOLVED] Help with my code.

SMDskata

Hey everyone, I'm new here. I'm sorta new to PHP. I have written a simple script to have all IRC bans on my channel to be sent to my database. i.e. When someone bans someone, they have to fill out my form(www.kickbac.com/ircban.php). After they submit that it go to the process page then it is redirected to the sucess page. On the proceess page, I get this error "
Parse error: syntax error, unexpected T_STRING in /home/sMDskata/domains/kickbac.com/public_html/submitban.php on line 12" I was looking at my php on line 12. I couldn't find anything wrong. Can someone help. The link to my coding. http://pastebin.com/768535 . Thanks to anyone who can help.

Thanks,
Skata

drew010

localhost is a string and should be in quotes, however that wouldnt really cause the problem. is the message in die really in quotes in the real script and not the pasted one. btw you can post code here, just put [ php] [/code] around it (no space between the [ and the p)

SMDskata

Ok dude, thanks for helping so fast.

<html>
<head>
<title>#Softmods Ban Submit</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$username="*****";
$password="*****";
$database="sMDskata_kickbac";
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die("Unable to select database");
mysql_query($query);
$query = "INSERT INTO bans VALUES ('','name','ban','ip','discrip')";
mysql_close();
?>
</body>
</html>

Thats the acutal script.

drew010

hm not sure what to tell you, if i copy that code directly and paste it into my editor and run the code it works w/out error, well there are the database errors but no parse error

SMDskata

Do you think its a database error? Do you get the same error when you go to www.kickbac.com/ircban.php ... just fill in the fields with whatever. I checked all my info. Its correct.

drew010

well its not a database error. since its a parse error that means php never even started running the code, it was still tokenizing it for execution. i do get the error you posted above.

just for thrills, try this in place of line 12.

if (!@mysql_select_db($database)) {
  echo mysql_error();
  exit;
}

one thing you can do is just remove all the php lines, and add them in one at a time until you get the error, then try taking the line apart and seeing whats wrong with it. occasionally an unexpected T_STRING error will say 1 line, but the error is really before it, the parser just doesnt realize it until it hits a new line with invalid code.

SMDskata

i got a feeling its the localhost part. I'm gonna try it.

SMDskata

strange...That didn't work and i'm still getting the same error. this what I narrowed it down too.

<?php
$username="sMDskata";
$password="*****";
mysql_connect("localhost",$username,$password);
mysql_close();
?>

Houdini

<html>
<head>
<title>#Softmods Ban Submit</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$username="*****";
$password="*****";
$database="sMDskata_kickbac";
$connect = mysql_connect("localhost",$username,$password)
    or die("Could not connect to server. MySQL said:".mysql_error());
$select = mysql_select_db($database) 
    or die("Unable to select database. MySQL said: ".mysql_error());
$query = "INSERT INTO bans VALUES ('','name','ban','ip','discrip')";
$result = mysql_query($query);
mysql_close();
?>
</body>
</html>

SMDskata

Hmm. did not work Houdini. Same error. . .This world makes me wonder.

SMDskata

A word of advice, NEVER post your password in the forums. I've removed it for you.

madwormer2

Tut tut, putting your password in a forum 😉

Hopefully no-one saw it, eh?

bradgrafelman

I'm guessing this is fixed? Form worked for me..

Houdini

I ran this code sucessfully on my own MySQL server

<html>
<head>
<title>#Softmods Ban Submit</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$username="root";//put you real stuff here
$password="";//put your real stuff here
$database="angel_test";//put your real stuff here
$connect = mysql_connect("localhost",$username,$password)
    or die("Could not connect to server. MySQL said:".mysql_error());
$select = mysql_select_db($database)
    or die("Unable to select database. MySQL said: ".mysql_error());
$query = "INSERT INTO ban VALUES ('','name','ban','ip','discrip')";
$result = mysql_query($query)
	or die("Query failed. Mysql said:".mysql_error());
mysql_close();
?>
</body>
</html>

You might want to use variables instead of name, ban, ip and discrip because those sound more like field names and not real data. Also what was the error that you got, specifics are needed to help you with this. This is why I included an error check with all database queries.

SMDskata

Sorry Houdini, my fault totaly. I figured Dreamweaver was not sucsessfuly ftping the files. I fixed it, not its a charm!. I would like to thank you and Drew010 for helping me. ThankYou