Header won't execute

oaskedal

Hi!

Why doesn't this header execute when I fill out the form correctly (no errors)...?


{
      header ("Location: http://www.domain.no/thankyou.htm" );
     }

Her is the code in all (including my form). All of it have been saved as kontakt.php:


<form action="kontakt.php" method="post" >

<span class="heading" ><img src="images/webbilder/kontaktimage.gif" /></span><br /><br /><span class="felter">Felter merket * må fylles ut</span><br /><br />

<span class="skjema">Firstname*</span><br />
<input name="navn" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />
<span class="skjema">Lastname*</span><br />
<input name="etternavn" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />
<span class="skjema">Telephonenumber</span><br />
<input name="mobil" type="text" class="textfelt" size="20" maxlength="8" /><br /><br />
<span class="skjema">e-mailaddress*</span><br />
<input name="email" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />
<span class="skjema">Subject</span><br />
<input name="emne" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />
<span class="skjema">Your message*</span><br />
<textarea name="melding" cols="70" rows="10" class="textfelt"></textarea>
<br /><br />
<input name="send" type="submit" value="send" /><input name="reset" type="reset" value="slett" />
</form>


<?php 

if($_POST['send']) {
   $errcount = 0; 
   $error = '';
}

{ //check if someone has filled out a form

//validate name
if(preg_match('/^[a-zæøåÆØÅ_-]{2,}$/i', $_POST['navn'])){ 
    $navn = $_POST['navn'];     
} else { 
    $error .= "You didn't write a name!<br />"; 
    $errcount++;  
} 

{ //check lastname

//validate lastname
if(preg_match('/^[a-zæøåÆØÅ_-]{2,}$/i', $_POST['etternavn'])){ 
    $etternavn = $_POST['etternavn'];     
} else { 
    $error .= "You didn't write your lastname!<br />"; 
    $errcount++;  
}
//validate telephonenumber
   if(preg_match('/^[0-9_-]{8,}$/i', $_POST['mobil'])){
        $mobil = $_POST['mobil'];
    } else {
        $error .= "You didn't write a correct telephonenumber!<br />";
       $errcount++;
}
    //check correct email  

    if(preg_match('/^[\w]+[-\w._]*@[\w]+[-\w]+(\.[\w]+[-\w]+)*\.[\w]{2,6}$/ ', $_POST['email'])){ 
        $epost = $_POST['email']; 
    } else { 
        $error .= "You didn't write a valid e-mail!<br />"; 
        $errcount++;  

    }
    if (empty($_POST['melding'])) {
        $melding = $_POST['melding'];
    } else {
        $error .= "You didn't write a message!<br />";
        $errcount++;
    }    

//Check for faults
//if there's a fault, stop the script and preview the following
if ($errcount !=0) {
     die("<p>Sorry, there is $errcount faults in your form. Please correct these:</p>" . $error ); 

} 

else {


$emne = $_POST['emne']; 
$mailheaders = "From: " .$navn ." " .$etternavn ." <". $epost . ">\n";  
$mailheaders .= "Reply-To: <". $epost . ">\n";  
$to = 'my@domain.no';
$melding = $_POST['melding'];
$melding = "Fra: $navn $etternavn\nTelefon: $mobil\n\nMelding:\n$melding";

mail( $to, $emne, $melding, $mailheaders, '-fmail@domain.no'); //Send Mail 
 {
  header ("Location: http://www.domain.no/thankyou.htm" );
 }

}     

}
} 

?>

Houdini

You have curley braces enclosing statements with no condition This code has had the conditions fixed and the extraneous {} removed try this. Also you were checking $POST{'send'] which is really a value and not a key the key is $POST['submit'] which has a value of send if the submit has been clicked so it has been corrected. This code has been tested and definately works because I just entered my own email values and ran it with no problem, all you have to do is have the correct email stuff in the below code.

<?php
if($_POST['submit']=="send") {
   $errcount = 0;
   $error = "<span style='color:red'>";
//check if someone has filled out a form
//validate name
    if(preg_match('/^[a-zæøåÆØÅ_-]{2,}$/i', $_POST['navn'])){
        $navn = $_POST['navn'];     

    }
        else {
        $error .= "You didn't write a name!<br />";
        $errcount++;  

        }
//check lastname
//validate lastname
    if(preg_match('/^[a-zæøåÆØÅ_-]{2,}$/i', $_POST['etternavn'])){
        $etternavn = $_POST['etternavn'];     

    }
        else {
        $error .= "You didn't write your lastname!<br />";
        $errcount++;  

        }
//validate telephonenumber
   if(preg_match('/^[0-9_-]{8,}$/i', $_POST['mobil'])){
        $mobil = $_POST['mobil'];
    }
        else {
        $error .= "You didn't write a correct telephonenumber!<br />";
       $errcount++;
        }
//check correct email  

    if(preg_match('/^[\w]+[-\w._]*@[\w]+[-\w]+(\.[\w]+[-\w]+)*\.[\w]{2,6}$/ ', $_POST['email'])){
        $epost = $_POST['email'];
    }
        else {
        $error .= "You didn't write a valid e-mail!<br />";
        $errcount++;  

        }
    if (!empty($_POST['melding'])) {
        $melding = $_POST['melding'];
    }
        else {
        $error .= "You didn't write a message!</span><br />";
        $errcount++;
        }    

//Check for faults
//if there's a fault, stop the script and preview the following
    if ($errcount !=0) {
         die("<p>Sorry, there is $errcount faults in your form. Press your <b>back</b> button to correct these:</p>" . $error );
    }
        else {
        $emne = $_POST['emne'];
        $mailheaders = "From: " .$navn ." " .$etternavn ." <". $epost . ">\n";  

        $mailheaders .= "Reply-To: <". $epost . ">\n";  

        $to = 'youremail@somewhere.com';
        $melding .= $_POST['melding'];//I put the message at the bottom
        $melding = "Fra: $navn $etternavn\nTelefon: $mobil\n\nMelding:\n$melding";
        //Send Mail
        mail($to, $emne, $melding, $mailheaders,'youremailstuffhere');  

        header ("Location: thankyou.htm");
         }
}
?>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" >
  <span class="heading" ><img src="images/webbilder/kontaktimage.gif" />
  </span><br /><br /><span class="felter">Felter merket * må fylles ut</span><br /><br />  

  <span class="skjema">Firstname*</span><br />  

  <input name="navn" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />  

  <span class="skjema">Lastname*</span><br />  

  <input name="etternavn" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />  

  <span class="skjema">Telephonenumber</span><br />  

  <input name="mobil" type="text" class="textfelt" size="20" maxlength="8" /><br /><br />  

  <span class="skjema">e-mailaddress*</span><br />  

  <input name="email" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />  

  <span class="skjema">Subject</span><br />  

  <input name="emne" type="text" class="textfelt" size="40" maxlength="40" /><br /><br />  

  <span class="skjema">Your message*</span><br />  

  <textarea name="melding" cols="70" rows="10" class="textfelt"></textarea>  <br /><br />  

  <input name="submit" type="submit" value="send" />
  <input name="reset" type="reset" value="slett" />  

</form>

oaskedal

Hmmmm, I keep getting this error message all the time. Seems to me the thankyou.htm won't execute, when I fill out the form correctly... Do you know what could be the problem..?

'Cannot modify header information - headers already sent by...'

team_lh_Max

Do you include your header and footer around the content area? Then this won't works.

IN that case use a html redirection. You can replace in anyway the header statement by

echo '<meta http-equiv="refresh" content="0;url=index.php">';

where index.php is your redirection url

oaskedal

Also, do you know how I can implement an url back to my contactform in the errormessage? Now, it says that the user must click the back button...

team_lh_Max

echo "<center>Error: Your Error Message. <a href=\"urltoform\">Go back to form</a></center>";

Is only one way, but I assume you mean this

oaskedal

Hi!

Thanks for answering;-)
Is this the way you meane?


echo "<font color=\"red\"><strong><center>Error: die("<p>Sorry, there is $errcount faults in your form. Press your <b>back</b> button to correct these:</p>" . $error ); <br><br><a href=\"urltoform\">Go back to form</a></center></Strong></font>";

I didn't get it to work properly, though..

team_lh_Max

echo "<font color=\"red\"><strong><center>Error: " . die("<p>Sorry, there is $errcount faults in your form. Press your <b>back</b> button to correct these:</p>" . $error . ""); . "<br><br><a href=\"urltoform\">Go back to form</a></center></Strong></font>";

that should work