What is wrong with this code snippet?

A guy gave me a little challange, and asked what is wrong with this code snippet. I actually can't find it out(still working) :bemused:

<?

for ($i= 10; $i<20; i++) {

var $txt= 'U are cool';

echo 'Txt do be written $txt\n\r';

}

?>

Have you tried running it? Does it give you the results you expext?

I can see 3 things wrong with it, but clearly this is some sort of test YOU must complete.

I'm running it now, and find two errors. I'm pretty neebie in php programming so its therefore I'm asking for some help

$i++;

$i++;

Hehe.... that makes 4.

I'm running it now, and find two errors.

Well what are they?

Is this homework or something? Why should we give you the answers?

wakextreme wrote:
$i++;

This one is not an error, so im stil stuck with two; the var $txt is wrong declaration and use of single vs double quotation marks.

its not a homework, its a little "challange" from a friend

found the third error, it was i++ that was missing variabel declaration, but as I said the ; after is wrong

but as I said the ; after is wrong

Yeah, it was the missing $ I was refering to, not the extra ; which yeah... as you said was clearly wrong.

Anyway... the other mistake (not so much an error, but BAD practice) is the short tags. Always use <?php and never just <?

does indentation counts (eg formatting)? 🙂

what is indentation ?

Also \n\r doesn't give a new line in the browser output, only the source code

Also \n\r doesn't give a new line in the browser output

So? Not all php is intended to generate html.