Creating a reviews script

renob

Hiya, im tryin to make a script that will allow users to submit a review of services through a form. Data goes into a mysql db, then later ill want to retrieve certain fields to display, as seen on many sites.

I know there are tons of scripts already made, but id rather make this one myself, since im still a bit new to php.

anyways, i have the form made and the sql functons are all working, but my error checking is a jumble and ive revised the code nearly 40 times already (according to the auto-increment field :rolleyes: ) and starting to get frustrated, i just dont see why it wont work.

Heres what i got so far.

$host="localhost";
$uname="xxxxxx";
$pass="xxxxxx";
$db="reviews";
$table="reviews";
$form =" A Pretty long Form";                 //SET THE FORM
if ($_POST[op]!="ds")
{
echo $form;						//SHOW THE FORM
}
elseif ($_POST[op]="ds")
{	//START CHECKING INPUT
if ($_POST['firstname']="")
{
  $err1="<b><font color=\"#FF0000\">Please Fill In Your Firstname</font></b><br>";
  $send="no";
}
if ($_POST['lastname']="")
{
  $err2="<b><font color=\"#FF0000\">Please Fill In Your Lastname</font></b><br>";
  $send="no";
}
if ($_POST['email']="")
{
  $err3="<b><font color=\"#FF0000\">Please Fill In You Email</font></b><br>";
  $send="no";
}
if ($_POST['website']="")
{
  $err4="<b><font color=\"#FF0000\">Please Fill In Your Website</font></b><br>";
  $send="no";
}
if ($_POST['newreview']="")
{
  $err5="<b><font color=\"#FF0000\">Please Submit a Review</font></b><br>";
  $send="no";
}
if ($_POST['uptime']="")
{
  $err6="<b><font color=\"#FF0000\">Please Select Uptime & Reliability</font></b><br>";
  $send="no";
}
if ($_POST['support']="")
{
  $err7="<b><font color=\"#FF0000\">Please Select From Technical Support</font></b><br>";
  $send="no";
}
if ($_POST['customer']="")
{
  $err8="<b><font color=\"#FF0000\">Please Select From Customer Service</font></b><br>";
  $send="no";
}
if ($_POST['status']="")
{
  $err9="<b><font color=\"#FF0000\">Please Select From Billing Status</font></b><br>";
  $send="no";
}
if ($_POST['duration']="")
{
  $err10="<b><font color=\"#FF0000\">Please Select From Time With The Company</font></b><br>";
  $send="no";
}
if ($_POST['plan']="")
{
  $err11="<b><font color=\"#FF0000\">Please Select Plan Used</font></b><br>";
  $send="no";
}
}
elseif ($send=="no")
{
  echo $err1;
  echo $err2;
  echo $err3;
  echo $err4;
  echo $err5;
  echo $err6;
  echo $err7;
  echo $err8;
  echo $err9;
  echo $err10;
  echo $err11;
  echo $form;
  exit();
}
//CONNECT TO THE DATABASE
$connection=@mysql_connect($host, $uname, $pass)or die("Could not connect to database:".  mysql_errno());
$dbs=@mysql_select_db($db, $connection)or die("Database does not exist:".mysql_errno());

//CHECK THE USER INPUT FOR KEY FIELDS
$check="select firstname, lastname, email, ip, website from $table where firstname='$_POST[firstname]'AND lastname='$_POST[lastname]'AND email='$_POST[email]' AND ip='$_POST[ip]' AND website='$_POST[website]'";

//GET THE RESULT
$result=mysql_query($check, $connection)or die("Could not obtain results:".mysql_errno());
$result_num=mysql_num_rows($result);

//GET # OF RESULTS AND DO ACTION
if ($result_num<1)
{
$sql_q="INSERT INTO $table VALUES('', '$_POST[firstname]', '$_POST[lastname]', '$_POST[email]', '$_POST[ip]', '$_POST[website]', '$_POST[newreview]', '$_POST[uptime]', '$_POST[support]', '$_POST[customer]', '$_POST[status]', '$_POST[duration]', '$_POST[plan]',now())";

//GET RESULT OF THE ADDITION
$result_add=mysql_query($sql_q, $connection) or die("Could not insert into database:".mysql_error());

$form="<h1> Your review has been submitted, thank you for your time.</h1>";
}
else
{
$form="<h1>We're sorry, it appears you have already entered a review.  Thank you again</h1>";
}

Im totally lost now what to do, seems to be so close, any help would be greatly appreciated.

Thanks.

thorpe

Im sorry, but I simply cannot read that code. Learn to indent.

i just dont see why it wont work.

You might also explain what you meen by that. There could be numerous problems here, are you getting any errors? What happens when you run this?

renob

Sorry, as i said, im still fairly new to php so im trying to get the techniques down, ill edit the above for ya.

Basically, what i wanna do is check whether the fields are empty or not. If there empty, display the correct error message for that field above and reload the form.

Currently, when i enter the page, reviews.php, it shows the form, and if i leave the fields blank and hit submit, it shows the errors and the form, just as i want, but its also inserting empty fields into the database, instead of stopping the connection when it hits an error.

Hope that makes more sense.

Thanks again

thorpe

Ok... Your using a = as a comparison operator, = is an assignment operator. Also, you never exit() the script if there is an error. Try...

if ($send == "no")
{
  echo $err1;
  echo $err2;
  echo $err3;
  echo $err4;
  echo $err5;
  echo $err6;
  echo $err7;
  echo $err8;
  echo $err9;
  echo $err10;
  echo $err11;
  echo $form;
  exit();
}
}

Also... just a tip. You might want to look into using booleens instead of this $send="no" bussiness. There much easier to follow. eg;

$error = true;
if ($error) {
  exit("an error has occured");
}

renob

i have tried using exit(); before, however the rest of the html stops loading when it encounters an error, since the form is in the center of the page, and havnt figured out how to fix that, unless i should jump out of php right before?

Thanks for that boolen tip, i was getting tired of writing send=no over and over 🙂

ill hop over to php.net, but out of curiosity, how would i use the bool and still print the designated messages as they pertain to the fields?

Thanks again.

renob

Still haveing a bit of a problem with this. Heres the form im using http://mtech-hosting.com/reviews.php

The form displays but after hitting submit, well you can see what happens and what should happen as described in the above code.

The info is being inserted into the database also, but its sending blank info instead of printing the error messages.

Thanks again for the help.

renob

bump/

Still havin an issue with this, ive rewritten the code and it insert the info into the db, however, even though im checking for ip addresses, its still inserting rows everytime i hit submit and its only inserting the first 3 numbers.

Thanks.

if($_POST['op']!='ds'){
  $form=$form;
}
	else if ($_POST['op']=='ds')
{
  if (!$_POST[firstname]){
    echo "<b><font color=\"#FF002A\">Please fill in your firstname</font></b><br>";
  }  

  if (!$_POST[lastname]){
    echo "<b><font color=\"#FF002A\">Please fill in your lastname</font></b><br>";
  }
  if (!$_POST[email]){
    echo "<b><font color=\"#FF002A\">Please fill in your email</font></b><br>";
  }
  if (!$_POST[website]){
    echo "<b><font color=\"#FF002A\">Please fill in your website</font></b><br>";
  }
  if (!$_POST[newreview]){
    echo "<b><font color=\"#FF002A\">Please enter your review</font></b><br>";
  }
  if (!$_POST[uptime]){
    echo "<b><font color=\"#FF002A\">Please select from uptime</font></b><br>";
  }
  if (!$_POST[support]){
    echo "<b><font color=\"#FF002A\">Please select from support</font></b><br>";
  }
  if (!$_POST[customer]){
    echo "<b><font color=\"#FF002A\">Please select from customer service</font></b><br>";
  }
  if (!$_POST[status]){
    echo "<b><font color=\"#FF002A\">Please select from billing status</font></b><br>";
  }
  if (!$_POST[duration]){
    echo "<b><font color=\"#FF002A\">Please select time with the company</font></b><br>";
  }
  if (!$_POST[plan]){
    echo "<b><font color=\"#FF002A\">Please select plan used</font></b>";
  }
  $connect=mysql_connect($host, $uname, $pass)or die("Could not connect to server");
  $db_select=mysql_select_db($db, $connect)or die("Could not select database");
  $check="SELECT * FROM $table WHERE ip ='$_POST[ip]'";
  $check_result=mysql_query($check, $connect)or die(mysql_error());
  $check_num=mysql_num_rows($check_result);

  if ($check_num < 1){
    $sql="INSERT INTO $table VALUES ('', '$_POST[firstname]', '$_POST[lastname]','$_POST[email]', '$_POST[ip]', '$_POST[website]', '$_POST[newreview]', '$_POST[uptime]', '$_POST[support]', '$_POST[customer]', '$_POST[status]', '$_POST[duration]', '$_POST[plan]', now())";
    $result=mysql_query($sql, $connect)or die(mysql_err());
    $form="<b>Thank you for submitting your review</b>";
    }
else{
	$form="<b>Sorry, it appears you have already submitted a review.  Thank you again</b>";  

	}
}
echo $form;