Not updating the database

[jbachris]

I have this script, which I am trying to have automatically update the database. Right now it seems only to update 1 record, instead of looping through and calculating all, then updating them all in the database.

<?

require ( "xxxxxxxxxxxxxxxx.php" );

$games_rs = $conn->Execute ( "SELECT * FROM soccer_games ORDER BY game_date DESC" ) or die ( $conn->ErrorMsg() );
$games1_rs = $conn->Execute ( "SELECT * FROM soccer_games ORDER BY game_date DESC" ) or die ( $conn->ErrorMsg() );

?>
	<? while ( ! $games_rs->EOF ) {
	$new_rating2 = $games_rs->Fields("team_rating") + $games1_rs->Fields("team_rating");
	?>
		<? 		
	$sql = "UPDATE soccer_ratings SET team_rating = '$new_rating2',  team_prevrating = '$team_rating1' WHERE team_id = '$team_rated'";
	$add_rating_rs = $conn->Execute($sql) or die ( $conn->ErrorMsg() );	
?>
	<? $games_rs->MoveNext(); } ?>

For some reason it is only insert the first row into the database, instead of looping through and calculating each rating, from each game.

[bogu]

Well your script should update this rows: WHERE team_id = '$team_rated', but where is this var $team_rated declared, shouldn't be declared in your while loop?

Shouldnt be something like this?

$team_rated = $games_rs->Fields("team_id");

[Weedpacket]

Might I also ask why you have $games_rs and $games1_rs - especially since you're only looping over one of them? Eh, now I know I'm tired.

[Houdini]

Just kind of wondering why you opened PHP 5 times and closed it 5 times all in one script?

[Weedpacket]

My guess would be that the plain HTML in between was removed to focus attention on the code.