[RESOLVED] unexpected $end error

M__Abdel-Ghani

Hi all,

I have an error here

Parse error: syntax error, unexpected $end in D:\Program Files\xampp\htdocs\NewsPortalProject\register.php on line 42

My register.php code

<html>
<head>
<title>Registeration Page</title>
<link rel="stylesheet" type="text/css" href="main.css" />
</head>
<body>
<?PHP
include 'conf.php';
include 'conn.php';
if(isset($_POST['submit']))
{
	if(($_POST['authorname']=="")||($_POST['username']=="")||($_POST['password']=="")||($_POST['repassword']=="")||($_POST['email']==""))
	{
		echo "<h1 class='registerationerror'>Registeration is not successful</h1>";
		echo "<p class='registerationerror'>Please Fill in all fields in the form<br/>You are now redirected to the registeration form</p>";
		echo"<p class='registerationerror'><a href='register.html'>Click here to return back</a></p>";
		header('refresh=3;url=register.html');
	}
	else
	{
		if($_POST['password']!=$_POST['repassword'])
		{
			echo "<h1 class='registerationerror'>Registeration is not successful</h1>";
			echo "<p class='registerationerror'>Password don't match</p>";
			echo"<p class='registerationerror'><a href='register.html'>Click here to return back</a></p>";
			header('refresh=3;url=register.html');
		}
		else
		{
			$authorname=$_POST['authorname'];
			$username=$_POST['password'];
			$password=md5($_POST['password']);
			$email=$_POST['email'];
			$query="INSERT INTO authors (AuthorName,NumberOfArticles,username,password,AuthorEmail) values ('$authorname',0,'$username','$password','$email')";
			mysql_query($query) or die("Error inserting in the database");
			echo "<h1>Registeration is successful </h1>";
			echo"<p class='registerationerror'><a href='register.html'>You are now redirected to the Home page</a></p>";
			header("'refresh=3;url=default.php');
		}
	}
}
?>

What is the cause of the error?
Thanks a lot

Merve

You made an error in your last header() line. You have an opening double quote ("), but no closing double quote. However, I'm not sure that that's the error.

BTW, it's spelt registration. :p

Houdini

You had a double quote here

header("'refresh=3;url=default.php');

but it will not work because you are outputting in the two lines before it here;

echo "<h1>Registeration is successful </h1>";
echo"<p class='registerationerror'><a href='register.html'>You are now redirected to the Home page</a></p>";

and you have an else statement that I took out that did... well nothing here

 header('refresh=3;url=register.html');
    }
    else
    {

And also that header will not work either because the two lines before it output to the browser here

echo "<h1 class='registerationerror'>Registeration is not successful</h1>";
        echo "<p class='registerationerror'>Please Fill in all fields in the form<br/>You are now redirected to the registeration form</p>";
        echo"<p class='registerationerror'><a href='register.html'>Click here to return back</a></p>";

This code should work but the redirects won't because there is output before the header(), there can not be any output before calling a header function

<html>
<head>
<title>Registeration Page</title>
<link rel="stylesheet" type="text/css" href="main.css" />
</head>
<body>
<?PHP
include 'conf.php';
include 'conn.php';
if(isset($_POST['submit']))
{
    if(($_POST['authorname']=="")||($_POST['username']=="")||($_POST['password']=="")||($_POST['repassword']=="")||($_POST['email']==""))
    {
        echo "<h1 class='registerationerror'>Registeration is not successful</h1>";
        echo "<p class='registerationerror'>Please Fill in all fields in the form<br/>You are now redirected to the registeration form</p>";
        echo"<p class='registerationerror'><a href='register.html'>Click here to return back</a></p>";
        header('refresh=3;url=register.html');
    }

    if($_POST['password']!=$_POST['repassword'])
    {
        echo "<h1 class='registerationerror'>Registeration is not successful</h1>";
        echo "<p class='registerationerror'>Password don't match</p>";
        echo"<p class='registerationerror'><a href='register.html'>Click here to return back</a></p>";
        header('refresh=3;url=register.html');
    }
    else
    {
        $authorname=$_POST['authorname'];
        $username=$_POST['password'];
        $password=md5($_POST['password']);
        $email=$_POST['email'];
        $query="INSERT INTO authors (AuthorName,NumberOfArticles,username,password,AuthorEmail) values ('$authorname',0,'$username','$password','$email')";
        mysql_query($query) or die("Error inserting in the database");
        echo "<h1>Registeration is successful </h1>";
        echo"<p class='registerationerror'><a href='register.html'>You are now redirected to the Home page</a></p>";
        header('refresh=3;url=default.php');
  }
   }   

?>

halojoy

i got to same conclusion in my editor
without reading previous poster

header("'refresh=3;url=default.php');
//should be
header("'refresh=3;url=default.php'");

Weedpacket

On top of all that,

 header('refresh=3;url=register.html');

Won't work anyway because 'refresh=3;url=register.html' isn't a valid HTTP header. This is the sort of thing that needs to be put in a <meta> tag in the HTML <head> element of the page.

thorpe

'refresh=3;url=register.html' isn't a valid HTTP header

Seems it may be.
http://vancouver-webpages.com/META/metatags.detail.html

Weedpacket

Nope; I checked.

ClarkF1

I think there is confusion between headers and <head></head> section. They are not the same.

Installer

For readers wondering, the code

header('Refresh: 3;URL=http://www.example.com/index.html);

while it's not found in the RFC, does work for me in IE, Firefox, and Netscape. I'm not recommending its use, just stating what I found.

Houdini

So then what you are saying Installer is that those headers would in fact work provided the code originally posted were amended to not output so the header would work. I think I will play with it.

Installer

The code I posted has a typo. It should be

header('Refresh: 3;URL=http://www.example.com/index.html');

and, yeah, it works for me, but I tested it only as a one-line script. I don't see why it wouldn't work in the conditions you describe, though.