[RESOLVED] Images won't show

Quadodo

I've been making an attachment system for the forum I'm working on, and everything seems to work fine except the images don't show because of some error. Anyone know anything about this?

Table data:

id (INT)
name (VARCHAR)
size (INT)
type (VARCHAR)
content (MEDIUMBLO😎
views (INT)
userid (INT)
postid (INT)

It just fetches the uploaded file data then inserts it into this table.

severndigital

how are you referening the image in your other code??

Quadodo

Do you mean this?:

		$row['views']++;
		$sql->sql_query("UPDATE ".$prefix."attachments SET `views`='$row[views]' WHERE id='$id'");
			if (!preg_match("/^image(.*?)$/",$row['type']) && !preg_match("/^text\/plain$/",$row['type'])) {
			header("Content-Type: ".$row['type']);
			header("Content-Disposition: attachment; filename='".stripslashes($row['name'])."'");
			}
			else {
			header("Content-Type: ".$row['type']);
			header("Content-Length: ".$row['size']);
			}
		echo stripslashes($row['content']);

Thats the part of the code that outputs the data, I've checked the stuff in the database compared to the stuff in the actual file I've uploaded, they are the same.

bradgrafelman

Quadodo wrote:
...because of some error.

Which error?

Quadodo

It doesn't show an error, in FX it just says:

The image '{URL}' cannot be displayed because it contains errors.

In IE the box with the red x comes up.

bradgrafelman

Is there any chance you can supply an URL to this page?

Also, have you tried commenting out the header() calls (or changing them to echo() instead) and visiting the page to see if PHP is reporting any errors? Is display_errors set to On and error_reporting set to E_ALL (integer 2048 I think?).

TobyRT

Could the stripslashes be taking out important slashes in the 'content' field? If you're storing images in the code itself (I assume that's why you're using a medium blob), then that might be causing problems?

Quadodo

So I wouldn't have to add the slashes to the content of the file? Wouldn't that leave it open to SQL injection?

Quadodo

RESOLVED: Nevermind everyone, I figured it out - I think. Instead of using addslashes() I'll just base64_encode() and then base64_decode() to show it, it takes up more space but it works.

bradgrafelman

Well, it depends on how the image is inserted.

If it's being uploaded through PHP's file uploads, then magic_quotes_gpc might be enabled, in which case [man]addslashes/man is simply doubling the slashes. If magic_quotes_gpc isn't enabled, you should be able to use [man]addslashes/man to safely insert it, but you wouldn't need [man]stripslashes/man when retrieving it from the DB.

spato

Hi guys I ve been trying to display images stored in ma database together with other data store into ma page but both can't be show at the same time....could someone please help me out?
I use

     header("Content-type: mysql_result($result, 0 ,'filetype')");
     echo mysql_result($result, 0 ,"bin_data");

     echo mysql_result($result, 0 ,"filename");

BUT HEY IT WONT WORK

bradgrafelman

You might want to start your own thread instead of hijacking another's (let alone one already marked RESOLVED...) 😉