This query doesn't work?

lukeurtnowski

Help! My query doen't seem to be working

$ID = $_GET["ID"];

$query = "SELECT * FROM REVIEW WHERE 'ID' = $ID";
$result = mysql_query($query) or die("Error: " . mysql_error()); //Do the query
$Review_Date = $result["R_Date"];
$Phone = $result["ASP_Phone"];
$Phone_Type = $result["Phone_Type"];
$ASP_URL = $result["Website"];
$Informative_Website = $result["Website_Rating"];
$ASP_Email = $result["ASP_Email"];
$ASP_Type = $result["ASP_Type"];
$Offered_Service = $result["Offered_Service"];
$Delivered = $result["Delivered"];
$On_Time = $result["On_Time"];
$Are_Photos_Professional = $result["Professional_Photos"];
$Are_Photos_Current = $result["Current_Photos"];
$How_I_Found_This_ASP = $result["Found"];
$Booking = $result["Booking"];
$Advertised_Length = $result["Advertised_Length"];
$Actual_Length = $result["Actual_Length"];
$Advertised_Cost = $result["Advertised_Cost"];
$Actual_Cost = $result["Actual_Cost"];
$Upselling = $result["Upselling"];
$Compensated = $result["Compensation"];
$IncallOutcall = $result["Incall_Outcall"];
$Attitude = $result["ASP_Attitude"];
$Incall_Conditions = $result["Incall_Conditions"];
$Provided_Service = $result["Provided_Service"];
$Strong_Point = $result["ASP_Strong_Point"];
$Looks = $result["ASP_Looks"];
$Rules = $result["ASP_Rules"];
$ASP_Age = $result["ASP_Age_Range"];
$Attire = $result["ASP_Attire"];
$Intimate_Grooming = $result["ASP_Grooming"];
$Tatoos = $result["ASP_Tatoos"];
$Piercings = $result["ASP_Piercings"];
$Breast_Size = $result["ASP_Breast_Size"];
$Breast_Appearance = $result["Real_Breasts"];
$Scented = $result["ASP_Scented"];
$Smoker = $result["ASP_Smoker"];
$Review_For = $result["Review_For"];
$Made_Session = $result["Session_Made"];
$Again = $result["See_Again"];
$Recommend = $result["Recommend"];
$Username = $result["Username"];
$Email = $result["Email"];
$Display_Email = $result["Display_Email"];
$Age = $result["Age"];
$Frequent = $result["Frequency"];
$How_Long = $result["Time_In_Hobby"];
$Activities = $result["Activity"];
$Rating = $result["Rating"];

$date = date('Y, F, j', strtotime($Review_Date)); 


echo "<p><label>Date:</label>" . $date . "</p>";   

echo "<p><label>ASP name:</label>" . $row['ASP_Name'] . "</p>";  

echo "<p><label>City:</label>".$result['ASP_City']."</p>";  

echo "<p><label>ASP Phone:</label>" . $Phone . "</p>"; 
echo "<p><label>ASP phone type:</label>" . $Phone_Type . "</p>"; 
echo "<p><label>ASP website:</label>" . $ASP_URL . "</p>";   

echo "<p><label>ASP website informative:</label>" .  $Informative_Website . "</p>"; 
echo "<p><label>ASP email:</label>" . $ASP_Email . "</p>"; 
echo "<p><label>Agency, driver, independent?</label>" . $ASP_Type . "</p>"; 
echo "<p><label>Services offered:</label>" . $Offered_Service . "</p>"; 
echo "<p><label>Delivered as promised:</label>" . $Delivered . "</p>"; 
echo "<p><label>On-time:</label>" . $On_Time . "</p>";   

echo "<p><label>Photos professional:</label>" . $Are_Photos_Professional . "</p>"; 
echo "<p><label>Photos current:</label>" . $Are_Photos_Current . "</p>"; 
echo "<p><label>How I found this ASP:</label>" . $How_I_Found_This_ASP . "</p>"; 
echo "<p><label>Booking:</label>" . $Booking . "</p>"; 
echo "<p><label>Advertised length:</label>" . $Advertised_Length . "</p>"; 
echo "<p><label>Actual length:</label>" . $Actual_Length . "</p>";  

echo "<p><label>Advertised cost:</label>" . $Advertised_Cost . "</p>";  

echo "<p><label>Actual cost:</label>" . $Actual_Cost . "</p>"; 
echo "<p><label>Up-selling:</label>" . $Upselling . "</p>"; 
echo "<p><label>Compensated:</label>" .  $Compensated . "</p>"; 
echo "<p><label>Incall or Outcall:</label>" . $IncallOutcall . "</p>";  

echo "<p><label>ASP attitude:</label>" . $Attitude . "</p>"; 
echo "<p><label>In-calls Conditions:</label>" . $Incall_Conditions . "</p>"; 
echo "<p><label>Service provided:</label>" . $Provided_Service . "</p>"; 
echo "<p><label>Strong point:</label>" . $Strong_Point . "</p>"; 
echo "<p><label>Looks rating:</label>" . $Looks . "</p>"; 
echo "<p><label>Rules:</label>" .  $Rules . "</p>"; 
echo "<p><label>ASP age range:</label>" . $ASP_Age . "</p>"; 
echo "<p><label>ASP attire:</label>" .$Attire . "</p>"; 
echo "<p><label>Intimate grooming:</label>" . $Intimate_Grooming . "</p>";  

echo "<p><label>Tatoos:</label>" . $Tatoos  . "</p>"; 
echo "<p><label>Piercings:</label>" . $Piercings . "</p>"; 
echo "<p><label>Breast size:</label>" . $Breast_Size . "</p>"; 
echo "<p><label>Breast real or paid for:</label>" . $Breast_Appearance . "</p>"; 
echo "<p><label>Scented perfume wise:</label>" . $Scented . "</p>"; 
echo "<p><label>Smoke:</label>" . $Smoker . "</p>"; 
echo "<p><label>Review for:</label>" . $Review_For . "</p>";  

echo "<p><label>Made session:</label>" . $Made_Session . "</p>"; 
echo "<p><label>Again:</label>" . $Again . "</p>";  

echo "<p><label>Recommend this ASP:</label>" . $Recommend . "</p>"; ; 
echo "<p><label>Username:</label>" . $Username . "</p>"; 
if($Display_Email == "no") {
echo "<p><label>Email:</label>" . $Email . "</p>";
} 
echo "<p><label>Frequency:</label>" . $Frequent . "</p>"; 
echo "<p><label>How long have you been in hobby:</label>" . $How_Long . "</p>"; 
echo "<p><label>Activities:</label>". $Activities . "</p>";
echo "<p><label>Rating:</label>". $Rating . "</p>";

in http://scasp.com/testing/show_review.php?ID=35
For some reason, why does only the date show up and not them all like the are suposed to?

ashwin

use this query
$query = "SELECT * FROM REVIEW WHERE ID = $ID";

bradgrafelman

If you want to make sure MySQL knows what's a column name, use backticks (I believe double quotes work as well, but I'm not sure):

$query = "SELECT * FROM REVIEW WHERE `ID` = $ID";

or even:

$query = "SELECT * FROM `REVIEW` WHERE `ID` = $ID";

lukeurtnowski

I changed my query to

 $query = "SELECT * FROM REVIEW WHERE `ID` = $ID";

and nothing seemed to happen?

bradgrafelman

Okay, so echo that query out, copy and paste the query into something such as phpMyAdmin (or the MySQL CLI, or whatever you have available to you) and see what's returned.

lukeurtnowski

k ran this query in phpmyadmin
SELECT * FROM REVIEW WHERE ID = 35
and this is what I got (attachment)

rane500

You're not fetching the returned row.

$query = "SELECT * FROM REVIEW WHERE 'ID' = $ID";
$handle = mysql_query($query) or die("Error: " . mysql_error()); //Do the query
$result = mysql_fetch_assoc($handle);

Also...for completeness and safety's sake, consider:
a) Verify you're getting what you think you're getting from the $_GET. If you're not using magic_quotes, run addslashes() on it.
b) Even numerical values should technically be enclosed in single quotes when querying a database.