[RESOLVED] Counting hours.

Teach

Hello!
I hope you can help me please, although I am assuming this is rather difficult.

I have a Rota Submission page, which allows staff members to submit changes in rota, detailing their hours (start and finish), with additional hours if they're doing shifts, or an option for not being online at all.

This is then processed by a PHP mailer and put in an understandable manner, but we want to enhance that.

We want to do 3 things...which include the following:

At the moment, there is no validation of the hours. We want to ensure that the times are submitted with HH:MM (hour then : then minute), for consistency. This only needs to happen when something is filled in though, as none of these fields are *REQUIRED* ... I don't know if that's a bit more difficult.

Additionally, at the moment the [ ] box appears where "Not online" appears if it's selected. Is it possible for that to only appear when that part is ticked, instead of all the time? Likewise, the -> parts which split the hours appear even if things aren't entered, as nothing is required.
To explain a bit further, if I only gave hours in the first start and finish, I would get:
```
Sunday:............ 18:00 -> 23:00,  ->  [  ]
```
(Where the second -> and aren't needed).
If I put no hours but only ticked not online, I would get:
```
Tuesday:...........  -> ,  ->  [ Not online ]
```
(Where the -> , and -> aren't needed...

The "big one" - so no problem if this cannot be done. If hours are put in, either in the main or additional hours, is it possible to count how many hours there are in between? For example, if 13:00 as a start time, and 17:00 was the finish time, is it possible to have a new [ Total hours: X ] at the end of each day's line? For example ... if on a Monday 13:00 and 17:00 were entered in the main section, it say "Total hours: 4". However, if hours are given in the main AND additional area, it to count both to give one total?

I really hope I've been clear in my relaying of information here, and I really appreciate any help!

The code (HTML) is:

<table class="forms" cellpadding="5" cellspacing="0" border="0">
<tr>
  <td class="bg">&nbsp;</td>
  <td class="bg"><strong>Start:</strong></td>
  <td class="bg"><strong>Finish:</strong></td>
  <td class="bg">&nbsp;</td>
  <td colspan="2" class="bg"><strong>Additional:</strong></td>
  <td class="bg"><strong>Not online:</strong></td>
</tr>

<tr>
  <td class="details"><strong>Sun:</strong></td>
  <td class="details"><input type="text" name="SUNDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="SUNDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="SUNDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="SUNDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="SUNDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Mon:</strong></td>
  <td class="details"><input type="text" name="MONDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="MONDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="MONDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="MONDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="MONDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Tue:</strong></td>
  <td class="details"><input type="text" name="TUESDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="TUESDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="TUESDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="TUESDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="TUESDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Wed:</strong></td>
  <td class="details"><input type="text" name="WEDNESDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="WEDNESDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="WEDNESDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="WEDNESDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="WEDNESDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Thu:</strong></td>
  <td class="details"><input type="text" name="THURSDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="THURSDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="THURSDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="THURSDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="THURSDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Fri:</strong></td>
  <td class="details"><input type="text" name="FRIDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="FRIDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="FRIDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="FRIDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="FRIDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Sat:</strong></td>
  <td class="details"><input type="text" name="SATURDAY1-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="SATURDAY1-FINISH" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="SATURDAY2-START" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="SATURDAY2-FINISH" size="6" maxlength="32" /></td>
  <td class="details"><input name="SATURDAY-NOTONLINE" type="checkbox" class="noborder" value="Not online" /></td>
</tr>
</table>

Whereas the mailer part is:

$msg .= "Sunday:............ ".$_POST['SUNDAY1-START']." -> ".$_POST['SUNDAY1-FINISH'].", ".$_POST['SUNDAY2-START']." -> ".$_POST['SUNDAY2-FINISH']." [ ".$_POST['SUNDAY-NOTONLINE']." ]\n";
$msg .= "Monday:............ ".$_POST['MONDAY1-START']." -> ".$_POST['MONDAY1-FINISH'].", ".$_POST['MONDAY2-START']." -> ".$_POST['MONDAY2-FINISH']." [ ".$_POST['MONDAY-NOTONLINE']." ]\n";
$msg .= "Tuesday:........... ".$_POST['TUESDAY1-START']." -> ".$_POST['TUESDAY1-FINISH'].", ".$_POST['TUESDAY2-START']." -> ".$_POST['TUESDAY2-FINISH']." [ ".$_POST['TUESDAY-NOTONLINE']." ]\n";
$msg .= "Wednesday:......... ".$_POST['WEDNESDAY1-START']." -> ".$_POST['WEDNESDAY1-FINISH'].", ".$_POST['WEDNESDAY2-START']." -> ".$_POST['WEDNESDAY2-FINISH']." [ ".$_POST['WEDNESDAY-NOTONLINE']." ]\n";
$msg .= "Thursday:.......... ".$_POST['THURSDAY1-START']." -> ".$_POST['THURSDAY1-FINISH'].", ".$_POST['THURSDAY2-START']." -> ".$_POST['THURSDAY2-FINISH']." [ ".$_POST['THURSDAY-NOTONLINE']." ]\n";
$msg .= "Friday:............ ".$_POST['FRIDAY1-START']." -> ".$_POST['FRIDAY1-FINISH'].", ".$_POST['FRIDAY2-START']." -> ".$_POST['FRIDAY2-FINISH']." [ ".$_POST['FRIDAY-NOTONLINE']." ]\n";
$msg .= "Saturday:.......... ".$_POST['SATURDAY1-START']." -> ".$_POST['SATURDAY1-FINISH'].", ".$_POST['SATURDAY2-START']." -> ".$_POST['SATURDAY2-FINISH']." [ ".$_POST['SATURDAY-NOTONLINE']." ]\n\n";

barand

I renamed your form fields to make the processing simpler

<form method='post'>
<table class="forms" cellpadding="5" cellspacing="0" border="0">
<tr>
  <td class="bg">&nbsp;</td>
  <td class="bg"><strong>Start:</strong></td>
  <td class="bg"><strong>Finish:</strong></td>
  <td class="bg">&nbsp;</td>
  <td colspan="2" class="bg"><strong>Additional:</strong></td>
  <td class="bg"><strong>Not online:</strong></td>
</tr>

<tr>
  <td class="details"><strong>Sun:</strong></td>
  <td class="details"><input type="text" name="start1[0]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[0]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[0]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[0]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[0]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Mon:</strong></td>
  <td class="details"><input type="text" name="start1[1]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[1]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[1]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[1]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[1]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Tue:</strong></td>
  <td class="details"><input type="text" name="start1[2]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[2]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[2]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[2]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[2]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Wed:</strong></td>
  <td class="details"><input type="text" name="start1[3]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[3]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[3]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[3]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[3]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Thu:</strong></td>
  <td class="details"><input type="text" name="start1[]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[4]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[4]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[4]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[4]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Fri:</strong></td>
  <td class="details"><input type="text" name="start1[5]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[5]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[5]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[5]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[5]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>

<tr>
  <td class="details"><strong>Sat:</strong></td>
  <td class="details"><input type="text" name="start1[6]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish1[6]" size="6" maxlength="32" /></td>
  <td class="details">&amp;</td>
  <td class="details"><input type="text" name="start2[6]" size="6" maxlength="32" /></td>
  <td class="details">-> <input type="text" name="finish2[6]" size="6" maxlength="32" /></td>
  <td class="details"><input name="notonline[6]" type="checkbox" class="noborder" value="Not online" /></td>
</tr>
</table>
<input type="submit" name="submit" value="Submit">
</form>

Now the processing can be done inside a loop, processing each day

<?php

function totalHours ($d)  {

$s1 = $_POST['start1'][$d] ? strtotime('2006-01-01 '.$_POST['start1'][$d].':00') : 0;
$s2 = $_POST['start2'][$d] ? strtotime('2006-01-01 '.$_POST['start2'][$d].':00') : 0;
$f1 = $_POST['finish1'][$d] ? strtotime('2006-01-01 '.$_POST['finish1'][$d].':00') : 0;
$f2 = $_POST['finish2'][$d] ? strtotime('2006-01-01 '.$_POST['finish2'][$d].':00') : 0;
$totmins = floor((($f1 + $f2) - ($s1 + $s2))/60);
return sprintf('%2d:%02d', floor($totmins/60), $totmins%60);
}

$days = array('Sunday','Monday','Tuesday','Wednesday','Thursday','Friday','Saturday');
if (isset($_POST['start1'])) {
	for ($d=0; $d < 7; $d++) {
		if (isset($_POST['notonline'][$d])) {
			$msg .= sprintf('%-23s %s%s', 
				str_pad($days[$d],20,'.'), 'Not online', "\n\n");
		}
		else {
			$msg .= sprintf('%-21s %5s -> %5s,  %5s %s %5s %5s(Total)%s', 
				str_pad($days[$d],20,'.'),
				$_POST['start1'][$d],
				$_POST['finish1'][$d],
				$_POST['start2'][$d],
				$_POST['start2'][$d] ? '->' : '  ',
				$_POST['finish2'][$d],
				totalHours($d), 
				"\n\n"
				);
		}
	}
}


echo '<pre>', $msg, '</pre>';
?>

No validation in there but easiest to do in javascript and check as each time is entered

Teach

Oh thank you so much! I really appreciate it. No problem about the validation, that's fantastic. 🙂

Do you know if that will work if hours are given, with say non 00 minutes, i.e. 13:30, or 13:45? Would it still count them correctly?

Thanks!

barand

It should work with any valid HH:MM values and so long as finish times > start times

Teach

Ok thanks. Just tested this and it is working perfectly - cannot thank you enough! 🙂

One last question though, for the line:

sprintf('%-21s %5s -> %5s,  %5s %s %5s %5s(Total)%s',

it makes the lines appear for example as:

Monday.............. 12:00 -> 13:00, 17:00 -> 22:00 6:00(Total)

Can it appear as:

Monday.............. 12:00 -> 13:00, 17:00 -> 22:00 [ Total: 6:00 ]

And for ones with only one set of times (not the additional):

Wednesday.......... 17:00 -> 18:00 [ Total: 1:00 ]

Additionally, stupid question I'm sure, but each year will I need to change the 2006 to 2007 etc, on "2006-01-01" ? 🙂

Lastly, to be totally cheeky (haha!) I wonder if it's possible for a new line under all the days of "Total hours: X" to show how many total hours there were per day, all added up? no problem if this is a lot of work, I don't see them being identified easily so absolutely no problem. I truly appreciate the work you've already done!

Thanks!

barand

Changing that line to

$msg .= sprintf('%-21s %5s -> %5s,  %5s %s %5s [ Total: %5s ]%s',

will give

Sunday..............  09:00 -> 10:00,  15:00 -> 20:00 [ Total:  6:00 ]

Monday..............  09:00 -> 15:00,                 [ Total:  6:00 ]

I'll have a look at the week's total hours

barand

Teach wrote:
Additionally, stupid question I'm sure, but each year will I need to change the 2006 to 2007 etc, on "2006-01-01" ? 🙂
Thanks!

No, that can stay as it is. It's just to create a valid date/time string

2006-01-01 HH:MM:00

from the entered time (HH:MM) to convert it to seconds so the time totals can be calculated. Any valid date would do.

Teach

Ok, fab. 😃

barand

Revised processing code to show weekly totals

<?php

function totalHours ($d, &$weektot)  {

$s1 = $_POST['start1'][$d] ? strtotime('2006-01-01 '.$_POST['start1'][$d].':00') : 0;
$s2 = $_POST['start2'][$d] ? strtotime('2006-01-01 '.$_POST['start2'][$d].':00') : 0;
$f1 = $_POST['finish1'][$d] ? strtotime('2006-01-01 '.$_POST['finish1'][$d].':00') : 0;
$f2 = $_POST['finish2'][$d] ? strtotime('2006-01-01 '.$_POST['finish2'][$d].':00') : 0;
$totmins = floor((($f1 + $f2) - ($s1 + $s2))/60);
$weektot += $totmins;
return sprintf('%2d:%02d', floor($totmins/60), $totmins%60);
}

$days = array('Sunday','Monday','Tuesday','Wednesday','Thursday','Friday','Saturday');
$weektot = 0;
if (isset($_POST['start1'])) {
	for ($d=0; $d < 7; $d++) {
		if (isset($_POST['notonline'][$d])) {
			$msg .= sprintf('%-23s %s%s', 
				str_pad($days[$d],20,'.'), 'Not online', "\n\n");
		}
		else {
			$msg .= sprintf('%-21s %5s -> %5s,  %5s %s %5s [ Total: %5s ]%s', 
				str_pad($days[$d],20,'.'),
				$_POST['start1'][$d],
				$_POST['finish1'][$d],
				$_POST['start2'][$d],
				$_POST['start2'][$d] ? '->' : '  ',
				$_POST['finish2'][$d],
				totalHours($d, $weektot), 
				"\n\n"
				);
		}
	}
	$msg .= sprintf('%53s ________________%s', '', "\n\n");
	$msg .= sprintf('%53s [ Total:%3d:%02d ]%s', 
					str_pad('Weekly hours',53,'.'), 
					floor($weektot/60), 
					$weektot%60,
					"\n\n");
}


echo '<pre>', $msg, '</pre>';
?>

Teach

thank you so much, we're now using this and it's working amazingly!

One small problem though, it's no big problem though, but I just wondered if you had an easy fix.

With the hours, it's quite easy to confuse it.

For example, two instances of one member who tried to confuse it because it was new (bless...but it did show us that it could get confused, like us! haha)...

Wednesday.......... 17:00 -> 18:58, 23:00 -> 00:00 [ Total: -22:-2 ]

and:

Sunday............. 13:00 -> 22:03, 23:00 -> 27:00 [ Total: -315590:-58 ]

I guess it doesn't accept 00:00 as midnight, and obviously 27:00 doesn't exist.

Absolutely no problem if these are hard to deal with, I can put notes for people to use 24:00 as midnight etc.

Thanks again. 🙂

barand

New function to allow for time durations spanning midnight

function totalHours ($d, &$weektot)  {

$s1 = $_POST['start1'][$d] ? strtotime('2006-01-01 '.$_POST['start1'][$d].':00') : 0;
$s2 = $_POST['start2'][$d] ? strtotime('2006-01-01 '.$_POST['start2'][$d].':00') : 0;
$f1 = $_POST['finish1'][$d] ? strtotime('2006-01-01 '.$_POST['finish1'][$d].':00') : 0;
$f2 = $_POST['finish2'][$d] ? strtotime('2006-01-01 '.$_POST['finish2'][$d].':00') : 0;
$totmins = floor((($f1 + $f2) - ($s1 + $s2))/60);
if ($totmins < 0) $totmins += 24*60;
$weektot += $totmins;
return sprintf('%2d:%02d', floor($totmins/60), $totmins%60);
}

Midnight is 00:00. Now, if it calculates a negative total it adds 24hours.

Sunday..............  23:00 -> 01:00,                 [ Total:  2:00 ]

Teach

I truly cannot thank you enough. Perfect!
🙂