UNLINK command HELP!!!

digipit

Here's the code I've got for deleting a record in the MySQL database as well as the image associated with it on the server. The portion that deletes from the database is working perfectly, but I can't get it to delete the image off the server. This is a picture gallery I've created for a client. Getting it to delete the actual image is the last thing keeping me from finishing the project. All and any help is appreciated.

<?
$db_user_name = "**";
$db_database_name = "";
$db_password = "***";

$picture_id = $GET['picture_id'];
$picture_name = $GET['picture_name'];
$picture_url = $title . '.' . $_GET['picture_url'];

mysql_connect( 'localhost', $db_user_name, $db_password) or die('<br>Failed connect: ' . mysql_error());

mysql_select_db($db_database_name) or die('<br>Failed database: ' . mysql_error());

mysql_query("DELETE FROM pg_gallery WHERE picture_id = $picture_id") or die('<br>Failed query: ' . mysql_error());

mysql_close();

unlink('../../images/gallery/'.$picture_url);

echo 'File removed successfully.';
?>

weekender

Try using file_exists to check the file path is correct

echo ('../../images/gallery/'.$picture_url) ? 'File found!' : 'File not found!';

Also I think you have a serious loophole in your code. You've not sanitised your input. The $picture_url is from a GET (ie a url query string). Think about what happens if i load the following page into my browser...

script.php?picture_url=../../../imagename

Hope that helps, Adam

digipit

I'm a complete novice and don't really understand. What would happen? Could an outsider manipulate something on my server?

digipit

This is what I got when I ran the code: "File found!". That means it's valid correct? Or am I missing something?

weekender

Potentially people could cause your script to generate the wrong file.

Are you getting any error from the unset function? You might need to chmod the directory that your pictures are in, to give the script access to delete each file.