My Newsscript won't work... :(

[blu3]

I'm now working on my own website. I want to creating a newssystem, wich should read and output alle contents in own tables on my webtemplate.

I created a class file, where the function of this script are.

<?php
class tpl {
 var $tpl_dir="./templates/";

 function get_news($get) {
  $get1=fopen($this->tpl_dir.$get.".tpl","r");
  $get2=fread($get1,filesize($this->tpl_dir.$get.".tpl"));

  $newsbit1=fopen($this->tpl_dir."newsbit.tpl","r");
  $newsbit2=fread($get1,filesize($this->tpl_dir."newsbit.tpl"));

  $get3=str_replace("{newsbit}",$newsbit2,$get2);

  mysql_connect(MYSQL_HOST,MYSQL_USER,MYSQL_PASS) OR die(mysql_error());
  mysql_select_db(MYSQL_DATABASE) OR die(mysql_error());

  $sql="SELECT title, date, content FROM hp_news ORDER BY date DESC;";
  $sql_query=mysql_query($sql) OR die(mysql_error());
  if(mysql_num_rows($sql_query)) {
  $row = mysql_fetch_assoc($sql_query);
  foreach ($row as $db => $value) {
   $get3=str_replace("{newstitle}",$db['title'],$get3);
   $get3=str_replace("{newsdate}",$db['date'],$get3);
   $get3=str_replace("{newscontent}",$db['content'],$get3);
  }

  $head1=fopen($this->tpl_dir."head.tpl","r");
  $head2=fread($head1,filesize($this->tpl_dir."head.tpl"));

  $get3=str_replace("{head}",$head2,$get2);

  $menu1=fopen($this->tpl_dir."menu.tpl","r");
  $menu2=fread($menu1,filesize($this->tpl_dir."menu.tpl"));

  $get3=str_replace("{menu}",$menu2,$get3);

  $headinclude1=fopen($this->tpl_dir."headinclude.tpl","r");
  $headinclude2=fread($headinclude1,filesize($this->tpl_dir."headinclude.tpl"));

  $get3=str_replace("{headinclude}",$headinclude2,$get3);

  $footer1=fopen($this->tpl_dir."footer.tpl","r");
  $footer2=fread($footer1,filesize($this->tpl_dir."footer.tpl"));

  $get3=str_replace("{footer}",$footer2,$get3);

  print $get3;

  fclose($get1);
  fclose($head1);
  fclose($menu1);
  fclose($headinclude1);
  fclose($footer1);
  fclose($newsbit1);
  }
 }
}
?>

There must be something wrong with the foreach() Code. As output is only the template with {newsbit}. This means, that the str_replace code with {newsbit} won't work. Later I got a idea and I used print for the output before the foreach code, and {newsbit} was replaced.

So I think now, it's foreach fault! 😃

Hmm... So I search the bug, and I hope anyone could help me.

Thank...

Sorry, my english is bad :3

[Masna]

The way you're using the foreach loop doesn't really make sense. In that specific loop, $db is the value of each key in your array. A key can't consist of more keys, only a value. The value can consist of an array, in which case, more keys. Try replacing all of those $db['key']'s with simply $value. Maybe, if that doesn't work, just replace the $db's themselves with $value. I'm not exactly sure what's going on here, but give that a shot.

[blu3]

It won't work. :/

Could there something wrong with the replace? Because it's only shows {newsbit} :bemused:

[Jack_McSlay]

i believe where it reads

  $newsbit1=fopen($this->tpl_dir."newsbit.tpl","r");
  $newsbit2=fread($get1,filesize($this->tpl_dir."newsbit.tpl"));

it should be

  $newsbit1=fopen($this->tpl_dir."newsbit.tpl","r");
  $newsbit2=fread($newsbit1,filesize($this->tpl_dir."newsbit.tpl"));

also where it reads

  $get3=str_replace("{head}",$head2,$get2);

and replace it with
I believe it should be

  $get3=str_replace("{head}",$head2,$get3);

be careful with consecutive replaces. I think the best is just to take a template and replace it with
and replace always the same variable to avoid mistakes (in your script, that would mean replace every $get3 with $get2)

another advice... instead of doing consecutive uses of fopen(), fread(), filesize ()and fclose(), it's easier just to use file() and join(), fopen is necessary only when using advanced read/write functions.

you could use it like this:

    $newsbit2=join('',file($this->tpl_dir."newsbit.tpl"));

edit:
I've noticed your database interaction is all wrong. you should take off the entire

  if(mysql_num_rows($sql_query)) {
  $row = mysql_fetch_assoc($sql_query);
  foreach ($row as $db => $value) {
   $get3=str_replace("{newstitle}",$db['title'],$get3);
   $get3=str_replace("{newsdate}",$db['date'],$get3);
   $get3=str_replace("{newscontent}",$db['content'],$get3);
  } 

and replace with

  if(mysql_num_rows($sql_query)) {
    $db = mysql_fetch_assoc($sql_query);
    $search = array ("{newstitle}","{newsdate}","{newscontent}");
    $replacement = array ($db['title'],$db['date'],$db['content']);

$get3=str_replace($search,$replacement,$get3);
   } 

[blu3]

Hmm... Okay. If I'll write a new Script, I'll use it.

So, now I changed $newsbit2=fread($get1,filesize($this->tpl_dir."newsbit.tpl")); to $newsbit2=fread($newsbit1,filesize($this->tpl_dir."newsbit.tpl"));

The {newsbit} don't replace. :/

That's my complete Code:

 function get_news($get) {
  $get1=fopen($this->tpl_dir.$get.".tpl","r");
  $get2=fread($get1,filesize($this->tpl_dir.$get.".tpl"));

  $newsbit1=fopen($this->tpl_dir."newsbit.tpl","r");
  $newsbit2=fread($newsbit1,filesize($this->tpl_dir."newsbit.tpl"));

  $get3=str_replace("{newsbit}",$newsbit2,$get2);

  mysql_connect(MYSQL_HOST,MYSQL_USER,MYSQL_PASS) OR die(mysql_error());
  mysql_select_db(MYSQL_DATABASE) OR die(mysql_error());

  $sql="SELECT title, date, content FROM hp_news ORDER BY date DESC;";
  $sql_query=mysql_query($sql) OR die(mysql_error());
  if(mysql_num_rows($sql_query)) {
  $row = mysql_fetch_assoc($sql_query);
  foreach ($row as $db => $value) {
   $get3=str_replace("{newstitle}",$value['title'],$get3);
   $get3=str_replace("{newsdate}",$value['date'],$get3);
   $get3=str_replace("{newscontent}",$value['newscontent'],$get3);
  }

  $head1=fopen($this->tpl_dir."head.tpl","r");
  $head2=fread($head1,filesize($this->tpl_dir."head.tpl"));

  $get3=str_replace("{head}",$head2,$get2);

  $menu1=fopen($this->tpl_dir."menu.tpl","r");
  $menu2=fread($menu1,filesize($this->tpl_dir."menu.tpl"));

  $get3=str_replace("{menu}",$menu2,$get3);

  $headinclude1=fopen($this->tpl_dir."headinclude.tpl","r");
  $headinclude2=fread($headinclude1,filesize($this->tpl_dir."headinclude.tpl"));

  $get3=str_replace("{headinclude}",$headinclude2,$get3);

  $footer1=fopen($this->tpl_dir."footer.tpl","r");
  $footer2=fread($footer1,filesize($this->tpl_dir."footer.tpl"));

  $get3=str_replace("{footer}",$footer2,$get3);

  print $get3;

  fclose($get1);
  fclose($head1);
  fclose($menu1);
  fclose($headinclude1);
  fclose($footer1);
  fclose($newsbit1);
  }
 }

What's now wrong?

I'll try your edits. :S

[Jack_McSlay]

 $get3=str_replace("{head}",$head2,$get2);

this line is wrong, I pointed it out on the previous post but it seems you let it slip

[blu3]

I changed, but still showing {newsbit}

:S