retrieving images from databank

[katmorgenstern]

Hi
I am pretty new to php and mysql. I managed to create a database that stores some text and images. It uploaded well into the database and the database seems to be storing the images in the correct format. However, when I try to download the files I get all but the images. The images are downloaded in source code! This is the download query I have been running:

<?php
mysql_connect("localhost", "user","pass")
or die("Could not connect to database.");

mysql_select_db("images") or die("Cannot select database");

if(!empty($GET["query"]))
{
$query = stripslashes($GET["$query"]);
}
else
{
$query = "SELECT * FROM pictures";
}
$result = mysql_query($query)
or
die (mysql_error() );

$number_cols = mysql_numfields($result);
echo "<b>Query: $query</b>",
'<table border="1">',
'<tr align="center">';

for ($i=0; $i < $number_cols; ++$i)
{
echo '<th>' .mysql_field_name($result, $i). "</th>\n";
}
echo "</tr>\n";

while($row = mysql_fetch_row($result) )
{
echo "<tr>\n";
foreach($row as $field)
{
echo '<td>' . (is_null($field) ? 'NULL' : $field) . "</td>\n";
}
echo "</tr>\n";
}
echo '</table>';
?>

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
<input type="text" name="query" size ="50" value="<?php echo $query; ?>"><br />
<input type="submit" />

</form>

What am I doing wrong?
I thought it might be to do with the strip slashes function (after reading another post here). smart quotes are enabled on my system. The text downloads just as it should, its only the image file that does not display properly.
Any help will be greatly appreciated.
Thanks
Kat

[bastien]

here is an explanation of what you need to do

[katmorgenstern]

Thanks Bastien
I have tried out your code and after some fiddeling around managed to get partial success - the database now spits out the description text and attempts to get the images, but they are only displayed as boxes with red crosses in them. What am I doing wrong now?
Thanks for your help, much appreciated
Kat

[bastien]

post the code

[katmorgenstern]

Hi Bastien
I created the database with the file exactly as posted and created an upload script accordingly:

<?php
if($POST['sent'])
{
if(!is_uploaded_file($FILES['bin_data']['tmp_name']))
{$error="<br>No file has been uploaded";}
else
{

if($_FILES['bin_data']['size']>1000000)
{$error.="<br>The file is too big;";}
}//ende ELSE no file has been uploaded
if(!$error)
{

$link = mysql_connect("localhost", "root", "pass");
mysql_select_db("images", $link);
$datei=fopen($FILES['bin_data']['tmp_name'], 'rb');
$data=addslashes(fread( $datei, $FILES['bin_data']['size']));
$sql=" INSERT INTO binary_data (description, filename, filesize, filetype)
values ('".$POST['description']."' , '".$POST['filename']."' , '".$POST['size']."' ,'".$FILES['bin_data']['type']."')";
if(!mysql_query($sql, $link))
{$fehler.="<br>upload failed due to database failure, please try again later<br>";}
}
if($fehler){echo "<h2><font color=\"red\">".$fehler."</font></h2>";}
else
{
echo "<h2><font color=\"blue\">file upload has been successful</font></h2>";
unset($POST['description']);
unset($POST['filename']);
unset($POST['filesize']);
}
}//end $POST['sent']
?>
<h1>file upload</h1>
<form action="<?php echo $SERVER['PHP_SELF']; ?>" method="post" enctype="multipart/form-data">
<input type="hidden" name="sent" value="1" />
<p>Filename</p>
<input type="text" name="filename" size="50" value="<?php echo $POST['filename'] ; ?>"><br>
<p>Description</p>
<input type="text" name="description" size="50" value="<?php echo $_POST['description']; ?>"> <br />

<p>Choose file</p>
<input type="file" name="bin_data" size="50" /><br />
<br />
<input type="submit" value="submit" /><br />
<input type="reset" value="reset" />
</form>

here is the show_images.php

<?php

mysql_connect("localhost", "root", "pass") or
die ("Could not connect to database.");
mysql_select_db("images") or
die ("Cannot select database.");

//check to see if the id is passed
if(isset($GET['id']))
{
$id=$GET['id'];

$query = "select bin_data, filetype from binary_data where id=$id"; 
//echo $query; 
$result = mysql_query($query) or
	die(mysql_error();

$row = mysql_fetch_array($result); 
  { 
   $data = $row['bin_data']; 
   $type = $row['filetype']; 
  } 
  if ($type=="pjpeg") $type = "jpeg"; 
		if ($type=="gif") $type = "gif";
  Header( "Content-type: $type"); 
  echo $data; 

}
?>

and the show_desc.php

<?php
require("connect.php");

// you may have to modify login information for your database server

$query = "select description, id from binary_data ";
$result = mysql_query($query);

while ($rows = MYSQL_FETCH_ARRAY($result)) {
echo $rows['description'];
echo "<br><br>";
echo "<img src=\"show_image.php?id=".$rows['id']."\">\n";
}

I have a connect.php and that seems to be working fine, The script accesses the correct table, but only displays the images as boxes with red crosses.

Any help greatly appreciated, theanks!!!
Kat