Cannot sent headers

jojojo

I try to sent header to thankyou.php but there's an error:

Warning: Cannot modify header information - headers already sent by (output started at C:\wamp\www\form1.php:10) in C:\wamp\www\form1.php on line 78

What's the problem?

Jack_McSlay

that means you already echoed something before sending the header. sending header information must be done before any echo command, otherwise PHP will use stantard headers and continue execution.

halojoy

means that an output, header sent was in LINE 10 of form.php
while something in LINE 78 wanted to be the FIRST to send a header (an html display output)

can be a 'session_start()' at line 78 or some other function that needs to be run
before any text is output in browser
can also be something with COOKIE

that is why is good idea to put session_start() in very beginning of script
if this is possible

jojojo

Ok. Here's my code cause I don't know where to edit the code:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

<body>
<?php

if (isset($_POST["submit"]))
{

 if (strlen($_POST["name"]) != "")
 {
  $name = $_POST["name"];
 }
 else
 {
  $name = false;
  echo "Please enter a your name in right format<br>";
 }

 if(strlen($_POST["email"]) != "")
 {
  $email = $_POST["email"];
 }
 else
 {
  $email = false;
  echo "Please enter your email in right format<br>";
 }

  if (strlen($_POST["username"]) != "")
 {
  $username = $_POST["username"];
 }
 else
 {
  $username = false;
  echo "Please enter a your username in right format<br>";
 }

  if (strlen($_POST["pass"]) != "")
 {
  $pass = $_POST["pass"];
 }
 else
 {
  $pass = false;
  echo "Please enter a your password in right format<br>";
 }

  if (strlen($_POST["pass1"]) != "")
 {
  if ($_POST["pass1"] == $_POST["pass"])
  {
   $pass1 = $_POST["pass1"];
  }
  else
  {
   $pass1 = false;
   echo "Your confirmed password did not match the password you've entered<br>";
  }
 }
  else
  {
   echo "Please confirm your password";
  }
}

if ($name && $email && $username && $pass && $pass1)
{
 header ('Location: thankyou.php');
 exit();
}


?>
<p>Enter your information below:</p>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
  <table width="200" border="1">
    <tr>
      <td>Name</td>
      <td><input name="name" type="text" id="name"></td>
    </tr>
    <tr>
      <td>Email Address </td>
      <td><input name="email" type="text" id="email"></td>
    </tr>
    <tr>
      <td>Username</td>
      <td><input name="username" type="text" id="username"></td>
    </tr>
    <tr>
      <td>Password</td>
      <td><input name="pass" type="password" id="pass"></td>
    </tr>
    <tr>
      <td>Confirm Password </td>
      <td><input name="pass1" type="password" id="pass1"></td>
    </tr>
  </table>
  <p>
    <input name="submit" type="submit" id="submit" value="Submit">
  </p>
</form>
<p>&nbsp;</p>
</body>
</html>

This is the thankyou.php page:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

<body>
<?php
echo "Thank you for registering with us";
?>
</body>
</html>

DESIGNGRAPHY

thankyou.php with doctype is not important! I suggest remove thankyou.php.\

oops, you updated the code:

change header(include:thankyou...) to echo "Thank you for registering with us";

Houdini

Remove these lines

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

<body>

Then try you code.

bogu

Bad move

if ($name && $email && $username && $pass && $pass1)
{
    header ('Location: thankyou.php');
    exit();
}

this need to be befor u output anything ...
Something like this, I changed your code ...

<?php
$mess = "";
if (isset($_POST["submit"]))
{

 if (strlen($_POST["name"]) != "")
 {
  $name = $_POST["name"];
 }
 else
 {
  $name = false;
  $mess.= "Please enter a your name in right format<br>";
 }

 if(strlen($_POST["email"]) != "")
 {
  $email = $_POST["email"];
 }
 else
 {
  $email = false;
  $mess.= "Please enter your email in right format<br>";
 }

  if (strlen($_POST["username"]) != "")
 {
  $username = $_POST["username"];
 }
 else
 {
  $username = false;
  $mess.= "Please enter a your username in right format<br>";
 }

  if (strlen($_POST["pass"]) != "")
 {
  $pass = $_POST["pass"];
 }
 else
 {
  $pass = false;
  $mess.= "Please enter a your password in right format<br>";
 }

  if (strlen($_POST["pass1"]) != "")
 {
  if ($_POST["pass1"] == $_POST["pass"])
  {
   $pass1 = $_POST["pass1"];
  }
  else
  {
   $pass1 = false;
   $mess.= "Your confirmed password did not match the password you've entered<br>";
  }
 }
  else
  {
   $mess.= "Please confirm your password";
  }
}

if ($name && $email && $username && $pass && $pass1)
{
 header ('Location: thankyou.php');
 exit();
}


?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

<body>
<?=$mess;?>
<p>Enter your information below:</p>
<form name="form1" method="post" action="">
  <table width="200" border="1">
    <tr>
      <td>Name</td>
      <td><input name="name" type="text" id="name"></td>
    </tr>
    <tr>
      <td>Email Address </td>
      <td><input name="email" type="text" id="email"></td>
    </tr>
    <tr>
      <td>Username</td>
      <td><input name="username" type="text" id="username"></td>
    </tr>
    <tr>
      <td>Password</td>
      <td><input name="pass" type="password" id="pass"></td>
    </tr>
    <tr>
      <td>Confirm Password </td>
      <td><input name="pass1" type="password" id="pass1"></td>
    </tr>
  </table>
  <p>
    <input name="submit" type="submit" id="submit" value="Submit">
  </p>
</form>
<p>&nbsp;</p>
</body>
</html>

If u want your form to return in the same page just leave the action of the form empty (see your code modified by me) u dont need this:

action="<?php echo $_SERVER['PHP_SELF']; ?>"

halojoy

It is a good idea to separate HTML from PHP
in your page, you have
1. HTML output
2. PHP code
3. HTML again

while usually
we put all PHP code first
after this we put ALL HTML

==================================

first Headers are sent by your HTML in beginning
( all writing to browser needs a header sent
even if ytou only had put word 'hello' in first line of your page )

than comes later the other header with error
( you cant send 2 headers in one page )
if ($name && $email && $username && $pass && $pass1)
{
header ('Location: thankyou.php');
exit();
}

Try something like this instead:

<?php

if (isset($_POST["submit"]))
{

 if (strlen($_POST["name"]) != "")
 {
  $name = $_POST["name"];
 }
 else
 {
  $name = false;
  echo "Please enter a your name in right format<br>";
 }

 if(strlen($_POST["email"]) != "")
 {
  $email = $_POST["email"];
 }
 else
 {
  $email = false;
  echo "Please enter your email in right format<br>";
 }

  if (strlen($_POST["username"]) != "")
 {
  $username = $_POST["username"];
 }
 else
 {
  $username = false;
  echo "Please enter a your username in right format<br>";
 }

  if (strlen($_POST["pass"]) != "")
 {
  $pass = $_POST["pass"];
 }
 else
 {
  $pass = false;
  echo "Please enter a your password in right format<br>";
 }

  if (strlen($_POST["pass1"]) != "")
 {
  if ($_POST["pass1"] == $_POST["pass"])
  {
   $pass1 = $_POST["pass1"];
  }
  else
  {
   $pass1 = false;
   echo "Your confirmed password did not match the password you've entered<br>";
  }
 }
  else
  {
   echo "Please confirm your password";
  }
}

if ($name && $email && $username && $pass && $pass1)
{
 header ('Location: thankyou.php');
 exit();
}

?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

<body>
<p>Enter your information below:</p>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
  <table width="200" border="1">
    <tr>
      <td>Name</td>
      <td><input name="name" type="text" id="name"></td>
    </tr>
    <tr>
      <td>Email Address </td>
      <td><input name="email" type="text" id="email"></td>
    </tr>
    <tr>
      <td>Username</td>
      <td><input name="username" type="text" id="username"></td>
    </tr>
    <tr>
      <td>Password</td>
      <td><input name="pass" type="password" id="pass"></td>
    </tr>
    <tr>
      <td>Confirm Password </td>
      <td><input name="pass1" type="password" id="pass1"></td>
    </tr>
  </table>
  <p>
    <input name="submit" type="submit" id="submit" value="Submit">
  </p>
</form>
<p>&nbsp;</p>
</body>
</html>

mikawhat

I had this problem many times...most times the reason was a simple space before the <?php code... that really sucks... removing those lines mentioned by houdini i think should fix the problem.

bogu

mikawhat wrote:
I had this problem many times...most times the reason was a simple space before the <?php code... that really sucks... removing those lines mentioned by houdini i think should fix the problem.

Is not a good thing to remove thoes lines ...

mikawhat

maybe use an include file with those lines?

bogu

Just moving the hole php tag in the top all what is echoed soulhd be keep in a var that is echo between body tag, just like I modified his script ...

Houdini

Why is that, the file is php not HTML so the document definition and all that is irrelevent. Also the closing html tags are also not needed. The very first <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd"> is output and what is causeing the header to fail. Iran the code with no problem when the lines I mentioned were removed.

bogu

Houdini wrote:
Why is that, the file is php not HTML so the document definition and all that is irrelevent. Also the closing html tags are also not needed. The very first <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd"> is output and what is causeing the header to fail. Iran the code with no problem when the lines I mentioned were removed.

That php file is the only file that output the html code, the DOCTYPE is importent so the browser could know what type of html are u using (HTML 4.01, XHTML ... etc.).

The header was missed place ...

Houdini

You are missing the point ... the script should be PHP not HTML the HTML is totally not needed to process a PHP file that just so happens to generate HTML.
You can output to the browser with this simple program.

<?php
echo "This is PHP";
?>

It will run even though it is not a valid HTML document and that is why all that other is not needed in the script. Take the guys code that is causeing the problem with the header and remove the HTML (that is unnecessary) and it will run perfectly, unless you call it with the extension of .htm or .html It could be named form.php or anything, but not form.html

halojoy

even if I didnt bother to
put all those 'error messages' into a variable $message

like someone told above,
this is the solution to keep <doc type><html> and all this, if this feels right
while keeping all
written output between the <html> </html> tags

in beginning set $message = ''

then for each possible error add
$message .= 'password dont match<br>' and whatever

then in <body>
<?php echo $message; ?>
<form .......>
input here

</body></html>

In this way we have separated PHP code from HTML Output totally
which was my main point.

Because to do so, is good and proper programming style
and will not risk too many headers sent per page.

=========

a sidenote
<?=$mess;?> is bad programming and not recommended
you will discover this one day
when you upload your scripts to server not using php shorttags

script

?>

anyone too lazy to write
<?php
shouldnt code PHP 😃

This is the recommended standard and will WORK AT ANY SERVER

<?php echo $message; ?>

bogu

I didnt sayed it wont work, I just sayed that the way he create his script it wouldnt be wise to remove thoes lines he only need to place them below the php code, like I write it ...

jojojo

Ok. Thanks mate. I've removed the html and it worked.