ismember checkbox value

[SFDonovan]

I have a page that makes edits to values in a table. One of the values is an ismember flag which is a smallint(1). I use the ismember field for access to private pages.

I click on the record to edit and all my fields are popuated including the value of the ismember checkbox. If the value is 1, then the checkbox is checked, else if it is 0 it is not checked.

When I make my edits to the fields and submit the value ismember is reset to 0 and I don't understand why.

My coding is pretty basic as I am learning PHP as a hobby.

Here is my script. Any help is appreciated.

<?php
if ($op == "SaveSoldier") {

$id = intval($_POST['id']);
$rank_id = intval($rank_id);
$unit_id = intval($unit_id);
$weapon_id = intval($weapon_id);
$subunit_id = intval($subunit_id);
$adminunits;
$num_of_adminunits = sizeof($_POST[admin_unit_id]);
$k = 0;
for ($i=0; $i < $num_of_adminunits; $i++) {
	$ifDuplicated = false;
	$test_for_duplication = explode(",",$adminunits);
	if ($_POST[admin_unit_id][$i]) {
		for ($j=0; $j < sizeof($test_for_duplication); $j++) {
			if ($_POST[admin_unit_id][$i] == $test_for_duplication[$j])
				$ifDuplicated = true;
		}
		if (!$ifDuplicated) {
			if ($k > 0)
				$adminunits .= ",";
			$adminunits .= $_POST[admin_unit_id][$i];
			$k++;
		}
	}
}
//		Order in increasing numerical order
	$admin_array = explode(",",$adminunits);
	sort($admin_array);
	$adminunits = "";
	for ($i=0; $i <= sizeof($admin_array); $i++) {
		if ($admin_array[$i] != "")
			$adminunits .= $admin_array[$i] . ",";
	}

$sql = "UPDATE " . $prefix . "_milpacs_members set
	uniform = '$uniform',
	rank_id = '$rank_id',
	ismember = '$ismember',
	flag = '$flag',
	u_name = '$soldierName',
	nukeusername = '$nukeusername',
	location = '$location',
	status = '$status',
	p_mos = '$p_mos',
	unit_id = '$unit_id',
	subunit_id = '$subunit_id',
	adminunits = '$adminunits',
	reports = '$reports',
	position = '$position',
	weapon_id = '$weapon_id',
	enlistment_dt = '$enlistment_dt',
	promotion_dt = '$promotion_dt',
	icq = '$icq',
	email = '$email',
	bio = '$bio'
	WHERE uniqueid ='$id'";
$update = $db->sql_query($sql);
}

// If not saving, load values from database
if ($op != "SaveSoldier") {
	$id = intval($_GET['id']);
	$result = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_members mm
	INNER JOIN (" . $prefix . "_milpacs_units mu) ON (mm.unit_id = mu.unit_id)
	LEFT JOIN " . $prefix . "_milpacs_weapons mw ON (mw.weapon_id = mm.weapon_id)
	WHERE mm.uniqueid ='$id'");
	$info = $db->sql_fetchrow($result);		 
	if (!$result) {
		echo("<p>Error performing query: " . mysql_error() . "</p>");
		exit();
	} else {
		$soldierName = $info['u_name'];
		$nukeusername = $info['nukeusername'];
		$ismember = $info['ismember'];
		$uniform = $info['uniform'];
		$rank_id = $info['rank_id'];
		$flag = $info['flag'];
		$location = $info['location'];
		$status = $info['status'];
		$p_mos = $info['p_mos'];
		$unit_id = $info['unit_id'];
		$subunit_id = $info['subunit_id'];
		$adminunits = $info['adminunits'];
		$reports = $info['reports'];
		$position = $info['position'];
		$weapon_id = $info['weapon_id'];
		$qual = $info['qual'];
		$enlistment_dt = $info['enlistment_dt'];
		$promotion_dt = $info['promotion_dt'];
		$icq = $info['icq'];
		$email = $info['email'];
		$bio = stripslashes($info['bio']);
	}
}

// Load Uniform images (Rank, Flag)
$urlofimages="$IMAGEPATH/modules/MILPACS/images/uniform/";
$uniformselecthtml = "<select name=\"uniform\">";
$uniformselecthtml .= "<option value=\"\">Select Uniform Image</option>";
if ($handle=@opendir($urlofimages)) { 
	while ($imgfile = readdir($handle)) {
		if ($imgfile != "." && $imgfile != ".." && $imgfile != "" && $imgfile != "index.html" && $imgfile != "WS_FTP.LOG" && $imgfile != "Thumbs.db") {
			if ($imgfile==$uniform) {
				$uniformselecthtml .= "<option value =\"$imgfile\" selected>$imgfile</option>";
			} else {
				$uniformselecthtml .= "<option value =\"$imgfile\" >$imgfile</option>";
			}
		}
	}
	@closedir($handle);
}
$uniformselecthtml .= "</select>";
// Load Ranks
$rankselecthtml = "<select name=\"rank_id\">";
$rankselecthtml .= "<option value=\"\">Select Rank</option>";
$result2 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_ranks order by rankname");
while ($rankrow = $db->sql_fetchrow($result2)) {
	if ($rankrow[rank_id]==$rank_id) {
		$rankselecthtml .= "<option value =\"$rankrow[rank_id]\" selected>$rankrow[rankname]</option>";
	} else {
		$rankselecthtml .= "<option value =\"$rankrow[rank_id]\" >$rankrow[rankname]</option>";
	}
}
$rankselecthtml .= "</select>";
// Load Flag images
$urlofimages="$IMAGEPATH/modules/MILPACS/images/flags/";
$flagselecthtml = "<select name=\"flag\">";
$flagselecthtml .= "<option value=\"\">Select Flag Image</option>";
if ($handle=@opendir($urlofimages)) { 
	while ($imgfile = readdir($handle)) {
		if ($imgfile != "." && $imgfile != ".." && $imgfile != "" && $imgfile != "index.html" && $imgfile != "WS_FTP.LOG" && $imgfile != "Thumbs.db") {
			if ($imgfile==$flag) {
				$flagselecthtml .= "<option value =\"$imgfile\" selected>$imgfile</option>";
			} else {
				$flagselecthtml .= "<option value =\"$imgfile\" >$imgfile</option>";
			}
		}
	}
	@closedir($handle);
}
$flagselecthtml .= "</select>";

// Load Weapons
$weaponselecthtml = "<select name=\"weapon_id\">";
$weaponselecthtml .= "<option value=\"\">Select Weapon</option>";
$result3 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_weapons order by make");
while ($weaponrow = $db->sql_fetchrow($result3)) {
	if ($weaponrow[weapon_id]==$weapon_id) {
		$weaponselecthtml .= "<option value =\"$weaponrow[weapon_id]\" selected>$weaponrow[make]</option>";
	} else {
		$weaponselecthtml .= "<option value =\"$weaponrow[weapon_id]\" >$weaponrow[make]</option>";
	}
}
$weaponselecthtml .= "</select>";

// Load Unit
$unitselecthtml = "<select name=\"unit_id\">";
$unitselecthtml .= "<option value=\"\">Select Unit</option>";
$result4 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_units order by unit_name");
while ($unitrow = $db->sql_fetchrow($result4)) {
	if ($unitrow[unit_id]==$unit_id) {
		$unitselecthtml .= "<option value =\"$unitrow[unit_id]\" selected>$unitrow[unit_name]</option>";
	} else {
		$unitselecthtml .= "<option value =\"$unitrow[unit_id]\" >$unitrow[unit_name]</option>";
	}
}
$unitselecthtml .= "</select>";

// Load Status
$statusselecthtml = "<select name=\"status\">\n<option value=\"\">Select Status</option>";
$wStatus = array("Active", "LOA", "Long Term LOA", "Retired", "Discharged");
for ($i=0; $i < sizeof($wStatus); $i++) {
	if ($status == $wStatus[$i])
		$statusselecthtml .= "<option value='$wStatus[$i]' selected>$wStatus[$i]</option>";
	else
		$statusselecthtml .= "<option value='$wStatus[$i]'>$wStatus[$i]</option>";
}
$statusselecthtml .= "</select>";

// Load Subunit
$subunitselecthtml = "<select name=\"subunit_id\">\n<option value=\"\">Select Subunit</option>";
$result5 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_subunit WHERE unit_id = '$unit_id' ORDER BY subunit_name");
while ($subunit_row2 = $db->sql_fetchrow($result5)) {
	if ($subunit_row2[subunit_id] == $subunit_id)
		$subunitselecthtml .= "<option value =\"$subunit_row2[subunit_id]\" selected>$subunit_row2[subunit_name]</option>";
	else
		$subunitselecthtml .= "<option value =\"$subunit_row2[subunit_id]\">$subunit_row2[subunit_name]</option>";
}
$subunitselecthtml .= "</select>";

// Load Admin Units
$num_of_admin_units = 0;
$adminunitselecthtml = "";
$result8 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_adminunit");
while ( $adminunits_row = $db->sql_fetchrow($result8) ) {
	$num_of_admin_units++;
}
$adminunitarray = explode(",",$adminunits);
$noa_admin_units = sizeof($adminunitarray);
for ($i=0; $i < $noa_admin_units; $i++) {
	if ($i > 0)
		$adminunitselecthtml .= "<br>\n";
	$adminunitselecthtml .= "<select name=\"admin_unit_id[]\">\n<option value=\"\">Add New Admin Unit</option>";
	$result7 = $db->sql_query("SELECT * FROM " . $prefix . "_milpacs_adminunit ORDER BY admin_unit_name");
	while ( $adminunit_row = $db->sql_fetchrow($result7) ) {
		$adminunit_id[$i] = $adminunit_row[admin_unit_id];
		$adminunit_name[$i] = $adminunit_row[admin_unit_name];
		if ($adminunit_id[$i] == $adminunitarray[$i-1])
			$adminunitselecthtml .= "<option value=\"$adminunit_id[$i]\" selected>$adminunit_name[$i]</option>";
		else
			$adminunitselecthtml .= "<option value=\"$adminunit_id[$i]\">$adminunit_name[$i]</option>";
	}
	$adminunitselecthtml .= "</select>";
}

OpenTable();
echo "<p><a href=\"admin.php?op=milpacs\">Return to Main Administration</a></p>";
echo " <form name=\"editsoldier\" action=\"".$admin_file.".php\" method=\"post\">";
?>
<table width="100%" border="2" cellpadding="2" align="center" cellspacing="0" style="border-collapse: collapse;" bordercolor="#111111">
	<tr>
		<td align="center" bgcolor= "<?php echo $bgcolor2 ?>"><b><font class="title">Personnel File of <?php echo $soldierName ?></font></b></td>
	</tr>	
	<tr>
		<td align="center"> Uniform image: <?php echo $uniformselecthtml ?></td>
	</tr>
	<tr>
		<td align="center"> Rank image: <?php echo $rankselecthtml ?></td>
	</tr>
	<tr>
		<td align="center"> Flag image: <?php echo $flagselecthtml ?></td>
	</tr> 
	<tr>	
	<td align="center">Is Member: <input type="checkbox" name="ismember" <?php if($ismember == "1"){echo " CHECKED";}?>> 	
	</tr> 
</table>

etc
etc

[halojoy]

I see nowhere you get $ismember value from POST

$ismember = $_POST['ismember'];

//
//
    <td align="center">Is Member: <input type="checkbox" name="ismember" <?php if($ismember == "1"){echo " CHECKED";}?>>

[SFDonovan]

Well to my understanding the record is already there. As in my addsoldier page I have the following:

if ($op == "NewSoldier") {

$ismember = $_POST['ismember'];

//
//

<td align="center" bgcolor= "<?php echo $bgcolor1 ?>">Is Member:  <?php echo $ismember ?><input type="checkbox" name="ismember" value="1" ></td>

Which works for adding a new soldier, but if I want to edit a soldier record I thought I would just need to set the value to whatever I entered in the box:

First get the value of ismember

$result = $db->sql_query
$info = $db->sql_fetchrow($result);
$ismember = $info['ismember'];

and then

$sql = "UPDATE " . $prefix . "_milpacs_members set
		ismember = '$ismember',
//
//

<td align="center">Is Member: <input type="checkbox" name="ismember" <?php if($ismember == "1"){echo " CHECKED";}?>>

I think my error is in the form itself.

<td align="center">Is Member: <input type="checkbox" name="ismember" <?php if($ismember == "1"){echo " CHECKED";}?>>

ouch....my head hurts 🙂

[halojoy]

 $result = $db->sql_query
$info = $db->sql_fetchrow($result);
$ismember = $info['ismember']; 

okay, you get the value of $ismember from database

when form is submittted goes to $admin_file:
<form name=\"editsoldier\" action=\"".$admin_file.".php\" method=\"post\">

and when you say this value is reset to '0'
I suppose we are at admin_file ... where something has to test submitted value

have you looked into your database,
if ismember value is '1' or '0'

[SFDonovan]

I can set ismember to 1 via phpmyadmin. Enter the editsoldier page and see that the checkbox is checked which is what I want, however when I submit it sets it to 0. It erases the value. So in short, the editsoldier page is not properly posting the value of the checkbox to the ismember field in the table.

[SFDonovan]

Anybody please. I am desperate to get these last few things working.

I have tried adding

$ismember = $_POST['ismember'];

But it didn't help.