suggestions On file manager class

[Talguy]

So i'm new at php about two weeks and have a little bit of programming experience under my belt (about 6 months of c++). So I am taking advantage of oop in php 5 and I'm building a file manager class that I can use with my upload script or looking to the future a file manager online for my webserver. I am just asking everyone to look over the code that I have so far which is just dealing with directories so far and give me tips what I should change add and what not and also what you would like to see added to the class

<?php
  class fileDirManager
  {
    private $dirPath;
	privagte $prevDirPath;
	private $__errors = array();

function __construct($path)
{
  $this->dirPath = $path;
  $this->prevDirPath = null;
}

public function createDir($dirName)
{
  opendir($this->dirPath);
  if(is_dir($dirName)) {
    $this->__errors[$dirName] = $dirName . " Is already a directory. Please choose a different name";
  }
  else {
    $create = mkdir($dirName, 0777);
	if(!$create){
	  $this->__errors[$dirname] = $dirname . " could not be created!";
	  return false;
	}
	else {
	  closedir($this->dirPath);
	  return true;
	}
  }
}

public function deleteDir($path)
{
  opendir($this->dirPath);
  if(!is_dir($path))
	$this->__errors[$path] = $path . " does not exist. Can not delete!";
  else {
	if($open = opendir($path)) {
	  $files = scandir($path);
	  for($i=0,$count = count($files); $i < $count; $i++) {
	    if($files[$i] == "." || $files[$i] == "..")
		  continue;
		else
		  unlink($files[$i]);
	  } 
	  closedir($path);
	  if($files =  count(scandir($path)) == 0) {
	    rmdir($path);
		return true;
	  }
	  else {
	    $this->__errors[$path] = $path . " could not be deleted";
		return false;
	  }
	  closedir($this->dirPath);
    }
	else die("Could not open directory!!");    
  }
}

public function changeDir($path)
{
  opendir($this->dirPath);
  if(is_dir($path)) {
    $this->prevDirPath = $this->dirPath;
    $this->dirPath = $path;
    if(isset($this->dirPath))
      echo "Changed Directory";
    else {
	  closedir($this->dirPath);
	  $this->dirPath = $this->prevPathDir;
	  $this->prevDirPath = null;
      $this->__errors[$path] = "Was not able to change directoried";
	}
  }
  else {
    closedir($this->dirPath);
    $this->__errors[$path] = "Directory " . $path . " does not exist.";
  }
}

function renameDir($oldPath, $newPath)
{
  if(is_dir($oldPath))
    rename($oldPath, $newPath);
  else
    $this->__errors[$oldPath] = $oldPath . " does not exist!  Can not rename directory";
}

public function getDirContents($path)
   {
  $files = scandir($path);
  return $files;
}
?>

[robinharvey]

First thing that strikes me is that you may want to use the @ operator to suppress error messages which may come from the filesystem functions. Say you try to create a new directory inside a directory which is not writable, a warning will be generated. try something like this:

//The @ operator suppreses the error message generated here.
if (! @unlink($emptyDir)) {
    throw new Exception("Can't delete dir!");
}

Second point is think about using exceptions (as above). The PHP implementation of these is a bit more Java-like (although I've not used C++ before, so maybe I can't comment...).

Third point - have a look at the SPL classes which do directory recursion. These are quite new to PHP, but getting to know Iterators now will be of beneit to you in future. More info here:
http://www.php.net/~helly/php/ext/spl/
There's a directory iterator and a recursive directory iterator here: maybe you could use these in your class?

hth
--Robin

[Talguy]

Thanks a lot it is still an unproved system that I am doing for the fun of it just to learn php.