Displaying error...

GreyFilm

Hey if you look in my script below you'll notice the error checker things. How do I display these in my HTML? I also included my full scripot.

if(!$_POST['username'] | !$_POST['pass']) {
die('You did not fill in a required field.');
}

$check2 = mysql_num_rows($check);
if ($check2 == 0) {
die('That user does not exist in our database.');
}

if ($_POST['pass'] != $info['password']) {
die('Incorrect password, please try again.');
}

FULL SCRIPT

<?php

// Connects to your Database 
mysql_connect("localhost", "spaodesi_admin", "greybeau") or die(mysql_error()); 
mysql_select_db("spaodesi_clients") or die(mysql_error()); 


//Checks if there is a login cookie

if(isset($_COOKIE['ID_my_site']))


//if there is, it logs you in and directes you to the members page
{ 
	$username = $_COOKIE['ID_my_site']; 
	$pass = $_COOKIE['Key_my_site'];

$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());

while($info = mysql_fetch_array( $check )) 	
	{

	if ($pass != $info['password']) 
		{

		}

	else
		{
		header("Location: client.php");

		}

	}

}


//if the login form is submitted

if (isset($_POST['submit'])) { // if form has been submitted


// makes sure they filled it in

if(!$_POST['username'] | !$_POST['pass']) {
	die('You did not fill in a required field.');
}

// checks it against the database

if (!get_magic_quotes_gpc()) {
	$_POST['email'] = addslashes($_POST['email']);
}

$check = mysql_query("SELECT * FROM users WHERE username = '".$_POST['username']."'")or die(mysql_error());

//Gives error if user dosen't exist

$check2 = mysql_num_rows($check);
if ($check2 == 0) {
		die('That user does not exist in our database.');
				}


while($info = mysql_fetch_array( $check )) 	
{

$_POST['pass'] = stripslashes($_POST['pass']);
	$info['password'] = stripslashes($info['password']);
	$_POST['pass'] = md5($_POST['pass']);

//gives error if the password is wrong

if ($_POST['pass'] != $info['password']) {
	die('Incorrect password, please try again.');
}

else
{
// if login is ok then we add a cookie 

$_POST['username'] = stripslashes($_POST['username']);


$hour = time() + 3600; 
setcookie(ID_my_site, $_POST['username'], $hour);
setcookie(Key_my_site, $_POST['pass'], $hour);	

//then redirect them to the members area
header("Location: members.php");
}

}

} else {	

// if they are not logged in
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<style type="text/css">
<!--
#background {
	position:absolute;
	left:0px;
	top:0px;
	width:854px;
	height:640px;
	z-index:0;
	background-image: url(images/background.jpg);
}
#clientform {
	position:absolute;
	left:691px;
	top:534px;
	width:117px;
	height:95px;
	z-index:2;
}
#navbg {
	position:absolute;
	left:607px;
	top:199px;
	width:228px;
	height:440px;
	z-index:1;
	background-image: url(images/nav_bg.png);
}
#navigation {
	position:absolute;
	left:613px;
	top:198px;
	width:217px;
	height:301px;
	z-index:3;
}
body {
	background-image: url(images/canvas.jpg);
}
-->
</style>
<script src="Scripts/AC_RunActiveContent.js" type="text/javascript"></script>
<script type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}
//-->
</script>
</head>

<body>
<div id="background" onload="MM_preloadImages('login/images/background.jpg')"></div>
<div id="clientform">
  <form action="<?php echo $_SERVER['login/PHP_SELF']?>" method="post">
  <table width="120" border="0" cellspacing="8" cellpadding="0">
    <tr>
      <td><label>
        <input name="username" type="text" id="username" size="15" />
      </label></td>
    </tr>
    <tr>
      <td><label>
        <input name="pass" type="password" id="pass" size="15" />
      </label></td>
    </tr>
    <tr align=right>
      <td><label>
      <input type="submit" name="Submit" value="Login" />
      </label></td>
    </tr>
  </table>
  </form>
</div>
<div id="navbg"></div>
<div id="navigation">
  <script type="text/javascript">
AC_FL_RunContent( 'codebase','http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=7,0,19,0','width','217','height','301','src','flash/home nav','quality','high','pluginspage','http://www.macromedia.com/go/getflashplayer','wmode','transparent','movie','flash/home nav' ); //end AC code
</script><noscript><object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=7,0,19,0" width="217" height="301">
    <param name="movie" value="flash/home nav.swf" />
    <param name="quality" value="high" />
    <param name="wmode" value="transparent" />
    <embed src="flash/home nav.swf" width="217" height="301" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash" wmode="transparent"></embed>
  </object>
</noscript></div>
</body>
</html>


<?php
}


?>

halojoy

if(!$POST['username'] | !$POST['pass'])
should be
if(!$POST['username'] || !$POST['pass'])

also
I dont know if this can work:

<form action="<?php echo $_SERVER['login/PHP_SELF']?>">

Houdini

You are killing the script when any of your criteria are met and at the first failure then that is "all she wrote" and the script ends, you need to take a different approach and show all the errors after they have ALL been checked. Instead of die concatenate a variable that you present then you can kill the script

if(!$_POST['username'] | !$_POST['pass']) {
$error ='You did not fill in a required field of the username or password.';
}

the same would apply to all the rest, then offer s link back to correct the problem with an

<a href='anything.php'>Return to signup</a>

or something along those lines.

GreyFilm

I really dont know how to do that, could you show me how the script should be?

aksival

If you are setting the form's action to the current page, this is bad:

<form action="<?php echo $_SERVER['login/PHP_SELF']?>">

This is a much better practice:

<form action="<?php echo $PHP_SELF; ?>">

As Houdini suggested, instead of DIE-ing you could concatenate the error messages in a variable:


// Start of error checking

$error_message = "";

if( $something != $something_else ) {
     $error_message .= "<p>Something is not equal to something else.</p>";
}

if( $this != $that ) {
     $error_message .= "<p>This is not equal to that!</p>";
}

...etc...

if( !empty($error_message) ) {
     echo $error_message;
     // Optionally, you could opt to 'exit' the script at this point
     // using exit();
     // Or you could provide a back button/link
}

I think that's what you were asking about...try to be a little more concise about what you actually need so we can provide more effective examples 🙂

GreyFilm

This is actually my first time using PHP so I really dont understand alot of stuff, could you (Aksival) put that code into my script like it should be? I would appreciate it alot.

halojoy

here is a rewritten version of your full script.
I have added some suggestions from other posters
and some of my own.

I can not promise it will work without a few corrections,
but I think it can be worth trying.

some changes:

<?php

// debug setting, remove later
error_reporting(2047);

$error_message = ""; // will display if submitted data was not correct
// makes sure they filled it in
$uname = trim($_POST['username']); // put POST into some variables
$passw = trim($_POST['pass']);         // trim eventual spaces
//$email = trim($_POST['email']);// disabled as form has no email submit


// will set action go back here
?>
 <form action="<?php echo $_SERVER['PHP_SELF'] ?>" method="post">

<?php // if is an error, display in red below form
    if (isset($error_message)){
        echo '<span style="color:red">';
        echo $error_message;
        echo '</span>';
    }
?>

Here is script:

<?php 
// Connects to your Database
mysql_connect("localhost", "spaodesi_admin", "greybeau") or die(mysql_error());
mysql_select_db("spaodesi_clients") or die(mysql_error());
// Checks if there is a login cookie
if(isset($_COOKIE['ID_my_site'])){ // if there is, it logs you in and directes you to the members page
    $username = $_COOKIE['ID_my_site'];
    $pass = $_COOKIE['Key_my_site'];
    $check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
    while($info = mysql_fetch_array($check)){
        if ($pass == $info['password']){
            header("Location: client.php");
            exit;
        }
    }
}
// debug setting, remove later
error_reporting(2047);
// if the login form is submitted
if (isset($_POST['submit'])){ // if form has been submitted
    $error_message = ""; 
    // makes sure they filled it in
    $uname = trim($_POST['username']);
    $passw = trim($_POST['pass']);
    //email = trim($_POST['email']);
    if(empty($uname) || empty($passw)){
        $error_message = 'Please fill in all the fields.';
    }else{ 
        // checks it against the database
        //if (!get_magic_quotes_gpc()){
        //    $email = addslashes($email);
        //}
        $check = mysql_query("SELECT * FROM users WHERE username = '" . $uname . "'")or die(mysql_error());
        // Gives error if user dosen't exist
        $check2 = mysql_num_rows($check);
        if ($check2 == 0){
            $error_message = 'That user does not exist in our database.';
        }else{
            while($info = mysql_fetch_array($check)){
                $passw = stripslashes($passw);
                $info['password'] = stripslashes($info['password']);
                $passw = md5($passw); 
                // gives error if the password is wrong
                if ($passw != $info['password']){
                    $error_message = 'Incorrect password, please try again.';
                }else{ 
                    // if login is ok then we add a cookie
                    $uname = stripslashes($uname);
                    $hour = time() + 3600;
                    setcookie(ID_my_site, $uname, $hour);
                    setcookie(Key_my_site, $passw, $hour); 
                    // then redirect them to the members area
                    header("Location: members.php");
                    exit;
                }
            }
        }
    }
}else{ 
    // if they are not logged in
    ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<style type="text/css">
<!--
#background {
    position:absolute;
    left:0px;
    top:0px;
    width:854px;
    height:640px;
    z-index:0;
    background-image: url(images/background.jpg);
}
#clientform {
    position:absolute;
    left:691px;
    top:534px;
    width:117px;
    height:95px;
    z-index:2;
}
#navbg {
    position:absolute;
    left:607px;
    top:199px;
    width:228px;
    height:440px;
    z-index:1;
    background-image: url(images/nav_bg.png);
}
#navigation {
    position:absolute;
    left:613px;
    top:198px;
    width:217px;
    height:301px;
    z-index:3;
}
body {
    background-image: url(images/canvas.jpg);
}
-->
</style>
<script src="Scripts/AC_RunActiveContent.js" type="text/javascript"></script>
<script type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}
//-->
</script>
</head>

<body>
<div id="background" onload="MM_preloadImages('login/images/background.jpg')"></div>
<div id="clientform">
  <form action="<?php echo $_SERVER['PHP_SELF']?>" method="post">
  <table width="120" border="0" cellspacing="8" cellpadding="0">
    <tr>
      <td><label>
        <input name="username" type="text" id="username" size="15" />
      </label></td>
    </tr>
    <tr>
      <td><label>
        <input name="pass" type="password" id="pass" size="15" />
      </label></td>
    </tr>
    <tr align=right>
      <td><label>
      <input type="submit" name="Submit" value="Login" />
      </label></td>
    </tr>
  </table>
  </form>
<?php
    if (isset($error_message)){
        echo '<span style="color:red">';
        echo $error_message;
        echo '</span>';
    }
?>
</div>
<div id="navbg"></div>
<div id="navigation">
  <script type="text/javascript">
AC_FL_RunContent( 'codebase','http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=7,0,19,0','width','217','height','301','src','flash/home nav','quality','high','pluginspage','http://www.macromedia.com/go/getflashplayer','wmode','transparent','movie','flash/home nav' ); //end AC code
</script><noscript><object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=7,0,19,0" width="217" height="301">
    <param name="movie" value="flash/home nav.swf" />
    <param name="quality" value="high" />
    <param name="wmode" value="transparent" />
    <embed src="flash/home nav.swf" width="217" height="301" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash" wmode="transparent"></embed>
  </object>
</noscript></div>
</body>
</html>
<?php
}

?>

aksival

This is actually my first time using PHP so I really dont understand alot of stuff, could you (Aksival) put that code into my script like it should be? I would appreciate it alot.

That's really not fair to ask of somebody in a forum like this. People are here to help other people out, not to do their work for them.

In fact, most people are more than happy to see somebody who is willing to learn and figure stuff out for his/herself. When you basically ask for someone to do something for you, it doesn't help you which, in turn, doesn't help everyone else the next time you need something (because you probably didn't learn anything from the experience).

halojoy did you a huge favor and and is very generous for that...you should be thankful. But please, do make a reasonable effort to learn the language for yourself in the future...that's what we're all here for 🙂

Hope it works for you.

Best,
aksival

Houdini

Try this code, run it and then look it over carefully and see the technique and logic that is involved with it.

<?php
$_POST['submit']= "blah";//comment out or remove this line after testing the below script
// if you do comment out the above line then the else statement at the very bottom will execute if this code is run by calling its URL
if(isset($_POST['submit'])){
//Lets create some short simple variables from the $_POST array to avoid coding troubles 
$username=$_POST['username'];
$password=$_POST['password'];
$email=$_POST['email'];
$name=$_POST['name'];
$hobby=$_POST['hobby'];
$city=$_POST['city'];
$state=$_POST['state'];
$error="";//right now we are making the error variable nothing
//now lets check all the form entries
	if(!$username){
  	   $error = "You did not enter a username, why is this? Try again Bozo!<br />";
	}
	if(!$password){
	  $error .=	"You seem to have failed to enter a password, man you are a real clown! Try again.<br />";  

	}
	if(!$mail){
	  $error .= "Oh man you did not enter an e-mail address, how do you expect us to let you know about new things going on at the fantastic site you are trying to join. Please try again!<br />";
	}
	if($error==""){
	echo "There were no errors so do something else here."; 
	}
		else{
		  echo "<center><h2><span style='color:white'>There are errors!</span></h2></center><body bgcolor=black><span style='color:red'><b>".$error."</b></span></body>";
		}
}
else{
echo "You did not enter this page properly ... now your IP has been recorded and you are banned, ha ha ha ha!";
exit;  

}
?>

This technique buileds up the error messages using concatenation. By first setting the $error to "" (nothing) then as conditions are either met or fail you add to the $error variable by using .= maybe this will help you understand what is going on. I just required three of the entries to be required before calling or printing an error to the screen, and in the case of this script all will happen, this is why there is a <br /> to seperate each line of error, or you would use <br /><br /> for a space between each error.

GreyFilm

Thankyou very much Halojoy for the script, and thankyou Houdini that seriously helped me see what was going on in the script, THANKYOU!!!