Upload image to directory based on primary key of DB

SpecialFX

I have to add several values to a table and one of them is an image, Well i get the ID from the table entry then make a directory called that ID and then move the file into that directory. Here is the script hopefully someone can help

<?php
require ('dbconnect.php');

$name = addslashes($name);
$members = addslashes($members);
$biography = addslashes($biography);
$myspace = addslashes($myspace);
$bandurl = addslashes($bandurl);

mysql_query("INSERT INTO bands 
(name, members, image, bandurl, biography, myspace) VALUES ('$name', '$members', 'NULL', '$bandurl', '$biography', '$myspace') ") 
or die(mysql_error());  {

$foldername = mysql_insert_id();
$targetpath = mkdir("$foldername", 0777);

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); 
$name = stripslashes($name);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
} else{
    echo "There was an error.";
}
}
?>

Kudose

So what's the problem, other than your script wont work with safe mode on?

SpecialFX

Well the problem is the script won't work. I thought safe mode had to do with your server so how could I turn it off?

Kudose

What's the error you are getting?

You have an erroneous brace after your die(mysql_error()) and at the end of your script. You are also missing an ending parenthesis after move_uploaded_file.

Safe mode does deal with the server. It was really late and I meant to say register_globals.

You are pulling variables from thin air ($name, $members, etc...) and not declaring them. If register_globals is on, which is a security risk, then your script will allow this. If register_globals is off, like it should be, then $name, $members, etc should be empty since you do not initialize them ($name = $_POST['name']).

SpecialFX

I don't get an error it just echoes "There was an error" because It couldn't set up the directory and such. The other parts work fine name, memebers and all those are coming from a form its just the image part (also coming from the same form), I am having trouble with. It won't upload properly.

Kudose

Is your form's enctype multipart/form-data?

Kudose

Also, use [man]is_uploaded_file[/man] or check the error value in the $_FILES array to see if the file ever even uploaded.

SpecialFX

it is multipart/form-data.

like this?

<?php
require ('dbconnect.php');

$name = addslashes($name);
$members = addslashes($members);
$biography = addslashes($biography);
$myspace = addslashes($myspace);
$bandurl = addslashes($bandurl);

mysql_query("INSERT INTO bands
(name, members, image, bandurl, biography, myspace) VALUES ('$name', '$members', 'NULL', '$bandurl', '$biography', '$myspace') ")
or die(mysql_error());  {

$foldername = mysql_insert_id();
$target_path = mkdir("$foldername", 0777);

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);
$name = stripslashes($name);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
} else{
    echo "There was an error.";
}
if(is_uploaded_file($_FILES['uploadedfile']['tmp_name'])){
    echo 'Success';
} else {
   echo 'error';
}
}
?>

Kudose

You need to check to see if the file was uploaded before you try to move it.

SpecialFX

<?php
require ('dbconnect.php');

$name = addslashes($name);
$members = addslashes($members);
$biography = addslashes($biography);
$myspace = addslashes($myspace);
$bandurl = addslashes($bandurl);

mysql_query("INSERT INTO bands
(name, members, image, bandurl, biography, myspace) VALUES ('$name', '$members', 'NULL', '$bandurl', '$biography', '$myspace') ")
or die(mysql_error());  {

$foldername = mysql_insert_id();
$target_path = mkdir("$foldername", 0777);

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);
$name = stripslashes($name);

if(is_uploaded_file($_FILES['uploadedfile']['tmp_name'])){
move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)
    echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
} else{
    echo "There was an error.";
}
}
?>

Kudose

That's not going to tell you anything new.

if(is_uploaded_file($_FILES['uploadedfile']['tmp_name'])){
  move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)
      echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
  } else{
      echo "There was an error.";
  }
} else {
  echo 'File not uploaded.';
}

SpecialFX

Even with the change you made I just have a blank page as a response.

Kudose

if(is_uploaded_file($_FILES['uploadedfile']['tmp_name'])){
  if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)){
      echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
  } else{
      echo "There was an error.";
  }
} else {
  echo 'File not uploaded.';
}

Sorry, missing a conditional.

SpecialFX

Alright so now it just echoes "File Not Uploaded".

Kudose

Check the value in $_FILES['uploadedfile']['error'] for some insight as to why it isnt uploading.

http://us2.php.net/manual/en/features.file-upload.errors.php

SpecialFX

Yeah I tried to get so if there was an error it would echo the error and say file wasn't uploaded. However it does say file wasn't upload but it won't echo the error, like the way you told me too.

Kudose

Did you check the value in $_FILES['uploadedfile']['error']?

SpecialFX

I guess I wasn't using it correctly? So do I have to do different cases? for each possible outcome.

Kudose

Try this:

echo $_FILES['uploadedfile']['error'];

and use the integer to figure out which error it is on http://us3.php.net/manual/en/features.file-upload.errors.php

SpecialFX

It doesn't work thats what I had before, no integer comes up its just blank.

<?php
require ('dbconnect.php');

$name = addslashes($name);
$members = addslashes($members);
$biography = addslashes($biography);
$myspace = addslashes($myspace);
$bandurl = addslashes($bandurl);

mysql_query("INSERT INTO bands
(name, members, image, bandurl, biography, myspace) VALUES ('$name', '$members', 'NULL', '$bandurl', '$biography', '$myspace') ")
or die(mysql_error());  {

$foldername = mysql_insert_id();
$target_path = mkdir("$foldername", 0777);

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);
$name = stripslashes($name);

if(is_uploaded_file($_FILES['uploadedfile']['tmp_name'])){
  if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)){
      echo '<font face="Tahoma" size="2">Your band entry <b>'.$name.'</b> has been posted.</font>';
  } else{
      echo "There was an error.";
  }
} else {
  echo 'File not uploaded.';
  echo $_FILES['uploadedfile']['error'];
} 
}
?>