[RESOLVED] mysql_num_rows(): error

[genista]

Hi guys,

I have the following error:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/fhlinux245/h/blah.co.uk/user/htdocs/suppliersearch.php on line 55

from the following part of that code:

// Build SQL Query  

$query = "select * from 'suppliers' where 'county' like \"%$trimmed%\"  

  order by county"; // EDIT HERE and specify your table and field names for the SQL query

 $numresults=mysql_query($query);
 $numrows=mysql_num_rows($numresults);

if ($numrows == 0)
  {
  echo "<h4>Results</h4>";
  echo "<p>Sorry, your search: &quot;" . $trimmed . "&quot; returned zero results</p>";

 }

// next determine if s has been passed to script, if not use 0
  if (empty($s)) {
  $s=0;
  }

// get results
// line 60
  $query .= " limit $s,$limit";
  $result = mysql_query($query) or die("Couldn't execute query");

To me it looks like mysql_num_rows should be replaced with something else as it may be old?

Any help appreciated.

Thanks,

G

[bogu]

U should check your query ...
Where u have this line:

$numresults=mysql_query($query);

debug version:

$numresults=mysql_query($query) or die(mysql_error());

[thorpe]

You never check to see if your query actually worked (which by the looks, it does not) before trying to use it.

if ($numresults = mysql_query($query)) {
  $numrows = mysql_num_rows($numresults);
} else {
  echo mysql_error();
}

[genista]

Ok thats great, I now have an error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''suppliers' where 'county' like "%surrey%" order by county' at line 1

from:

$query = "select * from 'suppliers' where 'county' like \"%$trimmed%\"  

  order by county";

[bogu]

why do u put your DB table name between quotes?

[reeksy]

Some people prefer to. It doesn't make a difference just personal preference.

I like to write my queries like this:

$db->query("SELECT * FROM `tblname` WHERE id= $id ORDER BY name ASC");

[genista]

Thanks problem solved!

[thorpe]

Some people prefer to. It doesn't make a difference just personal preference.

It does make a difference. In fact, it won't work if you put your table name in quotes.

[Houdini]

Quote:
Some people prefer to. It doesn't make a difference just personal preference.

As noted by thorpe it most certainly does make a difference. You could use backtics `` but not single quotes or (apostrophes) '' they are not the same to MySQL.

It does make a difference. In fact, it won't work if you put your table name in quotes

Ditto!