[RESOLVED] Function never returns

Bobulous

I'm using call_user_func_array to allow functions to be called according to user input.

While the function called does what it's supposed to (output the desired data to the page), it never returns. Code that comes after call_user_func_array(..., ...) is not executed.

Can someone explain what is happening to the execution flow? The examples in the manual suggest that execution returns to the line after the call to call_user_func_array(), so why is my script seemingly stopping after the callback function finishes?

Houdini

Maybe is you had the code you are using it would be easier to solve than trying to guess what is happening.

MarkR

Firstly, does the user function call exit(), die() or anything else like that?

Secondly, enable ALL warnings, notices, etc, and ensure that you are NOT using the @ operator ANYWHERE that could possibly cause a fatal.

IMHO, the @ operator should not stop fatals from being reported, however, it does so, but they still terminate the page execution; this means it causes "silent death".

Mark

Bobulous

No, there's no exit or die command.

The structure is:

function a($function_name) {
    $result = call_user_func_array($function_name, $param_array) ;
    echo "<p>Result is $result</p>";
}

function named_function() {
    $output = '';
    $output .= "text";
    echo $output;
    return $output;
}

The named_function is called and runs as desired.

But the line "<p>Result is $result</p>"; is never reached. Execution just seems to return to the line after the function call on the HTML page. So it's not dying altogether, but it's skipping the line I logically expect it to reach next.

So I'm sure I'm the one at fault, but I cannot see why.

MarkR

Are you sure you're passing the right number of parameters to the function?

What happens when you enable ALL WARNINGS AND NOTICES?

Mark

Bobulous

Yes, the right number of parameters is reaching the called function. As I say, the function works perfectly if I just use echo to dump output to the page immediately. But if I try to construct a string and return the string, the value seems to go nowhere, and the code executes from the next line on the HTML page, and not the next line immediately after the call to call_user_func_array().

When I set

error_reporting(E_ALL);

I get exactly the same output. No error reports at all.

I'm baffled.

Bobulous

Okay, I've just realised it's me being an idiot.

I'm using Eclipse to edit the PHP project, and I've just realised that Eclipse is exporting the files to the old working directory, not the new one. So changes to the HTML file were showing up, but changes to the library code were not.

Can anyone recommend a less convoluted way of editing PHP files. Eclipse has some great features, but for small projects it mostly just gets in the way of progress.

madwormer2

If you want the function to return, you need to set $boomerang to TRUE.

Sorry, I couldn't resist.

I find that unless you have so many files that you can't manage manually, it's easier (at least for me) just to open the folder and then edit the files directly. But then again I've made a few mistakes when editing the wrong files...

epimeth

ummm.... personally I prefer emacs... but I've never been against using notepad.

if you want sytax highlighting and stuff try textedit, or php expert editor...
or any one of a million other text editors....