Dumb code...

dalecosp

Dunno, maybe this should be in the EL's "Doh!" thread....

Found this in something I wrote quite a while back:

function GetMonth($month) {
        switch ($month) {
                case "January":
                        $foothis=1;
                        break;
                case "February":
                        $foothis=2;
                        break;
                case "March":
                        $foothis=3;
                        break;
                case "April":
                        $foothis=4;
                        break;
                case "May":
                        $foothis=5;
                        break;
                case "June":
                        $foothis=6;  // I'll save you the inidignity of the remainder...
                        break;
      }
   return $foothis;
}

Shrike

Where can I buy a foothis? 🙂

phpshift

Or you could just do this:

print date("n");

dalecosp

phpshift wrote:
Or you could just do this:
print date("n");

Um, yes. That's the whole point. 😉 But we can give you a point for playing, I suppose. Good catch. 🙂

Shrike wrote:
Where can I buy a foothis? 🙂

Froogle sez here, or I can write you a function to return it for free under a BSD-style license.... 😉

Weedpacket

Please, I want to know: did that switch have a default: case?

Shrike

Well yes, the default case was date( 'n' )...no?

dalecosp

Weedpacket wrote:
Please, I want to know: did that switch have a default: case?

Nope.

Well, I suppose if you didn't pass it a valid "monthstring", you'd have got NULL returned.

But that probably doesn't count.

Well yes, the default case was date( 'n' )...no?

Not at all ... if I'd remembered date('n') you can bet I wouldn't have bothered coding that dumb function.

I've made myself paranoid. I spent at least half an hour yesterday going through my whole API and looking for similar idiotic stuff.

Of course, the real issue now: I've got to look at everything that uses my API and see where the dumb stuff is being used..... 😃

Shrike

It is my feeling that GetMonth() has more utility than plain old date( 'n' ). For example with GetMonth() I can get the digit of any month just by passing a simple string. I'd like to see date( 'n' ) manage that. It'd involve some sort of strtotime() toomfoolery not to mention hefty use of GNU date formats. So thus follows a bout of silly testing

function GetMonth($month) { 
        switch ($month) { 
                case "January": 
                        $foothis=1; 
                        break; 
                case "February": 
                        $foothis=2; 
                        break; 
                case "March": 
                        $foothis=3; 
                        break; 
                case "April": 
                        $foothis=4; 
                        break; 
                case "May": 
                        $foothis=5; 
                        break; 
                case "June": 
                        $foothis=6;  // I'll save you the inidignity of the remainder... 
                        break; 
      } 
   return $foothis; 
} 
$runs = 6;
$months = array( 0, 'January', 'February', 'March', 'April', 'May', 'June' );
list($usec, $sec) = explode(' ', microtime());
$start = ((float)$usec + (float)$sec);
for( $i = 1; $i <= $runs; $i++ )
{
	GetMonth( $months[$i] );
}
list($usec, $sec) = explode(' ', microtime());
$end = ((float)$usec + (float)$sec);
$time1 = $end - $start;

list($usec, $sec) = explode(' ', microtime());
$start = ((float)$usec + (float)$sec);
for( $i = 1; $i <= $runs; $i++ )
{
	date( 'n', strtotime( '1 ' . $months[$i] . ' 2006' ));
}
list($usec, $sec) = explode(' ', microtime());
$end = ((float)$usec + (float)$sec);
$time2 = $end - $start;
echo $time1 . ' ' . $time2;

:evilgrin: