[RESOLVED] Is this correct formatting?

ElectricRain

$done = @mail($to, $subject, $message, $from);

if (!$done) { echo ("Error sending mail message"); }

Im not sure whether you should have just !$done, should it be !isset($done) ? Or not in this context?

halojoy

goto php.net
and read all about it

http://php.net/manual/en/function.mail.php

ElectricRain

Yea I know about the mail function, thats not the question, sorry maybe I wasnt quite clear...

I just want to know about the $done bit- Im having a hard time getting my head around whether you can use !$done to say a variable does not exist? or do I need (!isset($done)) ?
And if the mail hadnt sent, would $done definately not exist?

Installer

These charts can help.

ElectricRain

o0o I like those 😃 Thanks

Installer

For your second question: since "mail()" returns a boolean, yes, it will exist after a (syntactically valid) call to it.

halojoy

ElectricRain wrote:
I just want to know about the $done bit- Im having a hard time getting my head around whether you can use !$done to say a variable does not exist? or do I need (!isset($done)) ?
And if the mail hadnt sent, would $done definately not exist?

At the link i gave you is says:

Return Values

Returns TRUE if the mail was successfully accepted for delivery, FALSE otherwise.

It is important to note that just because the mail was accepted for delivery, it does NOT mean the mail will actually reach the intended destination.

so your script is alright!

 $done = @mail($to, $subject, $message, $from);

if (!$done) { echo ("Error sending mail message"); }

ElectricRain

Aghh now Im confused lol

Ok so. Installer says mail() will exist after a synthetically valid call to it.
So (isset($done)) would return that it does exist even if the mail didnt get accepted for delivery? Or have I missinterpreted that? Because the next answer seems to contridict it lol...

Ahh.. maybe a synthetically valid call to it means that it would definately have been accepted? Gah. Me n the mail function dont get on.

Installer

It will exist (e.g. isset($done) will be true), but its boolean value will be false; thus "!$done" will return true on failure, false on success. In English, it's like saying the answer to "Is it false" is "True, it is false".

ElectricRain

Haha awesome. So I did have it right 😃 Perfect, Thank you.

halojoy

ElectricRain wrote:
Aghh now Im confused lol

Ok so. Installer says mail() will exist after a synthetically valid call to it.
So (isset($done)) would return that it does exist even if the mail didnt get accepted for delivery? Or have I missinterpreted that? Because the next answer seems to contridict it lol...

yes
if ( isset( $done )) would always be the case, so no idea use this
either $done will be set to TRUE or be set to FALSE

if ( !done )
will work and could be read as: "if not done, than echo error"

ElectricRain

And thats why I want to use !$done instead of !isset($done)

I get it. I think 🙂 Thanks for the help.