[RESOLVED] If no ?page= is present

pizzarro

Hello...
I'm designing a site that makes use of ?page= to load content into a design page. If you specify ?page= then everything is fine, but if it's not specified, then it just shows a blank content area.
JJ

These links show the working and non-working URLs.
http://www.lwcbranson.org/v2.4/common.php?site=livingword&page=livingword/greeting.html
http://www.lwcbranson.org/v2.4/common.php?site=livingword

This is the code that I'm using. It looks right to another php guy, but it isn't working, for some reason.
if(!$GET["page"]){$GET["page"] == "livingword/greeting.html";}
elseif(file_exists($GET["page"])){include_once($GET["page"]);}

epimeth

how about:

the '==' is wrong... it should be '='

if(!$GET["page"]){
$GET["page"] = "livingword/greeting.html";
}

pizzarro

Well, that still didn't work.
JJ

epimeth

heh... lol... my bad... didn't look it all through

you aren't actually including the new $_GET['page']... its in the elseif!

just replace the elseif with an if and it should work fine

pizzarro

Hmmm...
That worked, although I'm not quite sure why.
Hehehe...
I would think that if/elseif would be proper syntax? What's the difference?
Thanks...BTW...
JJ

shonuff

It would be better to use a switch statement...

$page = $_GET['page'];

switch($page){
          case 'who':
              include "who.inc.php";
              break;
          case 'what':
              include "what.inc.php";
              break;
          case 'when':
              include "when.inc.php";
              break;
          case 'where':
              include "where.inc.php";
              break;
          //if page= is empty, use the following content
          default:
              include "who.inc.php";
}

epimeth

shonuff... honestly thats total overkill...

pizza, I'll explain:

if (something) {
do something
} elseif (something else) {
do something else
}

means that if I did something, I won't do something else and vice versa.
the 'else' means literally what it says: ELSE. translated to english the code above means:
do something if something, else (otherwise) do something else if something else. it doesn't recheck the if statement and then go into the elseif statement.

the new code does this: if the page isn't defined, define the page.
if the page has a file associated with it, load the file.

the old code said: if the page isn't definied, define it. Otherwise if the page has a file, load the file.

The otherwise is what broke your code.

pizzarro

Thanks, guy...
The site is working the way that I wanted.
Unfortunately, though, I'm not sure what I'm going to do when they register domains for all ?site= variables. I guess I could make a redirect file for each domain, but that doesn't seem handy. I would think there would be a better way.
JJ

epimeth

I'm not sure I understand....

bradgrafelman

To fix your original code, I would do something like this:

if(!isset($_GET['page']))
     include_once 'livingword/greeting.html';
else {
     if(file_exists($_GET['page']))
          include_once($_GET['page']);
     else
          echo 'page not found.'; // what should happen if the page specified doesn't exist? modify this.
}

However, there's two things about your code you might want to rethink:

You're taking a variable that anyone can manipulate and just including it. That means I could pretty much tell your script to open any file on your webserver and display it. Not good.
In the code you gave, you were including a .html page. Are you going to be processing PHP pages, or just spitting out plain HTML pages? If so, using include_once is a waste of resources, plus its just opening a security risk you don't need. Look at using [man]readfile/man if you're just spitting back HTML pages.

pizzarro

This design is for 4 subsites (livingword, oneighty, bus kids, american heritage). Currently, their only domain is lwcbranson.org. That is associated with livingword. They want to have a domain associated with the other 3 subsites, as well.
Currently, the code is set up for...
if(!$GET["site"]){$GET["site"] = "livingword";}
and
if(!$GET["page"]){$GET["page"] = "".$GET["site"]."/index.html";}
Which will work fine for www.lwcbranson.org, but if you type in www.oneightybranson.org (not a real domain), for instance, it will still bring up the livingword colors/content, because that's what default.
I could create an account for each domain and just make a redirect page to the appropriate ?site=, but that seems kind of odd.
Is there a way to grab the domain that was typed.
if($GET["domain"] = lwcbranson.org){?site = livingword};
Something along those lines?
JJ

bradgrafelman

Browsers should send a "Host:" HTTP header, so you can grab that using $_SERVER['HTTP_HOST'].

pizzarro

$_SERVER['HTTP_HOST'] worked fine. Is there a way to do just the domain without a hostname? I tried SERVER_NAME, but it gave the same results.
Like someone could type lwcbranson.org or www.lwcbranson.org and it shows up as 2 different things.
JJ

bradgrafelman

So use something like [man]strpos/man and see if "lwcbranson.org" appears in the hostname.

pizzarro

bradgrafelman wrote:
2. In the code you gave, you were including a .html page. Are you going to be processing PHP pages, or just spitting out plain HTML pages? If so, using include_once is a waste of resources, plus its just opening a security risk you don't need. Look at using [man]readfile/man if you're just spitting back HTML pages.

I implemented readfile(). Generally, it will only be displaying an html file, although there could be cause to use php sometimes. Would readfile not work for php?
JJ