PHP radio-button validation ???

j4mes_bond25

I've a contact form, on my nearly finished website, allowing viewers to send the data, which I've validated with different validation rule depending on the data required for a field itself.

Website itself can be seen on:

http://members.lycos.co.uk/darsh25/AllInclusiveWebDesign/contact.php

Problem is with last 2 fields i.e. "Reply Required" AND "How would you like to be contacted?"

If user press the submit button, I want the "filled" fields remain same, hence, making them NOT to re-type what they's already done. I wish to do the same for these 2 options as well, hence whichever radio button they'd chosen, after pressing submit, if they mis-filled any fields (for example, "e-mail"), then I want the option chosen in 2 radio buttons staying same i.e. whatever they'd chosen

Problem is, after pressing "Submit" the radio button options for these 2, ALWAYS goes to the "second option" regardless of the option chosen ??? This makes them RE-chose the radio button option.

Related code

<tr id="contactTable">
<td id="contactTable">Reply Required:</td>
<td id="contactTable"><input type="radio" name="reply" value="Yes" checked="checked"/>Yes
<input type="radio" name="reply" value="No" <?php if ($reply="No") echo "checked='checked'"; ?>/>No</td>
</tr>

<tr id="contactTable">
<td id="contactTable">How would you like to be contacted <span class="italic">(if required)</span>?<br/><br/></td>
<td id="contactTable"><input type="radio" name="contact" value="Email" checked="checked"/>E-mail
<input type="radio" name="contact" value="Telephone" <?php if ($contact="Telephone") echo "checked='checked'"; ?>/>Telephone
</td>
</tr>

Wonder why's this happening ??? Can anyone help ???

halojoy

hi
I cant see you are using any <form> tags
Are you?

j4mes_bond25

halojoy wrote:
hi
I cant see you are using any <form> tags
Are you?

Well, I only displayed those radio buttons related code, but the ENTIRE code for the Contact.php i.e. for the Contact link is:

<div id="header">
<?php include("inc/header.inc");?> 
</div>

<?php include("inc/head.inc");?>

<body>
<?php include("inc/banner_topmenu.inc");?>
<?php include("inc/left_right_content.inc");?>

<div id="centerContent">

<?php

// If the form has been posted, analyse it: 
if ($_POST) {
	foreach ($_POST as $field => $value) {
		$value = trim($value);
   	}

// Creating Variables
	$inquiry=$_POST['inquiry'];
	$title=$_POST['title'];
	$first_name=$_POST['first_name'];
	$last_name=$_POST['last_name'];
	$email=$_POST['email'];
	$phone=$_POST['phone'];
	$message=$_POST['message'];
	$reply=$_POST['reply'];
	$contact=$_POST['contact'];

// Create empty ERROR variables
	$error = ""; // for fields left BLANK
	$errorflag = ""; // for fields with INVALID data entered

// Check for field/fields that is/are left BLANK
	if (($first_name == "") || ($last_name == "") || ($email == "") || ($phone == "") || ($message == "")) {
		$error = "<span class='colorTextBlue'>Please fill in all fields!</span>";
	}
	else { 
	// Validate First Name (including ERRORS such as (1) field left BLANK (2) field with INVALID data entered 
		if (ctype_alpha($first_name) == FALSE)  {
			$error = "<span class='colorTextBlue'>Please enter a valid First Name <span class='italic'>(Alphabets only)</span></span>";
			$errorflag= "first_name";
			} 
	// Validate Last Name (including ERRORS such as (1) field left BLANK (2) field with INVALID data entered 
		else if (ctype_alpha($last_name) == FALSE) {
			$error = "<span class='colorTextBlue'>Please enter a valid Last Name <span class='italic'>(Alphabets only)</span></span>";
			$errorflag="last_name";
			} 
	// Validate E-mail (including ERRORS such as (1) field left BLANK (2) field with INVALID data entered 
		else if ((strpos($email, "@") == FALSE)|| 
			(strpos($email, ".") == FALSE) ||
			(strpos($email, " ") != FALSE)) {
				$error = "<span class='colorTextBlue'>Please enter a valid E-mail</span>";
				$errorflag="email";
			} 
	// Validate Contact No. (including ERRORS such as (1) field left BLANK (2) field with INVALID data entered 
		else if (is_numeric($phone) == FALSE) {
			$error = "<span class='colorTextBlue'>Please enter a valid Contact No. <span class='italic'>(must contain numbers only)</span></span>";
			$errorflag="phone";
			}
	} 
	// Confirmation Message seen AFTER filling the form and pressing "Submit" button (whether there's an error or not)
	if ($error != "") {	echo "<br/>&nbsp;&nbsp;&nbsp;<b><span class='colorTextRed'>Error Occured: </b>" . $error."</span>" ; } // If there's an error along with displaying the list of flagged error/errors

// If there's NO error at all, along with displaying the filled fields
	else if (mail("darsh25@ntlworld.com", $_POST['inquiry'], stripslashes($_POST['message']), "From: " . $_POST['email'])) {
		echo "E-mail sent successfully";
		echo "<p>Thanks for your comment and time. We will be in touch with you shortly, if required.<br/><br/>"; 
		echo "<b>Nature of Inquiry:</b> ". $inquiry . "<br/>";
		echo "<b>Title:</b> ". $title . "<br/>";
		echo "<b>First Name:</b> ". $first_name . "<br/>";
		echo "<b>Last Name:</b> ". $last_name . "<br/>";
		echo "<b>E-mail:</b> ". $email . "<br/>";
		echo "<b>Contact No.:</b> ". $phone . "<br/>";
		echo "<b>Message:</b> ". $message . "<br/>";
		echo "<b>Reply:</b> ". $reply . "<br/>";
		echo "<b>Contact Method:</b> ". $contact . "<br/></p>";
			}
else {
$error = "E-mail NOT sent";
	}
}

// Displays the Empty variables
else {

$inquiry = "";
$title = "";
$first_name = "";
$last_name = "";
$email = "";
$phone = "";
$message = "";
$reply = "";
$contact = "";
$errorflag = "";
}

?>

<p class="first-letter">Please fill the following form in for any enquiries that you may have:</p>

<table id="contactTable">

<tr id="contactTable">
<td id="contactTable"><form method="post" action="<?php echo $_SERVER['PHP_SELF'] ?>">
Nature of Enquiry:</td>
<td id="contactTable"><select name="inquiry" class="contactForm">
<option <?php if ($inquiry == "General Inquiry") echo "Selected"; ?> value = "General Inquiry">General Inquiry</option>
<option <?php if ($inquiry == "Price Quotation") echo "Selected"; ?> value = "Price Quotation">Price Quotation</option>
<option <?php if ($inquiry == "Comments") echo "Selected"; ?> value = "Comments">Comments</option>
<option <?php if ($inquiry == "Other") echo "Selected"; ?> value = "Other">Other</option>
</select></td>
</tr>

<tr id="contactTable">
<td id="contactTable">Title:</td>
<td id="contactTable"><select name="title" class="contactForm"/>
<option <?php if ($title == "Mr") echo "Selected"; ?> value = "Mr">Mr</option>
<option <?php if ($title == "Miss") echo "Selected"; ?> value = "Miss">Miss</option>
<option <?php if ($title == "Ms") echo "Selected"; ?> value = "Ms">Ms</option>
<option <?php if ($title == "Mrs") echo "Selected"; ?> value = "Mrs">Mrs</option>
<option <?php if ($title == "Other") echo "Selected"; ?> value = "Other">Other</option>
</select></td>
</tr>

<tr id="contactTable">
<td id="contactTable"><?php if ($errorflag == "first_name") { echo "<span class='colorTextRed'>First Name:</span>"; } 
						else { echo "First Name:"; } ?></td>
<td id="contactTable"><input type="text" size="30" maxlength="30" name="first_name" value="<?php echo $first_name; ?>" class="contactForm"/></td>
</tr>

<tr id="contactTable">
<td id="contactTable"><?php if ($errorflag == "last_name") { echo "<span class='colorTextRed'>Last Name:</span>"; }
						else { echo "Last name:"; } ?></td>
<td id="contactTable"><input type="text" size="30" maxlength="30" name="last_name" value="<?php echo $last_name; ?>" class="contactForm"/></td>
</tr>

<tr id="contactTable">
<td id="contactTable"><?php if ($errorflag == "email") { echo "<span class='colorTextRed'>E-mail:</span>"; }
						else { echo "E-mail:"; } ?></td>
<td id="contactTable"><input type="text" size="30" maxlength="30" name="email" value="<?php echo $email; ?>" class="contactForm"/></td>
</tr>

<tr id="contactTable">
<td id="contactTable"><?php if ($errorflag == "phone") { echo "<span class='colorTextRed'>Contact No.:</span>"; }
						else { echo "Contact No.:"; } ?></td>
<td id="contactTable"><input type="text" size="30" maxlength="20" name="phone" value="<?php echo $phone; ?>" class="contactForm"/></td>
</tr>

<tr id="contactTable">
<td id="contactTable">Message:</td>
<td id="contactTable"><textarea rows="10" cols="50" wrap="physical" name="message" class="contactForm"/><?php echo $message; ?>
</textarea></td>
</tr>

<tr id="contactTable">
<td id="contactTable">Reply Required:</td>
<td id="contactTable"><input type="radio" name="reply" value="Yes" checked="checked"/>Yes
<input type="radio" name="reply" value="No" <?php if ($reply="No") echo "checked='checked'"; ?>/>No</td>
</tr>

<tr id="contactTable">
<td id="contactTable">How would you like to be contacted <span class="italic">(if required)</span>?<br/><br/></td>
<td id="contactTable"><input type="radio" name="contact" value="Email" checked="checked"/>E-mail
<input type="radio" name="contact" value="Telephone" <?php if ($contact="Telephone") echo "checked='checked'"; ?>/>Telephone
</td>
</tr>

<tr id="contactTable">
<td id="contactTable"></td>
<td id="contactTable"><input type="reset" name="reset" value="Reset">
<input type="submit" name="submit" value="Submit"></td>
</form>
</tr>
</table>
</div>

<?php include("inc/footer.inc");?>

</body>
</html>

Houdini

Try changing this line

<input type="radio" name="reply" value="No" <?php if ($reply="No") echo "checked='checked'"; ?>/>No</td>

<input type="radio" name="reply" value="No" <?php if ($reply=="No") echo "checked='checked'"; ?>/>No</td>

j4mes_bond25

Houdini wrote:

Try changing this line

<input type="radio" name="reply" value="No" <?php if ($reply="No") echo "checked='checked'"; ?>/>No</td>

<input type="radio" name="reply" value="No" <?php if ($reply=="No") echo "checked='checked'"; ?>/>No</td>

That worked perfectly well. Thanks for your time, help & effort. Much appreciated.