Date greater than or equal to...

bo0

I am having a problem getting the follow snippet of code to work correctly.

I want it to show the text “Not updated.” if all six dates are not greater than or equal to the last run time.

At the moment it will display the text even if just two dates are less than the last run time.

//Date time format: 1152267878

if($pubDate && $pubDate1 && $pubDate2 && $pubDate3 && $pubDate4 && $pubDate5 >= $lastrun){}else{
$body.= "Not updated.\n\n";
}

Installer

These values should be in an array, for many reasons. For one, your code could be simply:

foreach (pubDate_arr as $date) {
    if ($date < $lastrun) {
        $body.= "Not updated.\n\n"; 
        break;
    } 
}

Even if you insist on the "$var1", "$var2", etc. style, you could name them more consistently with the first one being "$pubDate0" instead of just "$pubDate". Then your code could be:

for ($i = 0; $i <= 5; $i++) {
    if (${pubDate . $i} < $lastrun) {
        $body.= "Not updated.\n\n"; 
        break;
    }
}

Your code won't work because you have to compare each item individually, not as a group. Doing it the way you're trying to, the code would be:

if (($pubDate >= $lastrun) && ($pubDate1 >= $lastrun) && ($pubDate2 >= $lastrun) && ($pubDate3 >= $lastrun) && ($pubDate4 >= $lastrun) && ($pubDate5 >= $lastrun)) {
} else { 
    $body.= "Not updated.\n\n"; 
}

Of course, using "||" instead of "&&" will speed up your code (very) slightly and, imo, be more logical:

if (($pubDate < $lastrun) || ($pubDate1 < $lastrun) || ($pubDate2 < $lastrun) || ($pubDate3 < $lastrun) || ($pubDate4 < $lastrun) || ($pubDate5 < $lastrun)) {
    $body.= "Not updated.\n\n"; 
}

bo0

It still displays the message even if just two items have been updated. I want to display the message if ALL items have not been updated. Thanks

Christoph.

Installer

You're being kind of ambiguous. I took "...if all six dates are not greater than or equal to the last run time." to mean "if any of the six is less than, then display the message". If you want each term to be true to satisfy the condition, then write it that way. Such as:

if (($pubDate < $lastrun) && ($pubDate1 < $lastrun) && ($pubDate2 < $lastrun) && ($pubDate3 < $lastrun) && ($pubDate4 < $lastrun) && ($pubDate5 < $lastrun)) { 
    $body.= "Not updated.\n\n"; 
}