[RESOLVED] insert into two tables

StevenB

7 hours of googling, trial and error, countless forums and the manual - no success.

Can it be done? INSERT INTO 2 tables with one form?

I've got this form:

<form action="save_data.php" method="post">
    <input type="hidden" name="id" value="null">
    <input type="hidden" name="linkid" value="null">
<table>
<tr><td align="left">Page Title</td>
<td><input type="text" name="linkName"></td>
</tr>
<tr><td align="left">link</td>
<td><input type="text" name="links"></td>
</tr>
</table>
<?php
$oFCKeditor = new FCKeditor('copyOne') ;
$oFCKeditor->BasePath = '/FCKeditor/';
$oFCKeditor->Value = 'Default text in editor';
$oFCKeditor->Create() ;
?>
      <br>
      <input type="submit" value="Submit">
    </form>

linkid, linkName & links should insert to table "links", and
id and copyOne should insert to table "about"

Here is my last attempt at the form handler:

<?
include 'opendb.php';
$sqlquery = "INSERT INTO table (about) VALUES('$id','$copyOne');";
$sqlquery .= "INSERT INTO table (links) VALUES('$linkid','$links','$linkName');";
$results = mysql_query($sqlquery);
mysql_close();
print "<html><body><center>";
print "<p>Success! Here is the information you entered.<p>";
print "Title : $linkName<br>";
print "Link : $links<br>";
print "Article : $copyOne<br>";

print "</body></html>";
?>

The connection is good, I can post to one table at a time.
I really try not to post my trivial problems here, sorry for being such a noob.
TIA to anyone that an help me out
Steve

etully

$sqlquery = "INSERT INTO table (about) VALUES('$id','$copyOne')";
$results = mysql_query($sqlquery);
$sqlquery .= "INSERT INTO table (links) VALUES('$linkid','$links','$linkName')";
$results = mysql_query($sqlquery);

In other words, write query, execute it, write another query, execute it.

bradgrafelman

Yeah, you can't execute more than one MySQL query at a time.

Also, couple of things:

I wouldn't recommend the use of the short tag style of PHP. Use the full <?PHP instead.
Looks like you're depending on register_globals to be on so that the POST'd variables are automatically created. First thing you need to do is turn OFF register_globals, then you need to get in the habit of properly handling such variables in your code..
'id' sounds like it's a numerical column in your SQL table, such as an integer. If it is, you do NOT want quotes around it.
Along with #2, while you're initializing variables, do some type checking when possible, i.e. is this variable a number or not? Here's an example:

<?PHP
$id = ( isset($_POST['id']) ? intval($_POST['id']) : 0 );
$linkid = ( isset($_POST['linkid']) ? intval($_POST['linkid']) : 0 );
$linkName = ( isset($_POST['linkName'] ? $_POST['linkName'] : NULL );
// etc. for all variables

StevenB

Thanks for the tips.
When all is said and done my biggest problem was in the db. I did not set the linkid to autoincrement, whata idiot I am.

Here's what I ended up with:

<?PHP
$id = ($_POST['id']);
$copyOne = ($_POST['copyOne']);
$linkid = ($_POST['linkid']);
$links = ($_POST['links']);
$linkName = ($_POST['linkName']);
include 'opendb.php';
$mysql= "INSERT INTO about (id, copyOne) VALUES ($id, '$copyOne')";
$results = mysql_query($mysql)or die(mysql_error());
$mysql2= "INSERT INTO links (linkid, links, linkName) VALUES ($linkid, '$links', '$linkName')";
$results = mysql_query($mysql2) or die(mysql_error());
mysql_close();

All of my attempts at type checking produced errors. I'll do some more research on it and try to implement.

First thing you need to do is turn OFF register_globals

First I've heard of them, are they a security risk or just a bad practice to rely on? Will also look for info on this subject.

Thanks to all that helped!

Steve

bradgrafelman

StevenB wrote:
are they a security risk or just a bad practice to rely on?

In my opinion? Both. The former is true, at the very least.

You can search this board or Google for register_globals and you're sure to find information about the security aspect sooner or later.