Simple Registration script....help...going mad

tbobker

Help please, im banging my head against the wall. What is wrong with this simple registration script. I just want to insert the values to test out my site. Im not asking for an improvement just why it is not getting inserted?

<?php 


	if($_POST['submit'])
	{
		$username = $_POST['username'];
		$password = $_POST['password'];
		$email = $_POST['email'];

		include("dbconnect.inc.php");
		$sql ="insert into login values('$username','$password','$email');";
		$result = mysql_query($sql, $conn);

		echo"<a href='admin/index.php'>Login</a>";
	}



?>

<html><body><div align="center">
      <form action="<?php echo $PHP_SELF; ?>" method="post">
      Username:<input type="text" name="username"><br>
      Password:<input type="password" name="password"><br>
      Email Address:<input type="text" name="email"><br>
      <input type="submit">
      </form>
</div></body></html>

notaloser

are username, password, and email the only values in your table on your database?

tbobker

yes, they are the only columns in the database. Thanks for quick reply.

notaloser

place these "or die(mysql_error());" statements after the following 2 lines to see if there is an error in connecting to your database or an error in the query

for example

include("dbconnect.inc.php") or die(mysql_error());
$result = mysql_query($sql, $conn) or die(mysql_error());

halojoy

tbobker wrote:
Help please, im banging my head against the wall. What is wrong with this simple registration script. I just want to insert the values to test out my site. Im not asking for an improvement just why it is not getting inserted?

you should test that:
1. username does not already exist in database
2. most sites require an unique EMAIL address. only 1 account per email.
this is why Email confirmation is often used.
( some also check IP-address, to avoid multiple accounts )

so, at least you should check for username, maybe also email, in database
before you accept registration

notaloser

this might be your error.. haha my eye caught it there at the last second..

$sql ="insert into login values('$username','$password','$email'); ";

tbobker

right, checked for dublicat values in the database..ok, checked for right amount of values being entered...ok, no mysql error, and the semi colon is ok. mmmm....insertion through phpmyadmin is fine, i even tried just entering values in the $sql manually and still nothing, its doing that really annoying thing where you enter the info and it waits.....you hope it will ciome up with the ok, even an error so at least you know.....but no!!!!!1

Oh well thanks for the help guys but im going to bed before i smash the computer up......try agian tomorrow.!!!!!

tbobker

guys such a simlpe thing....as always...forgot to name="submit".