[RESOLVED] Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING on Line 19

[TheHyipSite]

function draw_image ()
{
global $frm;
mysql_connect("xxx", "xxx", "xxx") or die(mysql_error());
mysql_select_db("mikk") or die(mysql_error());
$frm = $frm['lid'];
$data = mysql_query ("SELECT hl_listings.date_added, hl_listings.name, hl_listings.hyip_status, hl_statistics.type, hl_statistics.amount FROM hl_listings, hl_statistics WHERE (hl_listings.expiration = 0 || date_added + interval hl_listings.expiration day >= current_date)and (hl_listings.status = 1) and (hl_listings.id = hl_statistics.listing_id) and(hl_listings.id = '$frm')");

$date= hl_listings.date_added;
$name= $data ['hl_listings.date_added'];
$status= hl_listings.hyip_status;
$ptype= hl_statistics.type;
$amm= hl_statistics.amount;

?>
<table frame=border background ="http://www.TheHyipSite.com/images/Image_bk.gif" cellspacing="10">
<tr>
<td><br><br><br><br><br></td>
</tr>
<tr>
<td><center><?php print $name;?></td>
</tr>
<tr>
<td><center>Paying Status image</td>
</tr>
<tr>
<td><center>Votes go here</td>
</tr>
<tr>
<td><center>what do you think?<br></td>
</tr>
<tr>
<td align="center"><A HREF="http://www.TheHyipSite.com">Vote Here</A><br></td>
</tr>
<tr>
<td><br></td>
</tr>
</table>
</html><?
}

The bolded area above are the fields that i want to use within the table below but when i put them in they dont work?! any ideas? By the way to see what im doing look here : http://www.thehyipsite.com/index.php?a=image&lid=2 notice that "lid" in this link is 2 showing 2's date etc etc but it isnt, which is the current problem!

Thanks guys

Mikk

-text edited to show current problem...thanks to Thomas for fixing the first problem
-text edited to show current problem..thanks to Houdini for fixing the second problem!

[tsinka]

Hi,

I think the error message is caused by another line.

The braces are missing in the line with the mysql_query command. Additionally, the semicolon is missing in the last line.
The code is a little bit hard to read. A way to print large strings that contain a few variables is heredoc syntax that looks like this:

echo <<<EOHTML
<table frame=border background='http://www.TheHyipSite.com/images/Image_bk.gif' cellspacing='10'>
  <tr>
    <td><br></td>
  </tr>
  <tr>
    <td align="center"><br><br><br><br>{$info['name']}</td>
  </tr>
  <tr>
    <td align="center">Paying Status image</td>
  </tr>
  <tr>
    <td align="center">Votes go here</td>
  </tr>
  <tr>
    <td align="center"><A HREF='http://www.TheHyipSite.com.com/'>Vote Here</A><br></td>
  </tr>
  <tr>
    <td><br></td>
  </tr>
</table>
EOHTML;

The advantage is that you don't need to escape the quotes used as string delimiter inside the heredoc block.

Read more about heredoc syntax at: http://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc

Another way:

<?PHP
// some PHP code
?>
a large html block containing
some <?PHP echo $avar; ?> variables
<?PHP
// PHP code continues
?>

Regards,
Thomas

[TheHyipSite]

Thanks Thomas. the error on line 19 is now fixed however i am still having the error on line 6 the . $frm['lid'] is causing the error.

$frm is a string defined elsewere as shown below:

$get = $HTTP_GET_VARS;
  $post = $HTTP_POST_VARS;
  $frm = array_merge ($get, $post);

is the $HTTP_GET_VARS the problem?

[tsinka]

Ok,

the problem is that you use a variable inside a string delimited by single quotes. PHP doesn't parse variables inside single quote strings at all. The bigger problem is that the single quotes delimiting the array index in $from['lid'] break the string.

Do something like:

$Data = mysql_query ('select hl_listings.date_added, hl_listings.name, hl_listings.hyip_status, hl_statistics.type, hl_statistics.amount from hl_listings, hl_statistics where (hl_listings.expiration = 0 || date_added + interval hl_listings.expiration day >= current_date)and (hl_listings.status = 1) and (hl_listings.id = hl_statistics.listing_id) and

(hl_listings.id ='.$frm['lid'].')');

The query looks suspicious:

Look at that part:

(hl_listings.expiration = 0 || date_added + interval hl_listings.expiration day >= current_date)and

This will cause a SQL error. How do the tables look like and which data do you want to get with that query ?

Thomas

[tsinka]

One mor thing:

Which PHP version do you have ? I'd rather use $GET and $POST instead of $HTTP_GET_VARS and $HTTP_POST_VARS

[Houdini]

Try this rewrite

$frm = $frm['lid'];
$Data = mysql_query ("SELECT hl_listings.date_added, hl_listings.name, hl_listings.hyip_status, hl_statistics.type, hl_statistics.amount FROM hl_listings, hl_statistics WHERE (hl_listings.expiration = 0 || date_added + interval hl_listings.expiration day >= current_date)and (hl_listings.status = 1) and (hl_listings.id = hl_statistics.listing_id) and(hl_listings.id = '$frm')");

[TheHyipSite]

Thanks Houdini, yet another problem though, probably something reallly simple!

[TheHyipSite]

Problem solved guys thanks for your help!