[RESOLVED] Conditionally checking for die()?

kilbey1

I had some problematic code in which a conditional check for die killed the rest of the script. What's the best approach to see if something actually does die, so I can implement some alerts? The manual doesn't seem to mention this.

The resulting code would have the following logic:
1. $sql = insert statement
2. mysql_query($sql) or die ("Failed");
3. $errmsg = "Failed query";
4. if die = true, then fwrite to log, else fwrite $sql to log

However, die always seems to evaluate as true.

The code in question:

					$sql = "INSERT INTO $imagesTable ($imageFields) VALUES('NULL', '$name', '$path', '$type', '$size');"; 
					mysql_query($sql) or die("Failed Query of " . $sql);
					if (die) {
						$msg = "Insert failed: " . $sql . "\n";
						if(file_exists($logdir)) {
							fwrite($output, $msg);
						}
					} else {
						$msg = $sql . "\n";
						if(file_exists($logdir)) {
							fwrite($output, $msg);
						}
					}

radam

Kilbey1,

die() is in fact equivalent to exit(), which simply exits the script. Hence when testing for die (if(die)...), you are called the die() function and the script is exiting.

Instead, try somthing like this:

<?php
 $sql = "INSERT INTO $imagesTable ($imageFields) VALUES('NULL', '$name', '$path', '$type', '$size');";
                    $res = mysql_query($sql);
                    if ($res == false) {
                        $msg = "Insert failed: " . $sql . "\n";
                        if(file_exists($logdir)) {
                            fwrite($output, $msg);
                        }
                    } else {
                        $msg = $sql . "\n";
                        if(file_exists($logdir)) {
                            fwrite($output, $msg);
                        }
                    } 
?>

I hope that helps (check the php manual for mysql_query() for more information)

Houdini

If you want to see where the script dies then with each die() you can include text to be printed by that die for example

$connect = mysql_connect('localhost','me','password')
  or die("The connection failed. MySQL said: ".mysql_error());
$select = mysql_select_db($mydb,$connect)
  or die("The database selection killed the script MySQL said: ".mysql_error());

MarkR

Do not use die() to throw an error. PHP has two perfectly good mechanisms for doing this, user_error() and throw (PHP5+).

die() is not an error handling mechanism; if you think it is, you've got PHP confused with Perl.

Mark

kilbey1

Thanks all. Putting the mysql_query($sql) into a variable and testing on that works out. I didn't know user_error (trigger_error) existed! Looks like the days of die() may be over for me. 🙂

Thanks!