Mysql_query syntax error

Staggy11

I'm having a problem with two mysql_querys. Each one has the same error, which is that I get the following message:

Warning: mysql_query() [http://www.mysql.com/doc]: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE username='Test3'' at line 1 in <my site>/map.php on line 10

The code for that section is:

$playerx = mysql_query("SELECT `x` WHERE `username`='".$_SESSION['username']."'");
$playery = mysql_query("SELECT `y` WHERE `username`='".$_SESSION['username']."'");

(As you can probably guess, I'm using 'Test3' as a username, whih is why it appears in the error message.)

What I think is happening is that part of the variables are being read as the query, and vice versa. I think that it may be to do with the use of ' and `. Please could anyone help me out, or give me pointers on how to solve this?

dcav

You do not have a table name specified.

"SELECT field FROM table WHERE condition"

bradgrafelman

As dcav said, you don't have a proper SELECT statement there - you didn't tell it what table! For more information on how SELECT queries work, see this page of the MySQL manual.
Why have two separate queries?

$query = 'SELECT `x`, `y` FROM `myTable` WHERE `username`=\'' . $_SESSION['username'] . '\' LIMIT 1';
$exec = mysql_query($query) or die('Error: ' . mysql_error());
$coordinate = mysql_fetch_assoc($exec);

echo 'Your coordinates are: ' . $coordinate['x'] . ',' . $coordinate['y'];

Staggy11

Thanks for the replies. I cannot believe that I over looked the FROM part! It works fine now.

However, another, simliar problem has shown up.

This time the message is

Warning: mysql_query() [http://www.mysql.com/doc]: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND y = AND username != ''' at line 1 in /var/www/virtual/staggy11.byethost3.com/htdocs/maptest.php on line 13
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND y = AND username != ''' at line 1

and the code is

$name = $_POST['username'];

$result = mysql_query("SELECT `username` FROM `players` WHERE `x` = ". $object[5]->x ." AND `y` = ". $object[5]->y." AND username != '$name'") or die(mysql_error());

I'll have probably missed somethignobvious out, but I am quite new at this. I'm sorry to keep asking this, but can anyone see what I have done wrong?

bradgrafelman

If you'll echo the query OR read the error message, you'll see that $object[5]->y and $name aren't being set properly.

Staggy11

Ok, Ive managed to sort out $name. I realised I had being using $POST instead of $SESSION.

But $object[5]->y on the other hand...well, I'm having trouble with it.

First I have

if (($_POST[x])||($_POST[y]))
	{
$playerx = $_POST[x];
$playery = $_POST[y];	
}
else {
$playerx = mysql_query("SELECT `x` FROM players WHERE `username`='".$_SESSION['username']."'");
$playery = mysql_query("SELECT `y` FROM players WHERE `username`='".$_SESSION['username']."'");

if (((!$playerx)||(!$playery))||(($playerx<=0)||($playery<=0)))
{
$playerx = 2;
$playery = 2;
}
}

and then

$result = array();
$i = 1;
while ($i <= 9)
{
$result[$i] = mysql_query("SELECT * FROM map WHERE x = '$x[$i]' AND y = '$y[$i]'");
$i += 1;
}
$object = array();
$i = 1;
while ($i <= 9)
{
    $object[$i] = mysql_fetch_object($result[$i]);
    $i += 1;
}

to assign it. But I cant work out where its going wrong.

Could it be a problem with the if statements I am using to define $playerx and $playery? But if it is, why is it only affecting $playery, and not $playerx as well.