Variable from address bar ??

astur

Im stuck with this.

I have an script i made 3 years ago, and it worked perfectly with the PHP version i had, now i try it with the version 5 and it doesn't work!!

I try to get a variable value from the address bar and it doesn't recognize it!!

this is the value in the address bar:

http://localhost/f/showthreads.php?ca=10&p=1

this is the code:

<?php

include "config.php";

//cookie user tracking

if (isset($_COOKIE['track'])){

} else{

$id=uniqid($remote_addr);

setcookie("track",$id,time()+31536000,'/'); }

// end user tracking

$action = GetAction("showthreads.php");

$category = getName($ca);

etc....

And this is the error i get!!
Notice: Undefined variable: ca in C:\Web\WebServer\Apache2\htdocs\f\showthreads.php on line 19

Line 19 corresponds to: $category = getName($ca);

This language has changed very much in 3 years?? OMG, i had to made a change to all my scripts that began with <?, to <?php, or it wouldn't recognize the scripts!!!

halojoy

to read any variable value from URL
like

page.php?ca=10&p=1

we now use $_GET

$_GET is an array holding all posted variables and values

In my example
$GET['ca'] = '10'
$GET['p'] = '1'

so change line 19 to

$category = $_GET['ca'];

astur

halojoy wrote:
to read any variable value from URL
like

page.php?ca=10&p=1

we now use $_GET

$_GET is an array holding all posted variables and values

In my example
$GET['ca'] = '10'
$GET['p'] = '1'

so change line 19 to
$category = $_GET['ca'];

Thank you very much!!

I changed the PHP.ini settings and set register_variables = on and it works without changing a thing!!

I'm having trouble also with uninitialized variables, i used to check

if(!variable) //if variable doesn't exist
$variable = default;

it seems this trick doesn't work now :S, is there any way to check if a variable exists or not??

thorpe

Having register_globals switched on is a security risk, that is why it is now off by default. Better to change your code.

As for your other problem, use [man]isset/man. eg;

if (!isset($foo)) {
  $foo = 'bar';
}

astur

thorpe wrote:
Having register_globals switched on is a security risk, that is why it is now off by default. Better to change your code.

As for your other problem, use [man]isset/man. eg;
if (!isset($foo)) {
  $foo = 'bar';
}

Then i will follow your advice and change my code, im building a little forum, its nothing important even if its hacked, but good programming practice never hurts 🙂 🙂

for my other problem, I wonder why it doesn't work any longer that way, it was easier!! 😕 😕

Thanks again!

thorpe

It should still work, once again though... bad coding practice. It should issue a warning if you have error reporting turned up high enough.

if (!$variable) {
  $variable = 'foo';
}

You were missing the $ in your example.