Code loading way to slow... suggestions.

[chrisj8221]

I was wondering if I could have someone review the code below and point out any ideas to streamline it.

The code does work, but seems to take forever to process. I have tried it on a few different computers and they are all slow.

Any suggestions would be greatly appreciated.

<?php 
include ("review/config.php"); 
include ("http://www.diyaudiobuilder.com/templates/header_graphic.inc");
include ("http://www.diyaudiobuilder.com/templates/header.inc"); 

$words="";
if (isset($_GET['words']) && $_GET['words']!="")
{
	@$words=stripslashes($_GET['words']);
}
 ?>

<?php // form for the input of search criteria in search box  ?>

  <form method="get" action="<?php echo "$directory"; ?>/search/index.php">
  <div align="center">
  <input type="hidden" name="cmd" value="search" />
   Search for: 
  	  <input name="words" type="text" value="<?php echo "$words"; ?>" size="20"  
              maxlength="255" />&nbsp;in&nbsp;

<select name="searchWhere">
 	<option value="0" <? if(@$_GET['searchWhere']=="0") echo "selected"

 ?>>Reviews</option>
 	<option value="1" <? if(@$_GET['searchWhere']=="1") 

echo "selected" ?>>Summary</option>
	<option value="2" <? if(@$_GET['searchWhere']=="2") 

echo "selected" ?>>Item Name</option>
	<option value="3" <? if(@$_GET['searchWhere']=="3") 

echo "selected" ?>>Categories</option>
</select>

 <input name="mode" type="hidden" value="normal"> 
 <input type="submit" value="Search" />

<?php // clickable hyperlinks to right of search criteria box  ?>

&nbsp; &nbsp; &nbsp; 

|
</span><a href="<?php echo "$directory"; ?>/index2.php?item_id=1&<?=@SID?>">Review</a>
|
<? if (@$_SESSION['signedin'] != "y") { ?>
    <a href="<?php echo "$directory"; ?>/login/signin.php">Login</a><? } else { 
@$back = $_SERVER['PHP_SELF'];
?>
        <a href="<?php echo "$directory"; ?>/logout.php?<?=SID?>">Logout</a>
        <? } ?>
        <? if (@$_SESSION['signedin'] != "y") { ?>
|
<a href="<?php echo "$directory"; ?>/login/register.php?item_id=<? echo @$_GET['item_id']; ?>">Register</a>
<? } else { 
$back = $_SERVER['PHP_SELF'];
?>
<? } ?>
|
<a href="<?php echo "$directory"; ?>/usercp/index.php?<?=@SID?>">User Control Panel</a>
|

</form>

Thanks in advance for the help

Chris

[halojoy]

when you include remote files from other server
things can be slow, at least not AS FAST as at your server
Iif files are found - but what you do if that website IS DOWN???

include ("http://www.diyaudiobuilder.com/templates/header_graphic.inc");
include ("http://www.diyaudiobuilder.com/templates/header.inc");

you should defintively download those 2 files
and put them at YOUR website

I take it as a rule:
Never to include remote images or files into my website scripts
Because I dont want slow webpages or stuff not found.

.

[halojoy]

this is
http://www.diyaudiobuilder.com/templates/header_graphic.inc

<table width="750" border="0" align="center" cellpadding="0" cellspacing="0">
  <tr>
    <td><img src="http://diyaudiobuilder.com/com_images/diy_header_logo.gif" width="240" height="40"></td>
	<td></td>
  </tr>
</table>
</body>
</html>

you should of course also download:
http://diyaudiobuilder.com/com_images/diy_header_logo.gif
and put diy_header_logo.gif in YOUR image folder.

When you are all done,
this link: http://diyaudiobuilder.com/
should NOT be found anywhere in your script

🙂

[chrisj8221]

thanks for the quick reply - unfortunately, diyaudiobuilder.com is my site so files are on same server. I have used the http:// address as I need to "include" the file in a bunch of coding located on different folders throughout the site and it seemed more direct than the old "../folder1/folder2/templates/header.inc" as that only works if the file is called from the same folder location on the site.

chris

[halojoy]

chrisj8221 wrote:

thanks for the quick reply - unfortunately, diyaudiobuilder.com is my site so files are on same server

yeah, I thought maybe there was such a chance 😃

but those includes is the only thing i can find
that might make your script slow

[halojoy]

you can try this:

you can define, in config.php, a variable: $servroot
that can be used instead of 'http://website.com'

<?php 

include ("review/config.php"); 
$servroot = $_SERVER["DOCUMENT_ROOT"];

include ($servroot . "/templates/header_graphic.inc");
include ($servroot . "/templates/header.inc"); 

$words="";
if (isset($_GET['words']) && $_GET['words']!="")
{
	@$words=stripslashes($_GET['words']);
}

 ?>

[chrisj8221]

good idea. I will try that and see if it helps. thanks for all the input!

chris

[sBForum]

You can also use : file

like:

<?php

$file = "http://www.diyaudiobuilder.com/temp...der_graphic.inc";
$allfile = implode("",file($file));
$allfile = str_replace("http://diyaudiobuilder.com/com_images","images",$allfile);

echo $allfile;

?>

that for including the file with local images .... But it should open the remote file. .. so the speed will not be higher ....!!

thanks to all 😃