[RESOLVED] how would you?

rbblue8

Hey,

I have this table that is generated by a while loop. That table sits inside a form, and inside each table are form fields.  I have converted all the form fields into arrays by adding [] there name....  When they hit update...  I need my php script to update the sql table with the data.

the issue i'm having... is how do i make my each() loop for each field?

when i did my mail script i did something like

$delete=$_POST['message_id'];

while(list($k,$v) = each($delete))
	{
	$string=("DELETE from mail where message_id='$v'");
	$query=mysql_query($string, $db) or $error='<center id="error">Error while removing your messages<br />'.mysql_error().'</center>';
	}//end of while

but that was for only on field. and from i can tell... you can do not
each($field one, $field2, $field3, etc, etc, etc)

some people suggest an array... but how?

kind of lost here :-/

Earnan

What are field1, 2, 3, etc? Are they the same data?

If you name the fields on the form with the same array name and [ ], then they will all be in the same array (and, therefore, in $delete).

rbblue8

Hey..

they all have different field names. some are check boxes... some are text fields a i have a drop down menue.

all of which are filled out by data that is currently in the database.

rbblue8

ok... well i did as you asked... but i'm running into a issue.

the issue is... I'm getting a number where I should not... basically that number is the $order value in the code below. But i'm only printing the $descritpion. Basically where is the $order value comming from?

here is the echo out put when i submit the script.

desc=;desc=1;desc=;desc=1;desc=;desc=1;desc=;desc=1;desc=me as of blah;desc=3;

desc shold be blank all the way around. I can change the 1's to anything i want to by changing it's value on the form page thats posting to this script.

this is the php code that is handling the update to the sql database. However.. there is not sql code there for i do not want to mess around w/ it until the script is rdy.

//code to update the pictures
if(!isset($error) and isset($_POST['update_pictures']))
	{//start of if statment (delete, add descritption)
	echo'you made it here';

$data=$_POST['information'];
while(list($k,$v) = each($data))
    {
	$aray=$v.';';
	list($description, $delete, $order, $id) = explode(";", $aray);
	echo 'desc='.$description.';';
    }//end of while

}//end of if statment (delete, add descritpions

and here is the forum code.

			<table width="283" border="1" id="picture_layout_table" align="center">
      		<tr>
		    <td colspan="2"><center><img src="http://personals.nightlance.com/pictures/'.$result['file_name'].'" width="220px" height="150px"/></center></td>
	        </tr>
	        <tr>
	        <td width="118">Descritpion: 
  	        <label></label></td>
	        <td width="149"><input name="information[]" type="text" id="information[]" value="'.$result['descritpion'].'"/></td>
	        </tr>
	        <tr>
	        <td>Delete Picture? 
	        <label></label></td>
	        <td><input name="information[]" type="checkbox" id="information[]" value="delete" /></td>
	        </tr>
     	    <tr>
	        <td>Order: 
	        <label></label></td>
	        <td>
			<select name="information[]" id="information[]">
			<option selected="selected">'.$result['order'].'</option>
			<option>1</option>
			<option>2</otpion>
			<option>3</option>
			<option>4</option>
			<option>5</option>
	        </select></td>
	        </tr>
	        </table>

Earnan

I am confused as to why you are using arrays. I understand using an array for a multiselect form field, but why would you use one for a checkbox?

Is the goal to find one piece of code to manage all of the form updates? If so, you may want to build a function to manage the update and pass the Key ID and value to it. I think you have to handle the individual items one at a time. The only option I can think of for an array is to name all of them the same, but add a level (i.e.: arraysomething[ID][ ]).

rbblue8

Hey...

some back ground info...

this page is a photo update page. It displays photos that the user has uploaded to the site.

i have all "controls" for that picture in a table (the above html code). Now since I do not know how many pictures they will be uploading i do not want empty tables sitting around... so i have a table generated per picture that the database finds under there user name. That way it's all right there and simple.

so now i have a page that displays all of there pictures. The goal here is to... allow them to make changes to all pictures, hit submit once, and have the script update all the pictures to all the new settings. Nice and simple for the end user 🙂.

now... once i get to the query part it will be easy to handle.. the value $id is the picture id that is different from all pictures and users. It's generated the second the picture is uploaded to the DB.

so all the controls are turned into an aray and then seperated out in the php code.

the only issue i'm having is that some how my script is pulling a value that it should not. So I'm defently thinking it's a code error.

does that help shine some light as to what i did and why?

Earnan

Well, the checkbox you are going to need to handle differently since it is a delete and not an update (unless you are keeping the picture and just updating an "active" flag).

Is all of this information on the same row in the table? I would assume so.

You don't need to use arrays for these, as there is only one option available each time. The text is the text, the checkbox is checked or not, the option buttons only have one result. Just leave them a varaible name. Look for the Delete first, if it is there, do what you are going to do. If it is not, then pull in each of the others one at a time. You can create a single update SQL if you want, but you need to pull in the values one at a time.

You also should have a hidden value with the Primary Key ID for the table row so you can reference it directly in your SQL statement.

rbblue8

hey.. i do have a hidden value in my forum... and it is the primary key ID in the sql table.

now.. going with your thinking.... if all the field names are named different... and i only make one of them an aray (picture id). and i submit the results...

would the data from table one NOT get over wirttin from data in table 5? since table 5 is the last bit of information going to the submit script and table one is the first data going in?

Earnan

AAH...yes, yes it does!!!

Then you were right the first time, you want each name to be unique and an array (i.e.: description[]).

Take a look at "foreach" in the manual.

$description = $_POST['description'];
foreach ($descrption as $key -> $value) {
updatetable("descrption_columnname",$id,$value);
}

The above may be off on syntax since I am doing it off of memory. This is assuming you have built a function called updatetable that is looking for the column name, the ID and the value to update.

Though, as I think about it, you are probably going to need to get the ID in the array to process it this way. Build the form with description[$id][].

rbblue8

huh?

why would i recode what i have all rdy? i have all the information, and it's sorted as needed. what i'm saying here is that NOW the issue is... i'm getting a value printed where I should not! which will mess up... well everything. all the form fields are comming in as a string of information seperated my a ;. then the script takes everything before the ; and gives it a value. but like i keep saying... the value $order (which is a number) is being printed every where.... when it should not.

rbblue8

Hey...

coded like this

//code to update the pictures
if(!isset($error) and isset($_POST['update_pictures']))
    {//start of if statment (delete, add descritption)

$data=$_POST['information'];
while(list($k,$v) = each($data))
    {
    $aray=$v.';';
    list($description, $delete, $order, $id) = explode(";", $aray);
    $string=("UPDATE pictures SET description='$description', order='$order' WHERE picture_id='$id' and username='$user'");
	echo $string.'<br />';
    }//end of while

}//end of if statment (delete, add descritpions

i get the following output.

UPDATE pictures SET description='', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='1', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='2', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='1', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='3', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='1', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='4', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='1', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='5', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='me as of blah', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='3', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='1', order='' WHERE picture_id='' and username='test'

It appears that it's putting everything in the description field as u can see everything else but username is empty. so perhaps i need to add a foreach loop inside the php script under the while statment??

rbblue8

i'm thinking the error is here..

list($description, $delete, $order, $id) = explode(";", $aray);

for only $description is getting filled out... how come??

rbblue8

um ok... yeah really start to talk to my self here...

by doing this

//code to update the pictures
if(!isset($error) and isset($_POST['update_pictures']))
    {//start of if statment (delete, add descritption)

$data=$_POST['information'];
while(list($k,$v) = each($data))
    {
    $aray=$v.';';
    list($description[]) = explode(";", $aray);
    $string=("UPDATE pictures SET description='$description[0]', order='$description[1]' WHERE picture_id='$description[2]' and username='$user'");
    echo $string.'<br />';
    }//end of while

}//end of if statment (delete, add descritpions)

i get the following output

UPDATE pictures SET description='me as of blah', order='' WHERE picture_id='' and username='test'
UPDATE pictures SET description='me as of blah', order='3' WHERE picture_id='' and username='test'
UPDATE pictures SET description='me as of blah', order='3' WHERE picture_id='1' and username='test'

so i'm guessing i need to re-think this whole thing... b/c there are three fields that are being filled out hence the reason why i get three outputs.

right?

Earnan

Yes, you probably need to update Description, then later update Order. There may be a better way to do it, but I am not thinking of it off the top of my head.

cgraz

For your DELETE query, if your checkboxes look like this

Then you don't need a loop, you can run your DELETE query like this:

$query = "DELETE FROM mail WHERE message_id IN ('" . implode("','", $_POST['message_id']) . "')";

rbblue8

thx 😉

ok earnan... lets say that i do break apart and update the description and order in different query's.. how do i get the picture ID there? with out the picture ID, the query has no idea what row i'm talking about in my query and there for will update everything, update nothing, or throw an error depending how my query is worded.

the funny this.... when i code like this.

//code to update the pictures
if(!isset($error) and isset($_POST['update_pictures']))
    {//start of if statment (delete, add descritption)

$data=$_POST['information'];
while(list($k,$v) = each($data))
    {
    $aray=$v.';';
    list($description[]) = explode(";", $aray);
    }//end of while
    $string=("UPDATE pictures SET description='$description[0]', order='$description[1]' WHERE picture_id='$description[2]' and username='$user'");
    echo $string.'<br />';    
}//end of if statment (delete, add descritpions)

and i submit the page.. i get this
UPDATE pictures SET description='', order='1' WHERE picture_id='6' and username='test'

which is correct! but that's only for the first table. and if i have three tables.. and make changes to the 2nd and third... they do not get updated @ all.

Earnan

In the form, make it description[$id][] instead of description[]

Do two foreach
foreach ($description as $key -> $id) {
foreach ($id as $key -> $data) {
UPDATE pictures SET description='".$data."'', order='1' WHERE picture_id='.$id."' and username='test'
}
}

Again...written off the top of my head, so syntax may be off.

rbblue8

ok.. what does $id define? or what defines $id? could it be something like description[$result-[picture_id']][] b/c $result['picture_id'] is givan from the database.

the only issue that i see there... is order='1' is also a value that the user needs to defined. But i think i can write something up there to make it work...

i'm very lost of how the above code may work. very lost. but hell. at this point.. i will try anything.

Earnan

Sorry....

$id should be the row Primary Key, you already said you had it on a hidden field in each form...instead, put it in the array for each form part.

For $description, leave out the order part.
when you do $Order, leave out the description part.
etc.

If you want to make this into a more generic function, then feed the function the column name, the PK ID and the data.

i.e.:

//Call the function:
foreach ($description as $key -> $id) {
   foreach ($id as $key -> $data) {
      Function UpdateTable($id, "description", $data) {
   }
}

//Here is the function:
Function UpdateTable($ID, $ColumnName, $Data) {
   Global $username;
   $ssql = "UPDATE pictures SET ".$ColumnName."='".$Data."' WHERE    picture_id='".$id."' and username='".$username;
   $runsql = mysql_query($ssql) or die ("Error: ".mysql_error());
}

Then when you do your Order update:

//Call the function:
foreach ($order as $key -> $id) {
   foreach ($id as $key -> $data) {
      Function UpdateTable($id, "order", $data) {
   }
}

rbblue8

Hey,

ok.. so i'm a pain in the as*. I really do not understand what was posted above.. and i copyed and pasted and it did not work for @ all.

so while i was throwing things around the office i thought of another idea... but i may be completly wrong here...

i'm this code.

//code to update the picture description
if(!isset($error) and isset($_POST['update_descriptions']))
    {//start of if statment (change descritption)
   	$id=$_POST['id'];
	$order=$_POST['order'];
	$desc=$_POST['desc'];

while(list($k, $v) = each($id))
	{
	while(list($k, $g) = each($desc))
		{
		while(list($k, $o) = each($order))
			{
			$string=("UPDATE pictures SET order='$order', description='$desc' WHERE picture_id='$id'");
			echo $string;
			}
		}
	}

}//end of if statment (change descritption)

with the html table looking like this.

<table width="283" border="1" id="picture_layout_table" align="center">
      		<tr>
		    <td colspan="2"><center><img src="http://personals.nightlance.com/pictures/'.$result['file_name'].'" width="220px" height="150px"/></center></td>
	        </tr>
	        <tr>
	        <td width="118">Descritpion: 
  	        <label></label></td>
	        <td width="149"><input name="desc[]" type="text" id="desc[]" value="'.$result['descritpion'].'"/></td>
	        </tr>
	        <tr>
	        <td>Delete Picture? 
	        <label></label></td>
	        <td><input name="information[]" type="checkbox" id="information[]" value="delete" /></td>
	        </tr>
     	    <tr>
	        <td>Order: 
	        <label></label></td>
	        <td>
			<select name="order[]" id="order[]">
			<option selected="selected">'.$result['order'].'</option>
			<option>1</option>
			<option>2</otpion>
			<option>3</option>
			<option>4</option>
			<option>5</option>
	        </select>
			<input name="id[]" type="hidden" id="id[]" value="'.$result['picture_id'].'"/>
			</td>
	        </tr>
	        </table>

my thinking behind this... it will define everything... and once that is done... i will ahve my query constructed. but it's not echo-ing anything.

is this wrong? will it not work like this?